[Owyn]

indeed here we check attack first then do traceline, there the reversed way, but it is still not a good way to count hits

[joaquimandrade]

Why?

(And it's not the reverse. In that one it is being checked every traceline where the IN_ATTACK is pressed. In the one i've posted a traceline is made when an attack occurs)

[SchlumPF*]

gonna try something later i guess to support knives and guns

[Arkshine]

@joaquimandrade: What I don't understand is why in TraceAttack() there is a check to see if it's hitting the shield and when you shot on it TraceAttack is not called at all. Oo

[joaquimandrade]

Originally Posted by arkshine @joaquimandrade: What I don't understand is why in TraceAttack() there is a check to see if it's hitting the shield and when you shot on it TraceAttack is not called at all. Oo

Where?

[Owyn]

probably in your super shield plugin, but there i think cuz shield is not worn

[stupok]

@joaquimandrade:

arkshine is pointing out an oddity in the code you posted in this thread.

I'll try to explain...

You're hooking TraceAttack, so it should be called when a player attacks with a weapon that makes tracelines. However, you said this:

when you hit a shield a traceattack doesn't occur and the shield doesn't even exist as an entity

I think arkshine did not notice that you're creating an additional traceline, so he was confused, thinking that the function would never be called.

For me, two things are very odd:

1. Why does your additional traceline detect the shield?
2. Why isn't a traceattack triggered when the client shoots a shield?

It's just strange o_O

[Arkshine]

Stupok, I was talking in the CS code, by disassembling, IsHittingShield() is called from TraceAttack() at the top of function.

CBasePlayer::IsHittingShield(Vector const &,TraceResult *)

It's possible that this function return false by default et thus not used here.

[joaquimandrade]

Stupok, i'm not hooking traceAttack i'm hooking Weapon_PrimaryAttack.

About arkshine question, i don't know. I guess that when "IsHittingShield" returns true the TraceAttack is blocked and thus not forwarded but i really don't know.

(And as a note, in Super Shield plugin is different because the shields that it handle are real entities so it is more easy than this)

[Arkshine]

Actually IsHittingShield() would looks like like in css ( code not from me, somewhere on internet ) :

  
bool CCSPlayer::IsHittingShield( const Vector &vecDirection, trace_t *ptr )
{
    /*
    if ( HasShield() == false )
        return false;

    if ( ptr->hitgroup == HITGROUP_SHIELD )
        return true;
     
    if ( m_bShieldDrawn == false )
        return false;

    Vector2D    vec2LOS;
    float       flDot;

    Vector vForward;
    AngleVectors( GetAbsAngles(), &vForward );

    vec2LOS = vecDirection.Make2D();
    vec2LOS = vec2LOS.Normalize();

    flDot = DotProduct ( vec2LOS , vForward.Make2D() );
    
    if ( flDot < -0.87f )
        return true;
    */
    
    return false;
}

void CCSPlayer::TraceAttack( const CTakeDamageInfo &info, const Vector &vecDir, trace_t *ptr )
{
        bool bShouldBleed = true;
        bool bShouldSpark = false;
        bool bHitShield = IsHittingShield( vecDir, ptr );

        CBasePlayer *pAttacker = (CBasePlayer*)ToBasePlayer( info.GetAttacker() );

        if ( ( GetTeamNumber() == pAttacker->GetTeamNumber() ) )
                bShouldBleed = false;
        
        if ( m_takedamage != DAMAGE_YES )
                return;

        m_LastHitGroup = ptr->hitgroup;
        float flDamage = info.GetDamage();

        if ( bHitShield )
        {
            /*
            flDamage = 0;
            bShouldBleed = false;

            if ( RANDOM_LONG( 0, 1 ) )
                EMIT_SOUND(ENT(pev), CHAN_VOICE, "weapons/ric_metal-1.wav", 1, ATTN_NORM );
            else
                EMIT_SOUND(ENT(pev), CHAN_VOICE, "weapons/ric_metal-2.wav", 1, ATTN_NORM );
                
            UTIL_Sparks( ptr->vecEndPos );

            pev->punchangle.x = flDamage * RANDOM_FLOAT ( -0.15, 0.15 );
            pev->punchangle.z = flDamage * RANDOM_FLOAT ( -0.15, 0.15 );

            if (pev->punchangle.x < 4)
                pev->punchangle.x = -4;
 
            if (pev->punchangle.z < -5)
                pev->punchangle.z = -5;
            else if (pev->punchangle.z > 5)
                pev->punchangle.z = 5;
            */
        }
        else
        {
            switch ( ptr->hitgroup )
            {
            
            }
        }
            
        [...]    
}

When you see in the CS disassembled the code seems to be the same. That's why I don't understand why TraceAttack is not called.