[ConnorMcLeod]

get_players was returning false results when using flag "e" with dead players, and only in some situations, it has been fix some time ago.

[dFF]

Originally Posted by ConnorMcLeod get_players was returning false results when using flag "e" with dead players, and only in some situations, it has been fix some time ago.

I can't finde where ist fixed get_players in amxx shortlog list.

[Black Rose]

Each method in a loop of 10 000 000 times.

#include <amxmodx>
#include <fakemeta>
#include <cstrike>

public plugin_init() {
    register_plugin("Test Plugin 7", "", "");
    
    set_task(5.0, "test1")
}

#define LOOPS   10000000

public test1() {
    
    new MaxClients = global_get(glb_maxClients);
    new Timer = get_systime();
    
    for ( new c = 0 ; c < LOOPS ; c++ ) {
        new Players[32], PlayersNum;
        get_players(Players, PlayersNum, "ace", "TERRORIST");
        for ( new i = 0 ; i <= PlayersNum ; i++ ) { }
    }
    
    server_print("Method 1: %d", get_systime() - Timer);
    Timer = get_systime();
    
    for ( new c = 0 ; c < LOOPS ; c++ ) {
        new team[32];
        for ( new i = 1 ; i <= MaxClients ; i++ ) {
            if ( is_user_alive(i) && ! is_user_bot(i) && get_user_team(i, team, charsmax(team)) == 1 ) { }
        }
    }
    
    server_print("Method 2: %d", get_systime() - Timer);
    Timer = get_systime();
    
    
    for ( new c = 0 ; c < LOOPS ; c++ ) {
        for ( new i = 1 ; i <= MaxClients ; i++ ) {
            if ( is_user_alive(i) && ! is_user_bot(i) && cs_get_user_team(i) == CS_TEAM_T ) { }
        }
    }
    
    server_print("Method 3: %d", get_systime() - Timer);
}

Method 1: 2
Method 2: 19
Method 3: 18

Bare in mind though that this was a server with no players.
Get players will still use the team name to retrieve a team ID before looping players.
It's still faster than both other methods, which are only calling is_user_alive() since it will return false. Maybe the time is just being spent in the actual looping than just calling natives.

[r0ck]

Originally Posted by dFF @r0ck, you was used get_players in zombie mod ? Explain better (with some code example if you can) what is the problem exactly. Maybe sometimes get_players with team-flag can result wrong in zombie mod, because zombiemod change team a lot of times and can't be updately instantly.. or somethings like this (with some private datas, scoreboard, etc.).

For Example xPaws Deathrun Manager in my multimod server ( experienced a lot till i changed get_players )
( Semiclip Code )

Originally Posted by ConnorMcLeod get_players was returning false results when using flag "e" with dead players, and only in some situations, it has been fix some time ago.

ohk... but what about get_players not working till we didn't restarted the server ? isn't that weird ?
Btw it was fixed in 1.8.2 or 1.8.1 ?
Thanks

EDIT : Black Rose , we know get_players is fast but its just about bug...

[seriousspot]

Originally Posted by Black Rose Each method in a loop of 10 000 000 times. #include <amxmodx> #include <fakemeta> #include <cstrike> public plugin_init() {     register_plugin("Test Plugin 7", "", "");         set_task(5.0, "test1") } #define LOOPS   10000000 public test1() {         new MaxClients = global_get(glb_maxClients);     new Timer = get_systime();         for ( new c = 0 ; c < LOOPS ; c++ ) {         new Players[32], PlayersNum;         get_players(Players, PlayersNum, "ace", "TERRORIST");         for ( new i = 0 ; i <= PlayersNum ; i++ ) { }     }         server_print("Method 1: %d", get_systime() - Timer);     Timer = get_systime();         for ( new c = 0 ; c < LOOPS ; c++ ) {         new team[32];         for ( new i = 1 ; i <= MaxClients ; i++ ) {             if ( is_user_alive(i) && ! is_user_bot(i) && get_user_team(i, team, charsmax(team)) == 1 ) { }         }     }         server_print("Method 2: %d", get_systime() - Timer);     Timer = get_systime();             for ( new c = 0 ; c < LOOPS ; c++ ) {         for ( new i = 1 ; i <= MaxClients ; i++ ) {             if ( is_user_alive(i) && ! is_user_bot(i) && cs_get_user_team(i) == CS_TEAM_T ) { }         }     }         server_print("Method 3: %d", get_systime() - Timer); } Method 1: 2 Method 2: 19 Method 3: 18 Bare in mind though that this was a server with no players. Get players will still use the team name to retrieve a team ID before looping players. It's still faster than both other methods, which are only calling is_user_alive() since it will return false. Maybe the time is just being spent in the actual looping than just calling natives. For those of you that get false results with the team flag, at which point is the function called? Event, command, forward et.c.

dumb comparision also i am using cached values, ands theres only 32-33 loops depends on get_maxplayers

[Black Rose]

Of course it's a dumb comparison. I don't have any players on my server.

The loops are basically the same. I used glb_MaxClients. get_players() also limits the loop to maxplayers. The difference being that the loop is running as a plugin or as a module. Obviously the module is faster.

You didn't understand my usage of LOOPS. I ran the player loops 10 000 000 times. It's a 2 dimensional loop. I didn't search for 10 000 000 players. So 32*10 000 000 = 320 000 000 possible players to process. If you divide the 19 seconds by 10000000 to get the time of one run it would be .0019 milliseconds. That is of course with no players.

In the end the difference, unless ran in like client_prethink(), won't really make an impact. You select your way of coding.

[seriousspot]

Originally Posted by Black Rose Of course it's a dumb comparison. I don't have any players on my server. The loops are basically the same. I used glb_MaxClients. get_players() also limits the loop to maxplayers. The difference being that the loop is running as a plugin or as a module. Obviously the module is faster. You didn't understand my usage of LOOPS. I ran the player loops 10 000 000 times. It's a 2 dimensional loop. I didn't search for 10 000 000 players. So 32*10 000 000 = 320 000 000 possible players to process. If you divide the 19 seconds by 10000000 to get the time of one run it would be .0019 milliseconds. That is of course with no players. In the end the difference, unless ran in like client_prethink(), won't really make an impact. You select your way of coding.

hmm interesting, would like to see real life comparision, there could be bots instead players