[RSTFS]

I accidentally posted this in the wrong section, and after 3 days it still hasn't been moved/deleted so I'm posting it again.
This code works, it just gives a glock to a player:

public void OnPluginStart(){
	RegConsoleCmd("sm_glock", GiveGlock);
}

public Action GiveGlock(int client, int args){
	if(IsPlayerAlive(client)){
		GivePlayerItem(client, "weapon_glock", 0);
	}
	return Plugin_Handled;
}

However, when I do anything related to removing weapons that the client already has, the command does not register. For example, this code does not work:

public void OnPluginStart(){
	RegConsoleCmd("sm_glock", GiveGlock);
}

public Action GiveGlock(int client, int args){
	if(IsPlayerAlive(client)){
		RemovePlayerItem(client, GetPlayerWeaponSlot(client, 0));         //This is the only line changed.
		GivePlayerItem(client, "weapon_glock", 0);
	}
	return Plugin_Handled;
}

0 warnings or errors during compilation. Same issue when I add anything about deleting the weapon edict.

[ddhoward]

The registration is working. Something else is happening. Check the Sourcemod error logs on the server.

[RSTFS]

Ah, trying to remove something from an already empty item slot breaks things, I should have caught that.

[ddhoward]

You should pass the entity returned by GetPlayerWeaponslot() through IsValidEntity() before you run it through RemovePlayerItem().

Something like this:

PHP Code:

if(IsPlayerAlive(client)){
        if(IsValidEntity(GetPlayerWeaponSlot(client, 0)) {
            RemovePlayerItem(client, GetPlayerWeaponSlot(client, 0));
        }
        GivePlayerItem(client, "weapon_glock", 0);
    } 


[asherkin]

Originally Posted by ddhoward You should pass the entity returned by GetPlayerWeaponslot() through IsValidEntity() before you run it through RemovePlayerItem(). Something like this: PHP Code: if(IsPlayerAlive(client)){         if(IsValidEntity(GetPlayerWeaponSlot(client, 0)) {             RemovePlayerItem(client, GetPlayerWeaponSlot(client, 0));         }         GivePlayerItem(client, "weapon_glock", 0);     }

No, just check for -1 being returned (as the doc says), if you get an ent index back it is going to be valid.