[shadow.hk]

Pointless plugin but oh well...

Instead of...

PHP Code:

new arg1[64]
new arg2[64]
new arg3[64]
new arg4[64]
new arg5[64]
new arg6[64]

read_arg(1, arg1, 63)
...
format(string,499,"[%s] used command %s %s %s %s %s %s %s",s_Time,pCommand,arg1,arg2,arg3,arg4,arg5,arg6) 


-->

PHP Code:

new arg[6][64]

read_arg(1, arg[0], 63)
read_arg(2, arg[1], 63)
...
format(string, 499, "[%s] used command %s %s %s %s %s %s %s", s_Time, pCommand, arg[0], arg[1], arg[2], arg[3], arg[4], arg[5]) 


Doesn't do anything for performance but frees up some code.

Instead of using...

PHP Code:

format() 


-->

PHP Code:

formatex() 


formatex() is faster than format().

PHP Code:

if( containi(pCommand, "amx_") != -1 && (  get_user_flags(id) && ACCESS ) ) 


-->

PHP Code:

if( containi(pCommand, "amx_") != -1 && ( get_user_flags(id) & ACCESS ) ) 


&& should be &.

You really need to clean up your code. Read up on this.

http://forums.alliedmods.net/showthread.php?t=85274

[Alucard^]

Similar than this: http://forums.alliedmods.net/showthread.php?p=66648

[pirvu]

1. I don't see why i should use a matrix instead of 6 vectors ..
It's not an optimization at all .. Nvm

2. I'll try your idea with formatex, thanks

3. & - is the "And" on bytes ...

As i sayd i am not a good amxx scripter so i don't know all funcitons ..

I saw in lots of plugins the code you're talking about but i never understood why . If you can explain that to me , i will be grateful ..

Whenever i need to code something i think first about the performance and after that about the code aspect ...

Usually when i work in C++ i have a function for each 20-30 lines of coding ..

So i work with lots of functions and the code is clean ..
But in Amxx i don't see why i should do that ..

Thanks for your opinion ;)

[grimvh2]

Originally Posted by shadow.hk && should be &.

[shadow.hk]

1. I don't see why i should use a matrix instead of 6 vectors .. It's not an optimization at all .. Nvm

I never said it did much of anything, it just frees up 5 lines in your code.

3. & - is the "And" on bytes ...

If you're saying that you did nothing wrong there, read it again.

PHP Code:

get_user_flags(id) && ACCESS 


should've been...

PHP Code:

get_user_flags(id) & ACCESS 


I saw in lots of plugins the code you're talking about but i never understood why . If you can explain that to me , i will be grateful ..

If that was for me, could you be a bit more specific. I'll gladly help where I can

[pirvu]

Originally Posted by shadow.hk If that was for me, could you be a bit more specific. I'll gladly help where I can

Yeah it was for you , and i was inviting you to explain to me why it should be & instead of && ...

After reading on wikipedia i found this :

In the C programming language family, the bitwise AND operator is "&" (ampersand). 
Again, this operator must not be confused with its Boolean "logical and" counterpart, 
which treats its operands as Boolean values, and is written "&&" (two ampersands).

which i already knew ..

My question for you is what does the function get_user_flags(id) return ?

[Styles]

Look for yourself on the funcwiki... I know that shit off the top of my head.. you should too..

[pirvu]

Originally Posted by styles Look for yourself on the funcwiki... I know that shit off the top of my head.. you should too..

Yeah but
1. i have a life
2. i'll better work on C++ to learn algorithms than cs functions ...

[DarkGod]

Originally Posted by pirvu 2. i'll better work on C++ to learn algorithms than cs functions ...

Then why are you even writing AMXX scripts?

[pirvu]

Originally Posted by DarkGod Then why are you even writing AMXX scripts?

Can't a man be bored ?

I had a cs server .. and i made some plugins for it ... :-? and i thought i'll better post this plugin , maybe someone will need it .. because it's very handy..

For example some1 comes to you and tells you yesterday admin BLABLA gave himself noclip ,etc ..

You just go in the folder of date , then on the adminname.log , and there you search the hour /etc ..

If you guys don't need it , it's not my problem .