[Chdata]

Oh yeah... I guess since many plugins also hook players when they connect, it seems like you can't "stack hooks".

In which case... perhaps stuff like OnTakeDamage can just be hooked for all clients during OnMapStart?

[psychonic]

Originally Posted by Chdata That's correct for a different reason. You don't need to unhook when a client disconnects from the server. I'm not sure exactly why though. It's either because you can't hook something twice (which I doubt, you probably actually can and have double repeating code), or because client entities don't actually get "killed" or "removed" - at least that's my theory as I don't know - that when someone connects his control is exerted on an existing player entity that's being unused. Or maybe SM does unhook clients on disconnect, who knows.

Originally Posted by Dr. Greg House I have seen many plugins hook stuff on player spawn. Now I'm wondering how long these hooks stay active. And if hooktype + entindex + callback-address is unique so that it wouldn't be hooked or called multiple times.

Originally Posted by Chdata Oh yeah... I guess since many plugins also hook players when they connect, it seems like you can't "stack hooks". In which case... perhaps stuff like OnTakeDamage can just be hooked for all clients during OnMapStart?

I'm not sure where the confusion is coming from. Hooks are automatically removed upon entity removal or client disconnect, and have been that way since long before SDKHooks was shipped with SM. Hooks are active until this point or until manually removed.

You can add multiple hooks of the same type to an entity, to different callbacks or to the same callback. There are no restrictions at all on that.

[Drixevel]

Originally Posted by psychonic I'm not sure where the confusion is coming from. Hooks are automatically removed upon entity removal or client disconnect, and have been that way since long before SDKHooks was shipped with SM. Hooks are active until this point or until manually removed. You can add multiple hooks of the same type to an entity, to different callbacks or to the same callback. There are no restrictions at all on that.

Might seem ignorant to ask this but what's the point of the unhook function if that's the case? Is it so you can create new hooks with the same entities?

[psychonic]

Originally Posted by r3dw3r3w0lf Might seem ignorant to ask this but what's the point of the unhook function if that's the case? Is it so you can create new hooks with the same entities?

It exists for the same reason that UnhookEvent, UnhookUserMessage, and UnhookConVarChange exist - to easily disable certain functionality when it is no longer needed. Granted, those would be things that normally unhook on plugin unload rather than entity destruction, but it's the same premise.

[Chdata]

Originally Posted by psychonic I'm not sure where the confusion is coming from. Hooks are automatically removed upon entity removal or client disconnect, and have been that way since long before SDKHooks was shipped with SM. Hooks are active until this point or until manually removed. You can add multiple hooks of the same type to an entity, to different callbacks or to the same callback. There are no restrictions at all on that.

It's because where the heck is there any documentation on this.

sdkhooks.inc isn't very descriptive, and the API doesn't say that

[psychonic]

Originally Posted by Chdata It's because where the heck is there any documentation on this. sdkhooks.inc isn't very descriptive, and the API doesn't say that

There is definitely room for improvement with the documentation.

Wiki contributions and pull requests for the includes are welcome.

[Mathias.]

Originally Posted by r3dw3r3w0lf Might seem ignorant to ask this but what's the point of the unhook function if that's the case? Is it so you can create new hooks with the same entities?

Just for an example if you have a cvar that enable and disable the plugin dynamically, you can had a cvar hook change and unhook your sdkhooks or hook depending on the toggle without having the plugin unload. In some cases you would just want to hook a player for a round or something.

[Chdata]

I'd probably contribute if I didn't feel like a noooooooooooooooooooooooob

I also still have no clue how KillTimer and CloseHandle are functionally different.

[Mathias.]

Originally Posted by Chdata I'd probably contribute if I didn't feel like a noooooooooooooooooooooooob I also still have no clue how KillTimer and CloseHandle are functionally different.

What do you mean? Your 2 OP with those mario world assembly modifications you are doing!

[psychonic]

Originally Posted by Chdata I also still have no clue how KillTimer and CloseHandle are functionally different.

There is no functional difference.