[Psyk0tik]

Oh yeah. I forgot to add a check to kill the timer on every round start before creating a new one.

Also, wouldn't the player need to be alive to get the health?

[eyal282]

Originally Posted by mug1wara He never told me to check if the client was valid :p

Translation: "He never told me the code must have no bugs and ERRORS".

[LenHard]

Originally Posted by Crasher_3637 Also, wouldn't the player need to be alive to get the health?

Indeed, updated.

[eyal282]

Originally Posted by LenHard You should always check no matter what's the reason, it's really a bad practice to not check. It'll prevent you from making that mistake in the future and also prevent errors to those whom you're helping. If I'm not wrong, that'd cause a timer to be set every round start causing duplicating timers. Add a integer of the round and stop the timer. PHP Code: int gI_Round; public void eEventRoundStart(Event hEvent, const char[] sEventName, bool bDontBroadcast) {     ++gI_Round;     CreateTimer(30.0, Timer_Heal, gI_Round, TIMER_FLAG_NO_MAPCHANGE|TIMER_REPEAT); } public Action Timer_Heal(Handle hTimer, any iRound) {     if (gI_Round == iRound)     {         for (int i = 1; i <= MaxClients; i++)              if (IsClientInGame(i) && IsPlayerAlive(i))                  SetEntityHealth(i, GetClientHealth(i) + 10);          return Plugin_Continue;     }     else return Plugin_Stop; }

Why not use my code to simply put finish the timer instantly? I assume just having the timer run takes some data and bandwith. Finishing the timer is probably the most efficient choice unless the timer is 0.1 seconds or something.

[LenHard]

Originally Posted by eyal282 Why not use my code to simply put finish the timer instantly? I assume just having the timer run takes some data and bandwith. Finishing the timer is probably the most efficient choice unless the timer is 0.1 seconds or something.

I'm not following what you're saying. Elaborate please.

[eyal282]

Originally Posted by LenHard I'm not following what you're saying. Elaborate please.

My code shuts the timer in the beginning of a new round. Your code keeps it running until it gets executed again. Meaning that my code shuts the timer up to 30 seconds earlier than you, which might be a better option for CPU.

[kratoss1812]

PHP Code:

public void OnPluginStart()
{
    HookEvent("player_spawn", OnSpawn);
}

public Action OnSpawn(Handle pEvent, const char[] pName, bool bDontBroadcast)
{
    int iClient = GetClientOfUserId(GetEventInt(pEvent, "userid"));
    
    CreateTimer(30.0, GiveHP, iClient, TIMER_REPEAT);
}

public Action GiveHP(Handle pTimer, any iClient)
{
    if(IsPlayerAlive(iClient))
    {
        int iHP = GetClientHealth(iClient);
        int iBonusHP = iHP + 10;
        SetEntityHealth(iClient, iBonusHP);
        PrintToChat(iClient, "You got 10 HP!") // debug
    }
} 


or you can just use

PHP Code:

public void OnClientPutInServer(int iClient)
{
    CreateTimer(30.0, GiveHP, iClient, TIMER_REPEAT);
} 


not tested, but should work

[micapat]

Maybe it's time to stop posting things that don't work.

[Neuro Toxin]

Originally Posted by kratoss1812 PHP Code: public void OnPluginStart() {     HookEvent("player_spawn", OnSpawn); } public Action OnSpawn(Handle pEvent, const char[] pName, bool bDontBroadcast) {     int iClient = GetClientOfUserId(GetEventInt(pEvent, "userid"));          CreateTimer(30.0, GiveHP, iClient, TIMER_REPEAT); } public Action GiveHP(Handle pTimer, any iClient) {     if(IsPlayerAlive(iClient))     {         int iHP = GetClientHealth(iClient);         int iBonusHP = iHP + 10;         SetEntityHealth(iClient, iBonusHP);         PrintToChat(iClient, "You got 10 HP!") // debug     } }  or you can just use PHP Code: public void OnClientPutInServer(int iClient) {     CreateTimer(30.0, GiveHP, iClient, TIMER_REPEAT); }  not tested, but should work

You dont send client indicies through timers. Especially 30 second timers. You send UserIds.

[eyal282]

Originally Posted by Neuro Toxin You dont send client indicies through timers. Especially 30 second timers. You send UserIds.

And ultimate especially repetitive timers.