Raised This Month: $12 Target: $400
 3% 

DHooks (Dynamic Hooks - Dev Preview)


Post New Thread Reply   
 
Thread Tools Display Modes
Alexmy
Senior Member
Join Date: Oct 2014
Location: Russian Federation
Old 06-06-2022 , 08:20   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #881

My ubuntu 20 vps server doesn't see the extension. What am I doing wrong, maybe I need to install some extension?
__________________
[/URL]
Alexmy is offline
Peace-Maker
SourceMod Plugin Approver
Join Date: Aug 2008
Location: Germany
Old 06-10-2022 , 07:43   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #882

SourceMod only loads an extension if it's used by a plugin by default. Do you have a plugin installed which uses dhooks?
__________________
Peace-Maker is offline
Alienmario
Senior Member
Join Date: Aug 2013
Old 01-14-2024 , 16:45   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #883

I believe the caching of parameters between pre and post hooks may have imposed a limit for few usecases.

Take for example the function CBaseEntity::AcceptInput(char const*, CBaseEntity*, CBaseEntity*, variant_t, int)
This function converts the value inside the variant_t union parameter to the correct type based on the entity's datadesc.
DHooks will always provide the value from the start of the hook, which will usually be a string, and not the converted type.

In case this "fix" is only applied on Windows, this would also cause inconsistencies between platforms.

Last edited by Alienmario; 01-14-2024 at 16:45.
Alienmario is offline
Peace-Maker
SourceMod Plugin Approver
Join Date: Aug 2008
Location: Germany
Old 02-15-2024 , 02:19   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #884

Ah, yes, we could add a flag to disable the caching of pre-hook parameters explicitly? It prevents more headache when it's on by default, but an opt-out sounds useful for union params like the variant_t you're describing. Would you mind creating an issue for this on github?
__________________
Peace-Maker is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 05:19.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode