[Solved] Timer Target Variable Problem

nhnkl159 · **Author**

Solved!

Do not blank your post; read rules; -RedSword

Hi ,

i have problem with the timers and target..

I Want It Like When Someone Write :

/test <target>

Its Create Timer And Do Server Command On The Target.

Example Code :

Code:

Timer :

CreateTimer(5.0, Test, _, TIMER_REPEAT);


Public :

public Action:Test(Handle:timer, any:target)
{
PrintToChatAll("%N Gives %N Test Command!" client, target);
ServerCommand("sm_test2 %N", target);

}

And The Server Log :

Code:

Target Not Found.

the target code i using :

Code:

char arg1[32], target;
GetCmdArg(1, arg1, sizeof(arg1));
target = FindTarget(client, arg1);

How Do I Send The Target Variable With The Timer ?

For Full Code Contact Me

Thx For Helpers

Icon315 · *Last edited by Icon315; 08-15-2015 at 04:47.*

Well since you are trying to send both the client and the target, you might try using a DataPacks.
https://wiki.alliedmods.net/Timers_(...ng)#Data_Packs

Here's an example:

Code:

public Action Test(int client, int args)
{
    char arg1[32], target;
    GetCmdArg(1, arg1, sizeof(arg1));
    target = FindTarget(client, arg1);
    if(IsClientInGame(target))
    {
        Handle data = CreateDataPack();
        WritePackCell(data, client);
        WritePackCell(data, target);
        CreateTimer(5.0, TestTimer, data, TIMER_REPEAT);
    }
}

public Action TestTimer(Handle timer, any:data)
{
    ResetPack(data);
    int client = ReadPackCell(data);
    int target = ReadPackCell(data);
    PrintToChatAll("%N Gives %N Test Command!", client, target);
    ServerCommand("sm_test2 #%d", GetClientUserId(target));
}

nhnkl159 · 08-13-2015 , 02:08 Re: Timer Target Variable Problem

Quote:

Originally Posted by Icon315

Well since you are trying to send both the client and the target, you might try using a DataPacks.
https://wiki.alliedmods.net/Timers_(...ng)#Data_Packs

Here's an example:

Code:

public Action Test(int client, int args)
{
    char arg1[32], target;
    GetCmdArg(1, arg1, sizeof(arg1));
    target = FindTarget(client, arg1);
    if(IsClientInGame(target))
    {
        Handle data = CreateDataPack();
        WritePackCell(data, client);
        WritePackCell(data, target);
        CreateTimer(5.0, TestTimer, data, TIMER_REPEAT);
    }
}

public Action TestTimer(Handle timer, any:data)
{
    ResetPack(data);
    int client = ReadPackCell(data);
    int target = ReadPackCell(data);
    PrintToChatAll("%N Gives %N Test Command!", client, target);
    ServerCommand("sm_test2 %N", target);
}

Thx For Your Reply !

nhnkl159 · *Last edited by nhnkl159; 08-13-2015 at 03:56.*

Solved !

RedSword · *Last edited by RedSword; 08-13-2015 at 04:25.*

Re-added your question to the first post, as per the forum rules you should not blank your post. This is intended to help people in the future to find possibly similar problems.

Red

nhnkl159 · 08-13-2015 , 04:29 Re: [Solved] Timer Target Variable Problem

Quote:

Originally Posted by RedSword

Re-added your question to the first post, as per the forum rules you should not blank your post. This is intended to help people in the future to find possibly similar problems.

Red

OK thanks you

WildCard65 · 08-13-2015 , 10:03 Re: [Solved] Timer Target Variable Problem

I should also say, NEVER PASS A CLIENT NAME TO ServerCommand NATIVE, it's just begging to be exploited.

ThatOneGuy · *Last edited by ThatOneGuy; 08-14-2015 at 18:05.*

Quote:

Originally Posted by WildCard65

I should also say, NEVER PASS A CLIENT NAME TO ServerCommand NATIVE, it's just begging to be exploited.

^This. Use user IDs instead. e.g.

PHP Code:


			
new iUserID = GetClientUserId(client);
ServerCommand("sm_slay #%i", iUserID);

To explain what kind of exploits wildcard is referring to, imagine the name "haha;quit".

The server command becomes: sm_test2 haha;quit

Now your server is shut down. GG.

nhnkl159 · *Last edited by nhnkl159; 08-15-2015 at 02:19.*

Quote:

Originally Posted by ThatOneGuy

^This. Use user IDs instead. e.g.

PHP Code:


			
new iUserID = GetClientUserId(client);
ServerCommand("sm_slay #%i", iUserID);

To explain what kind of exploits wildcard is referring to, imagine the name "haha;quit".

The server command becomes: sm_test2 haha;quit

Now your server is shut down. GG.

So to remove the exploit i need to use like :

Servercommand("sm_test2 #%N", target);

And its remove the exploit?

ddhoward · 08-15-2015 , 04:01 Re: [Solved] Timer Target Variable Problem

i, not N, and userID, not target