[Brad]

Originally Posted by Brad Edit your initial post and make sure the bulk of it is in the normal font and format. You must post in a manner consistent with the norm here.

Do this, please. I don't look the part, but I am a moderator and plugin approver.

[TeddyDesTodes]

Fixed Post(hopefully)
Fixed plugin and added some more features

[BOYSplayCS]

That is a perfect balance that you used, good job fixing it. Use that format from now on.

[joaquimandrade]

Hello.

I like to review code so i leave you some tips:

Don't do

PHP Code:

register_forward(FM_Think,"fm_ghost_think",0)
register_forward(FM_PlayerPostThink,"fm_plr_prethink",0) 


in plugin_init.

Use instead two counters. One for players recording other for ghosts. Then, inside start_replay (if the ghost is created sucessfully) check the ghost counter. If its 0, call the register_forward(FM_Think.... If its value is bigger don't do nothing. Increment it. In fm_ghost_think after doing

PHP Code:

fm_remove_entity(g_GhostWeapon[owner]);
fm_remove_entity(g_Ghost[owner]); 


decrement it. If its value is 0 do unregister_forward.

The same for plr_prethink. I think you get the point.

I also recommend you to use the same approach to

PHP Code:

set_task(1.0,"hud",_,_,_,"b",0) 


Other tip, less useful but good for code reading:

When dealing with coordinates use a enum like:

PHP Code:

enum COORDINATES
{
    X,
    Y,
    Z
} 


Why?

Because its more easier to read:

PHP Code:

fwrite(g_FileHandler[id],_:origin[X],BLOCK_INT)
fwrite(g_FileHandler[id],_:origin[Y],BLOCK_INT)
fwrite(g_FileHandler[id],_:origin[Z],BLOCK_INT) 


than

PHP Code:

fwrite(g_FileHandler[id],_:origin[0],BLOCK_INT)
fwrite(g_FileHandler[id],_:origin[1],BLOCK_INT)
fwrite(g_FileHandler[id],_:origin[2],BLOCK_INT) 


Other thing. Check if you need to remove ghosts on disconnect.

Other thing.

Use a function to compare vectors like:

PHP Code:

equal_vectors(vector1[COORDINATES],vector2[COORDINATES])
{
    for (new COORDINATES:i=X;i<COORDINATES;i++)
        if(vector1[i] != vector2[i])
            return false;
    
    return true;
} 


Then you can change this:

PHP Code:

if((g_LastAngle[id][0] == angles[0] && g_LastAngle[id][1] == angles[1] && g_LastAngle[id][2] == angles[2] ) && (g_LastOrigin[id][0] == origin[0] && g_LastOrigin[id][1] == origin[1] && g_LastOrigin[id][2] == origin[2] ) && (g_LastVelocity[id][0] == veloc[0] &&    g_LastVelocity[id][1] == veloc[1] && g_LastVelocity[id][2] == veloc[2])) return FMRES_IGNORED 


to

PHP Code:

if(equal_vectors(g_LastAngle[id],angles) && equal_vectors(g_LastOrigin[id],origin) && equal_vectors(g_LastVelocity[id],veloc))
            return FMRES_IGNORED 


Other thing. Use enums to make groups of data when needed. Example:

PHP Code:

enum COORDINATES
{
    X,
    Y,
    Z
}  

enum POSITION_DATA
{
    ANGLES,
    ORIGIN,
    VELOCITY
}

new Float:positionData[POSITION_DATA][COORDINATES] 


With that you could then change:

PHP Code:

fwrite(g_FileHandler[id],_:angles[0],BLOCK_INT)
fwrite(g_FileHandler[id],_:angles[1],BLOCK_INT)
fwrite(g_FileHandler[id],_:angles[2],BLOCK_INT)
fwrite(g_FileHandler[id],_:origin[0],BLOCK_INT)
fwrite(g_FileHandler[id],_:origin[1],BLOCK_INT)
fwrite(g_FileHandler[id],_:origin[2],BLOCK_INT)
fwrite(g_FileHandler[id],_:veloc[0],BLOCK_INT)
fwrite(g_FileHandler[id],_:veloc[1],BLOCK_INT)
fwrite(g_FileHandler[id],_:veloc[2],BLOCK_INT) 


to

PHP Code:

for(new POSITION_DATA:i=ANGLES;i<POSITION_DATA;i++)
    for(new COORDINATES:j=X;j<COORDINATES;j++)
        fwrite(g_FileHandler[id],_:positionData[i][j] ,BLOCK_INT) 


and

PHP Code:

        g_LastAngle[id][0] = angles[0]
        g_LastAngle[id][1] = angles[1]
        g_LastAngle[id][2] = angles[2]
        g_LastOrigin[id][0] = origin[0]
        g_LastOrigin[id][1] = origin[1]
        g_LastOrigin[id][2] = origin[2]
        g_LastVelocity[id][0] = veloc[0]
        g_LastVelocity[id][1] = veloc[1]
        g_LastVelocity[id][2] = veloc[2] 


to

PHP Code:

for(new POSITION_DATA:i=ANGLES;i<POSITION_DATA;i++)
    for(new COORDINATES:j=X;j<COORDINATES;j++)
        g_LastPositionData[id][i][j] = positionData[i][j] 


Another thing.

Use the bool tag.

Then change

PHP Code:

g_isRecording[id] == 0 


to

PHP Code:

!g_isRecording[id] 


and

PHP Code:

g_isRecording[id] = 1 


to

PHP Code:

g_isRecording[id] = true 


[BOYSplayCS]

When using coordinates with Origin always use x, y and z - not 0, 1 and 2.

[xPaw]

PHP Code:

enum COORDINATES
{
    X,
    Y,
    Z
} 


its total useless...

[TeddyDesTodes]

ok i will commit some changes later today
but i dont need this:

Originally Posted by joaquimandrade Other thing. Check if you need to remove ghosts on disconnect.

because if i close the file via fclose ghost cant read data anymore and kills itself checked that

[joaquimandrade]

Originally Posted by xPaw PHP Code: enum COORDINATES {     X,     Y,     Z }  its total useless...

Yes. Making the code more readable totally sucks.

Originally Posted by TeddyDesTodes ok i will commit some changes later today but i dont need this: because if i close the file via fclose ghost cant read data anymore and kills itself checked that

You have

PHP Code:

if(!is_user_connected(owner)) return FMRES_IGNORED; 


in fm_ghost_think so double check if the ghost entity is really removed on client_disconnect. You need to have it removed so that the first part of what i've said to you works like it have to.

[YamiKaitou]

Originally Posted by joaquimandrade Yes. Making the code more readable totally sucks.

IMO, I find it easier to read the numbers than the letters in this case, but it depends on your coding style. Using the enum is not required and will not have any effect on approval status (just mentioning this in case others believe otherwise)

[TeddyDesTodes]

Originally Posted by joaquimandrade You have PHP Code: if(!is_user_connected(owner)) return FMRES_IGNORED; in fm_ghost_think so double check if the ghost entity is really removed on client_disconnect. You need to have it removed so that the first part of what i've said to you works like it have to.

haha stupid me i think im goin to remove this check since it destroys itself if there is no owner