[belgvr]

It still works great in 2021 on my HL2DM server, BUT... it plays the kill sound when the player suicide, is there any option to filter this?

[Ejziponken]

Can someone add a menu for clients?

[Ejziponken]

L 09/04/2021 - 00:47:28: [SM] MEMORY LEAK DETECTED IN PLUGIN (file "hitkillsounds.smx")
L 09/04/2021 - 00:47:28: [SM] Unloading plugin to free 30995 handles.
L 09/04/2021 - 00:47:28: [SM] Contact the author(s) of this plugin to correct this error.
L 09/04/2021 - 00:47:28: --------------------------------------------------------------------------
L 09/04/2021 - 00:47:28: Type Cookie | Count 30995
L 09/04/2021 - 00:47:28: -- Approximately 0 bytes of memory are in use by (30995) Handles.

[evans]

good job but...

L 11/24/2022 - 15:54:10: [SM] Exception reported: Client index 0 is invalid
L 11/24/2022 - 15:54:10: [SM] Blaming: hitkillsounds.smx
L 11/24/2022 - 15:54:10: [SM] Call stack trace:
L 11/24/2022 - 15:54:10: [SM] [0] GetClientCookie
L 11/24/2022 - 15:54:10: [SM] [1] Line 97, hitkillsounds.sp:layerHurt
L 11/24/2022 - 15:54:10: [SM] Exception reported: Client index 0 is invalid
L 11/24/2022 - 15:54:10: [SM] Blaming: hitkillsounds.smx
L 11/24/2022 - 15:54:10: [SM] Call stack trace:
L 11/24/2022 - 15:54:10: [SM] [0] GetClientCookie
L 11/24/2022 - 15:54:10: [SM] [1] Line 97, hitkillsounds.sp:layerHurt
L 11/24/2022 - 15:58:44: [SM] Exception reported: Client index 0 is invalid
L 11/24/2022 - 15:58:44: [SM] Blaming: hitkillsounds.smx
L 11/24/2022 - 15:58:44: [SM] Call stack trace:
L 11/24/2022 - 15:58:44: [SM] [0] GetClientCookie
L 11/24/2022 - 15:58:44: [SM] [1] Line 97, hitkillsounds.sp:layerHurt
L 11/24/2022 - 15:59:00: [SM] MEMORY LEAK DETECTED IN PLUGIN (file "hitkillsounds.smx")
L 11/24/2022 - 15:59:00: [SM] Unloading plugin to free 31470 handles.
L 11/24/2022 - 15:59:00: [SM] Contact the author(s) of this plugin to correct this error.
L 11/24/2022 - 15:59:00: --------------------------------------------------------------------------
L 11/24/2022 - 15:59:00: Type Cookie | Count 31470
L 11/24/2022 - 15:59:00: -- Approximately 0 bytes of memory are in use by (31470) Handles.

[Grey83]

Originally Posted by evans [SM] Exception reported: Client index 0 is invalid

[evans]

I still love youuuuu Grey ahahahah, awesome, thank you so much!!!!! I did not expect so quick help. Good fix! Works perfect, no errors.
Btw....I was for 99% sure it's causing bots (fakeclient). I see you are pro coder, thanks again. In the future i will consider to ask you for some paid jobs, if you would agree...

If i may add something.....this also makes me trouble with non existent folder so i allowed myself little change to this
AutoExecConfig(true, "hitkillsounds", "hitkillsounds");
(sourcemod folder removed)

[Grey83]

evans, if modify AutoExecConfig(true, "hitkillsounds", "hitkillsounds"); to AutoExecConfig(true, "hitkillsounds"); then will removed unnecessary folder "hitkillsounds" (cfg/sourcemod/hitkillsounds/hitkillsounds.cfg).

I quickly fixed what I had time for before I had to leave for work in the morning. There is still something to fix in the plugin code.
For example, unused user settings (more precisely, players cannot change them, although they are present in the code for some reason).

[evans]

Hmmm, ok understand. That extra folder is not such pain in my ass, important is it works. Regarding the unused user settings, the author probably left all the counter strike by the time, hard to say...

[Grey83]

Changes v1.3.0 [2022/11/25]:

• Completely redesigned plugin code
• Changed convar names (and value type for volume) and one new convar added.
• Changed path to config.
• If the wrong file type is specified as the path to the sound or this path is too short, the default values ​​will be used.
• Added client settings (the menu is called from the menu "!settings" or by using console command "sm_hks" or chat command "!hks").
  The player can turn sounds on or off and adjust their volume (in 5-unit increments). If the player did not change the settings, then the server settings will be used.
• Observers can also hear these sounds (depending on their settings).
• The sound plugin settings are used as the default settings for players who have not changed their settings (only disabling the plugin completely disables all plugin sounds).

ConVars:

• sm_hks_version - plugin version
• sm_hks_enabled - Enable/Disable plugin
• sm_hks_hit - Toggle hit sound
• sm_hks_hit_path - Hit sound file (not valid or empty = default sound)
• sm_hks_hit_volume - Hit sound volume (1 - 100)
• sm_hks_kill - Toggle kill sound
• sm_hks_kill_path - Kill sound file (not valid or empty = default sound)
• sm_hks_kill_volume - Kill sound volume (1 - 100)
• sm_hks_observe - Can the player hear the sounds of the player they are spectating

[evans]

Very nice job! It's very good that someone is still interresting in this game, even in 2022. I think i can say thank you for all. For me personally you most helped me with this isfakeclient(); function, because after that i have been able to fix myself other 3 plugins which had the similar problem.

Best regards