[pride95]

You should check just

PHP Code:

DBResultSet results 


PHP Code:

if(results != null) {} 


[brunoronning]

Originally Posted by asherkin You now have a very obvious leak on any query failure.

Sorry:

Spoiler

PHP Code:

void SomeFunction() 
{ 
    DataPack pack = new DataPack();
    pack.WriteCell(32);
    pack.WriteCell(52);
    pack.Reset();

    char szQuery[128]; 
    Format(szQuery, sizeof(szQuery), "SELECT * FROM test"); 
    g_dbTest.Query(SQLCallback_Test, szQuery, pack); 
} 

public void SQLCallback_Test(Database db, DBResultSet results, const char[] sError, any data) 
{ 
    if (db == null || strlen(sError) > 0) 
    {
        LogError("(SQLCallback_Test) Fail at Query: %s", sError); 
    }
    else
    {
        int iValue1 = ReadPackCell(data); 
        int iValue2 = ReadPackCell(data); 

        // Your Code.
    }
    delete view_as<DataPack>(data); 
} 


[sdz]

Originally Posted by brunoronning Try this method: It is not elegant, but it works.

PHP Code:

public void SomeFunction()
{
    DataPack pack = new DataPack();
    pack.WriteCell(69);
    pack.WriteCell(420);

    char szQuery[32];
    Format(szQuery, sizeof(szQuery), "SELECT * FROM test");
    g_dbTest.Query(SQLCallback_Test, szQuery, pack);
}

public void SQLCallback_Test(Database db, DBResultSet results, const char[] sError, DataPack data)
{   
    //db not connected or something went wrong with connection:
    if (db == null)
    {
        LogError("(SQLCallback_Test) Database not connected or failed to connect, aboring query...");
        return;
    }
    //query fucked up:
    else if(results == null)
    {
        LogError("(SQLCallback_Test) Fail at Query: %s", sError);
    }

    int iValue1;
    int iValue2;

    data.Reset();
    iValue1 = data.ReadCell();
    iValue2 = data.ReadCell();
    delete data;

    // Your Code.
} 


[xm3kilo]

Thanks for all the help guys I'll try the above method

[headline]

Originally Posted by EasSidezz -snip-

Originally Posted by asherkin You now have a very obvious leak on any query failure.

[OSWO]

I don't think it's helpful quoting someones previous statement, and rather showing the actual problem.

When it fails you return; without disposing the DataPack handle.

[headline]

Originally Posted by OSWO I don't think it's helpful quoting someones previous statement, and rather showing the actual problem.

Thankfully, it was the same problem that asherkin pointed out, so I didn't need to. I don't know how it could be any more clear.

Originally Posted by asherkin on any query failure

[OSWO]

Still on that high horse I see

[WildCard65]

Originally Posted by OSWO Still on that high horse I see

It's understandable why Headline did it, an issue with leaking DataPack handles was never addressed even though it was obvious AND pointed out, so it's understandable that Headline would be angry at the disregard (I would too)