[Longtree]

That fixed it.. thanks again for help. I downloaded and installed latest version of sourcemod.

Thanks again for your help.. you guys are great

Best regards,
Longtree

[disawar1]

hi Machine, my plugin supported u Super Tanks, topic is here http://forums.alliedmods.net/showthread.php?p=1610278 Did you think about the support of all gamemods?

[Machine]

Yes, I saw that. Good job. I haven't thought about adding support for other gamemodes. Maybe some day.

[hg0827]

can add some cvars to control tank's health for default tank and every wave in fenale,thx
add cvar to set every tank's speed @.@

[RavenDan29]

Please add a cvar for gamemodes

on Expert tanks are reading as 4000 not 8000hp why?

@wolfgang the .cfg file version would have been useful but your .smx and .sp files ae not compileing

think it best to delete this plugin till its finished

[DarkSynergy]

I'm getting this error message repeatedly:

L 03/16/2012 - 14:19:20: [SM] Native "IsClientInGame" reported: Client index 30 is invalid
L 03/16/2012 - 14:19:20: [SM] Displaying call stack trace for plugin "SuperTanks.smx":
L 03/16/2012 - 14:19:20: [SM]   [0]  Line 1160, C:\Program Files\Steam\steamapps\common\left 4 dead 2\left4dead2\addons\sourcemod\scripting\SuperTanks.sp::IsTank()
L 03/16/2012 - 14:19:20: [SM]   [1]  Line 2899, C:\Program Files\Steam\steamapps\common\left 4 dead 2\left4dead2\addons\sourcemod\scripting\SuperTanks.sp::OnSurvivorTakeDamage()

I took a look at your code, and it looks like you assumed max clients to be 32 (checking attacker < 33). This is probably why a client index of 30 (which here is invalid) is getting through.

EDIT: Also, you use z_tank_health to determine the tank's hp, which is only correct on normal difficulty. On any other difficulty, a multiplier is applied to the tank's hp to get the true value.

[Machine]

Originally Posted by DarkSynergy I took a look at your code, and it looks like you assumed max clients to be 32 (checking attacker < 33). This is probably why a client index of 30 (which here is invalid) is getting through. EDIT: Also, you use z_tank_health to determine the tank's hp, which is only correct on normal difficulty. On any other difficulty, a multiplier is applied to the tank's hp to get the true value.

Maximum clients for L4D2 is 32. I am unsure why its giving an error about client index 30 not being valid.
You have to remember, fakeclients such as bots, survivors or infected, use those client indexes aswell.
I will take a look at it tonight, maybe I need to add more checks.

I was aware of the health multiplier, but I was lazy and didn't account for it.
I will update this plugin tonight with it and add additional cvars as posters above suggested and change the way the sdkcalls are handled too. It should reduce the server load when they are called.

[DarkSynergy]

Originally Posted by Machine Maximum clients for L4D2 is 32. I am unsure why its giving an error about client index 30 not being valid. You have to remember, fakeclients such as bots, survivors or infected, use those client indexes aswell. I will take a look at it tonight, maybe I need to add more checks. I was aware of the health multiplier, but I was lazy and didn't account for it. I will update this plugin tonight with it and add additional cvars as posters above suggested and change the way the sdkcalls are handled too. It should reduce the server load when they are called.

I just went ahead and changed all of the "< 33" checks to "<= MaxClients" and it seemed to take care of the problem for me. Based on what I read online "MaxClients" is determined dynamically. I'm not sure why the event would be called with an invalid client index though.

As for the health, yeah it's just an issue of detecting the difficulty cvar and applying the correct multiplier to z_tank_health. Also, although the method you used right now works, you probably could completely replace things like player_hurt and SDKCallWeaponDrop with SDKHooks functions (SDKHook_OnTakeDamage, SDKHooks_DropWeapon). If time permits, of course.

I tried it out online and it makes the finales a lot more interesting (and difficult ). Keep up the good work!

[Machine]

Originally Posted by DarkSynergy I just went ahead and changed all of the "< 33" checks to "<= MaxClients" and it seemed to take care of the problem for me. Based on what I read online "MaxClients" is determined dynamically. I'm not sure why the event would be called with an invalid client index though. As for the health, yeah it's just an issue of detecting the difficulty cvar and applying the correct multiplier to z_tank_health. Also, although the method you used right now works, you probably could completely replace things like player_hurt and SDKCallWeaponDrop with SDKHooks functions (SDKHook_OnTakeDamage, SDKHooks_DropWeapon). If time permits, of course. I tried it out online and it makes the finales a lot more interesting (and difficult ). Keep up the good work!

Yes it was sloppy on my part to use "< 33" in the first place. I usually use "<=MaxClients". I must have had a brain fart. Btw, it is possible for the SDKHook_OnTakeDamage to return no attacker indexes. Such as world damage and infected entities. But seeing as that error returned an index of 30, it should have been valid. Very strange..

Yeah I will replace those in time. When I first worked on this tank plugin, I didn't use SDKHooks, so most functions were called from the player_hurt event. I can replace that event eventually.

[DarkSynergy]

Originally Posted by Machine Yes it was sloppy on my part to use "< 33" in the first place. I usually use "<=MaxClients". I must have had a brain fart. Btw, it is possible for the SDKHook_OnTakeDamage to return no attacker indexes. Such as world damage and infected entities. But seeing as that error returned an index of 30, it should have been valid. Very strange.. Yeah I will replace those in time. When I first worked on this tank plugin, I didn't use SDKHooks, so most functions were called from the player_hurt event. I can replace that event eventually.

I've had that same error spammed in my log on multiple runs, and the invalid client index reported is always 30. There definitely werent 30 clients on the server (including survivor/infected bots) when it happened though.

Also, you might be able to simplify weapon dropping to:

stock ForceWeaponDrop(client)
{
    if (client == 0 || GetClientTeam(client) != 2 || !IsPlayerAlive(client))
        return;

    new weapon = GetEntPropEnt(client, Prop_Send, "m_hActiveWeapon");
    if (weapon > 0)
        SDKHooks_DropWeapon(client, weapon, NULL_VECTOR, NULL_VECTOR);
}

Im just not sure if this would cause a player to drop their single pistol if thats all they have (havent tested it). But yeah, that would get rid of an SDKCall entirely.