[WildCard65]

Originally Posted by asherkin Theoretically you could just always pass 0 as the function id to add whatever the plugin's first public is, avoiding the need to recompile plugins - the forward will never be called anyway.

what about warning 237?

[Neuro Toxin]

I don't mind a warning if it resolves plugins having to be recompiled.

I've got some spare time so I'm actually test this atm...

[Neuro Toxin]

Originally Posted by asherkin Theoretically you could just always pass 0 as the function id to add whatever the plugin's first public is, avoiding the need to recompile plugins - the forward will never be called anyway.

It works. Function id 0 is invalid so I used function id 1.

Edit:

Everything is tested and working:

] sm_rcon sm plugins load dynamic
[SM] Loaded plugin dynamic.smx successfully.

] sm_dynamic_handles 
Dynamic is running a HandleUsage report...
-> Total Handles: 0 (0 persistant handles)

] sm_rcon sm plugins load dynamic-gc-test
[SM] Loaded plugin dynamic-gc-test.smx successfully.

] sm_dynamic_handles 
Dynamic is running a HandleUsage report...
-> Total Handles: 1 (0 persistant handles)
--> ``: 1 Handles (0 persistant handles)

] sm_rcon sm plugins unload dynamic-gc-test
[SM] Plugin dynamic-gc-test.smx will be unloaded on the next frame.

] sm_dynamic_handles 
Dynamic is running a HandleUsage report...
-> Total Handles: 1 (0 persistant handles)

] sm_dynamic_collectgarbage 
Dynamic is starting it's garbage collector...

] sm_dynamic_handles 
Dynamic is running a HandleUsage report...
-> Total Handles: 0 (0 persistant handles)

Before merging anything into the main branch I really want to exhaust not adding a public forward OnPluginUnloaded(Handle plugin) as it would a much cleaner fix.

Final changes for merge

[jdlovins]

I just stumbled upon this and am curious about something that I dont quite understand. Using the class generator it generated a Get() method like

public get()
		{
			static DynamicOffset offset = INVALID_DYNAMIC_OFFSET;
			if (offset == INVALID_DYNAMIC_OFFSET)
			{
				offset = this.GetMemberOffset("Replay");
				if (offset == INVALID_DYNAMIC_OFFSET)
					SetFailState("A serious error occured in Dynamic!");
			}
			return this.GetHandleByOffset(offset);
		}

Isnt this redundant?

static DynamicOffset offset = INVALID_DYNAMIC_OFFSET;
if (offset == INVALID_DYNAMIC_OFFSET)

This makes more sense to me

static DynamicOffset offset = this.GetMemberOffset("Replay");
if (offset == INVALID_DYNAMIC_OFFSET)
	SetFailState("A serious error occured in Dynamic!");
return this.GetHandleByOffset(offset);

I'm sure theres a reason for the first if statement but I'm just curious why, thanks!

[psychonic]

Originally Posted by jdlovins Isnt this redundant? static DynamicOffset offset = INVALID_DYNAMIC_OFFSET; if (offset == INVALID_DYNAMIC_OFFSET) This makes more sense to me static DynamicOffset offset = this.GetMemberOffset("Replay"); if (offset == INVALID_DYNAMIC_OFFSET) SetFailState("A serious error occured in Dynamic!"); return this.GetHandleByOffset(offset); I'm sure theres a reason for the first if statement but I'm just curious why, thanks!

You can't initialize static vars in Sourcepawn with non-constants.

[jdlovins]

Originally Posted by psychonic You can't initialize static vars in Sourcepawn with non-constants.

Ah that would do it. Thanks.

[Neuro Toxin]

You only want .GetMemberOffset to be called once and cached for the properties getter.

[Neuro Toxin]

Dynamic v0.0.24 has been released

- SetStringByOffset fix

[SM9]

Hey,

With the dynamic dump handles command, would it be possible for you to make it dump the info to file as well? I got a slow memory leak and being able to see exactly what the handles are would be very useful.

Also, how do I check if a Dynamic collection is valid? There is not a method for it so I am curious.

Lastly, does the method .WriteKeyValues work on collections or is it only for objects?

Thanks for your time, I am enjoying using Dynamic!

[Neuro Toxin]

Originally Posted by xCoderx With the dynamic dump handles command, would it be possible for you to make it dump the info to file as well? I got a slow memory leak and being able to see exactly what the handles are would be very useful.

Do you require further details to be included or just a simple "filename" param?

Originally Posted by xCoderx Also, how do I check if a Dynamic collection is valid? There is not a method for it so I am curious.

A Collection inherits an ArrayList. This means you're expected to manage the pointer like any other standard sourcepawn handle.

Eg. delete / == null

Originally Posted by xCoderx Lastly, does the method .WriteKeyValues work on collections or is it only for objects?!

KeyValues operations are currently only supported on real Dynamic objects.