[Wliu]

So I recently submitted a pull request to try to get a new native added.

I was initially going to call it TF2_SetClientTeam (which wraps around ChangeClientTeam and provides symmetry for TF2_GetClientTeam) but psychonic has suggested that it might be better named as TF2_ChangeClientTeam.

So basically I just want to see what everyone else thinks about the naming.

[Chdata]

I dunno, seems pretty pointless to me as all it is is a function to throw that ugly enum tag on it.

[Wliu]

Originally Posted by Chdata I dunno, seems pretty pointless to me as all it is is a function to throw that ugly enum tag on it.

I'd enjoy not having to coerce stuff from TFTeam to ints and back to TFTeam again repeatedly just because of ChangeClientTeam ;P.

[Powerlord]

If you're creating a TF2-specific change team, why wouldn't you just call the newer ChangeTeam that SM doesn't implement?

That is, TF2's CTFPlayer::ChangeTeam( int iTeamNum, bool bAutoTeam, bool bSilent );, which is in CTFPlayer's vtable (420 on Linux).

[Wliu]

Originally Posted by Powerlord If you're creating a TF2-specific change team, why wouldn't you just call the newer ChangeTeam that SM doesn't implement? That is, TF2's CTFPlayer::ChangeTeam( int iTeamNum, bool bAutoTeam, bool bSilent );, which is in CTFPlayer's vtable (420 on Linux).

That bSilent looks *really* appealing right now ;P. Perhaps someone could implement that?

[Michalplyoutube]

Setting team is more like dynamic thing Like for mannhattan anti crash.

Changing team sounds like the normal changeteam.

[psychonic]

Originally Posted by Powerlord If you're creating a TF2-specific change team, why wouldn't you just call the newer ChangeTeam that SM doesn't implement? That is, TF2's CTFPlayer::ChangeTeam( int iTeamNum, bool bAutoTeam, bool bSilent );, which is in CTFPlayer's vtable (420 on Linux).

I addressed this in a comment on Wliu's PR before seeing the source here.

Originally Posted by psychonic Originally Posted by Wliu In addition, Powerlord pointed out that there's a new CTFPlayer::ChangeTeam( int iTeamNum, bool bAutoTeam, bool bSilent ); If by new, you mean eight years old ;). It's existed since the Orangebox engine debuted. The beauty of the one we're using now is that it is on a fairly stable interface. The other one would require gamedata as it would occasionally break. Additionally, automatically selecting a team and blocking the player_team event can be done manually without much hassle.

[Powerlord]

My mistake, I was thinking of CTFPlayer::ForceChangeTeam(int, bool) which is the one called by CTFGameRules when it swaps players for autobalancing and team switches between rounds.

As I recall, there was a conversation before about what the bool was and it controls whether dominations are cleared.

However, that's still going to have gamedata issues as it would require a signature.

This particular function has all sorts of extra logic for things like duel minigames, dropping flags, etc... that aren't necessarily covered by the normal ChangeTeam.

[Mathias.]

I would vote for TF2_SwitchTeam(int client, int team) since cstrike CS_SwitchTeam(int client, int team) just to keep a standard for the API (is that even something that might go official?)

[Wliu]

It was merged in as TF2_ChangeClientTeam to a) provide consistency for the underlying command and b) better represent what it's actually doing.