[paulo_crash]

Originally Posted by nosoop From the previous page.

So I could disable this extension, or even need it?

[Spirit_12]

Originally Posted by paulo_crash So I could disable this extension, or even need it?

How would we know, if you need an extension or not? Remove it and see if a plugin is asking for it.

[Ryan.]

I've started experiencing a crash since upgrading from Sourcemod 1.9 to the latest dev build, 1.10 (6354). The crash happens on Windows when overriding a DHook'ed function's parameters (i.e. returning MRES_ChangedHandled). Linux works fine.

I don't know whether Sourcemod or DHooks is the issue. I narrowed down the last working version of Sourcemod to be build 6225. It works and crashes just the same whether its DHooks with detours or not.

When I peeked into the dump file it pointed me to one of the Callback functions in DHook's vhook.cpp. I'd guess the 'void Callback' since my hooked function is using ReturnType_Void. Possibly the HandleSecurity line?

I've attached a minimal example plugin to demonstrate the crash. It's for the game No More Room in Hell and will crash whenever the player performs a shove (assuming a Windows host running a Sourcemod build > 6225).

[asherkin]

Build 6225 on which branch? Do you have any Accelerator crash reports?

[Ryan.]

Build 6225 on branch 1.10. I was trying them out from here: https://www.sourcemod.net/downloads....h=master&all=1

Build 6225 works but the next prebuilt binary (build 6228 ) has the crash.

Crash report: https://crash.limetech.org/5ye2ihr7ki24

[asherkin]

Originally Posted by Ryan. Build 6225 on branch 1.10. I was trying them out from here: https://www.sourcemod.net/downloads....h=master&all=1 Build 6225 works but the next prebuilt binary (build 6228 ) has the crash. Crash report: https://crash.limetech.org/5ye2ihr7ki24

That crash report doesn't look related.

There are a few significant changes between 1.10+6225 and 1.10+6228 that could cause issues with DHooks, but the one that stands out the most is the new IBinTools interface version - so the first thing that needs trying is to re-build DHooks against the latest 1.10 SourceMod SDK and see if that fixes the problem. DHooks doesn't currently check the return of SM_GET_LATE_IFACE, so it is probably just failing to get the interface in newer SM builds.

[Ryan.]

I'm not sure why the callstack is so different on that crash. Here is the original one: https://crash.limetech.org/wrihcfj3phod

Edit: I tested some more until Accelerator warned about rate limit. I logged a few crashes anonymously after forgetting to set my steamid between installing different Sourcemod versions. There were 2 hangs that I had to kill manually that didn't generate a crash report.

The anonymous reports:

• WG33-U5T4-3BNH
• U3QK-ATNM-NXGB
• 2DAJ-27K2-IQ4U
• KG52-UIHI-AOOE (Not from DHooks.dll)
• 7WA2-GBYM-PMVP
• 642U-3XWQ-AEPT

Of the 28 crash reports, 75% are from DHooks.dll + 0x804D. The other 25% are random offsets after some server.dll calls

Edit 2:

Originally Posted by asherkin so the first thing that needs trying is to re-build DHooks against the latest 1.10 SourceMod SDK and see if that fixes the problem.

That fixed it. Any chance we can get an official build to point players to?

[Peace-Maker]

I've added symbols for the latest dhooks2-dynhooks build to throttle as well, so the stack traces should be more useful now.

Shouldn't dhooks get unloaded if it fails to get a required interface? QueryInterfaceDrop returns false by default and QueryRunning is checking the presence of the interface pointers as well.

[Ryan.]

Damn, still crashing in detours7:

dhooks.ext.dll

• https://crash.limetech.org/zevgyk63ey5r
• https://crash.limetech.org/7gceu7qpiz6h
• https://crash.limetech.org/qvoy3vr7myow
• https://crash.limetech.org/ikemwyp7pumd
• https://crash.limetech.org/kxiymou6jc5c

server.dll

• https://crash.limetech.org/lic2oju3rsjx

These crashes are from the plugin I posted above. The plugin pre-hooks a virtual function and changes one parameter. The hooked function's signature is void (float, bool). I'm trying to change the float

Works perfect with no crashes when building detours7 against Sourcemod 1.10 though

Metamod:Source version 1.11.0-dev+1116
SourceMod Version: 1.10.0.6335

[Drixevel]

Can confirm detours7 is crashy boi on Windows with 1.10 6354.