[NgBUCKWANGS]

My plugin ABM has 2 bugs (one is rare, the other extremely rare).

• Between loading screens, if a person crashes, quits, times out during a tiny window, it can screw up the counting of team mates. This is the only time I can't track a player disconnecting.
• For some reason (completely unrepeatable, very random), rarely someone gets moved to spectator.

I believe I can solve these two bugs if I can find the correct moment to iterate over the survivors. I can set an explicit spectator flag pretty easily where if a person didn't explicitly choose to be a spectator, I'll put them back on their team. Also by finding the best time to iterate over all of the survivors, I can fix the count for those rare disconnects that don't fire the player_disconnect event.

My approach would be this. After all players are loaded, iterate over them and find the ones that are no longer connected and remove them from the StringMap. Once this is done, start a timer that will watch out for spectators that didn't explicitly ask to spectate.

My problem is, I don't know the perfect moment, in which ALL players are really and finally connected AND where GetClientAuthId would actually work. I had some hacks that worked but I felt quite uncomfortable with them. Any help is greatly appreciated

[cravenge]

You can just add natives in other plugins that can handle the bugs you mention. Examples of this are my Modified Self-Help and Different Ammo Packs plugins.

For the disconnect problem, there are plugins such as Client timeout override and Kick Load Stuckers plugins that handles kicking clients that are taking too long to connect including those who crashed and suddenly quit.

Here's how to do it:

Spoiler

abm.sp

PHP Code:

// your handles, includes, booleans, ints, floats here.
#include <kls_forwards> // Kick Load Stuckers plugin's natives and forwards
#include <sass_forwards> // For spectator always stay spectator
// your codes here, also apply the added natives needed to prevent the problems. 


kick_load_stuckers.sp

PHP Code:

bool connectTooLong[MAXPLAYERS+1];

public APLRes AskPluginLoad2(Handle myself, bool late, char[] error, err_max)
{
    CreateNative("IsKLSKicked", KLS_KickedForTooLong);
    
    RegPluginLibrary("kick_load_stuckers_forwards");
    return APLRes_Success;
}

public KLS_KickedForTooLong(Handle plugin, int numParams)
{
    int client = GetNativeCell(1);
    if (client <= 0 || client > MaxClients || !IsClientInGame(client) || IsFakeClient(client))
    {
        ThrowNativeError(SP_ERROR_NATIVE, "Invalid Client!");
        return false;
    }
    
    return connectTooLong[client];
}

public Action KickLoaders(int client, int args)
{
    if (client == 0)
    {
        return Plugin_Handled;
    }
    
    for (int i = 1; i <= MaxClients; i++)
    {    
        if (IsClientConnected(i) && !IsClientInGame(i) && !IsFakeClient(i))
        {
            connectTooLong[i] = true;
            PrintToChatAll("\x05[KLS]\x01 Forced Kicked \x03%N\x01 Due To Loading For %i Seconds!", i, GetConVarInt(cvarDuration));
            KickClient(i, "Kicked For Loading In 120 Seconds!");
        }
    }
    
    return Plugin_Handled;
}

public void OnClientConnected(int client)
{
    connectTooLong[client] = false;
    if (LoadingTimer[client] == null)
    {
        LoadingTimer[client] = CreateTimer(cvarDuration.FloatValue, CheckClientIngame, client, TIMER_FLAG_NO_MAPCHANGE);
    }
}

public Action CheckClientIngame(Handle timer, any client)
{
    LoadingTimer[client] = null;
    
    if (!IsClientConnected(client) || IsClientInGame(client) || IsFakeClient(client))
    {
    connectTooLong[client] = false;
        return Plugin_Stop;
    }
    
    connectTooLong[client] = true;
    PrintToChatAll("\x05[KLS]\x01 Kicked \x03%N\x01 Due To Loading For %i Seconds!", client, cvarDuration.IntValue);
    KickClient(client, "Kicked For Loading In 120 Seconds!");
    
    return Plugin_Stop;
} 


kls_forwards.inc

PHP Code:

#if defined _klsforwards_included_
  #endinput
#endif
#define _klsforwards_included_

public SharedPlugin __pl_klsforwards =
{
    name = "kick_load_stuckers_forwards",
    file = "kick_load_stuckers.smx",
    #if defined REQUIRE_PLUGIN
    required = 1,
    #else
    required = 0,
    #endif
};

public void __pl_klsforwards_SetNTVOptional()
{
    MarkNativeAsOptional("IsKLSKicked");
}

/**
 * Checks whether a client has been kicked by the plugin.
 * @param client    Client index to check on
 *
 * @error            Invalid client, not in game, or fake.
 * @return            True on success, false otherwise.
 */
native bool IsKLSKicked(int client); 


For the spectator problem, there's Spectators always stay spectators plugin that records every human spectator's SteamID and checks it in the next map. You can do the same as above.

[NgBUCKWANGS]

You've give me a great idea. So basically, would it be safe to say that after the very first person activates on the server after a map change, start a timer that counts down, say 120 seconds and anyone that isn't connected after that, kick them?

[cravenge]

I think there's a downside and it would affect the clients. Could be wrong though..