[Neuro Toxin]

This is mostly a question for the more experienced coders / devs.

So, Dynamic.

I've got someone loading "scripts/items/items_game.txt" which is a massive file.

This appears in the server console:

L 05/30/2016 - 20:33:58: [SM] MEMORY LEAK DETECTED IN PLUGIN (file "dynamic.smx")
L 05/30/2016 - 20:33:58: [SM] Unloading plugin to free 32650 handles.
L 05/30/2016 - 20:33:58: [SM] Contact the author(s) of this plugin to correct this error.
L 05/30/2016 - 20:33:58: --------------------------------------------------------------------------
L 05/30/2016 - 20:33:58: TypeFile                |Count1
L 05/30/2016 - 20:33:58: TypePrivateFwd          |Count6528
L 05/30/2016 - 20:33:58: TypeTrie                |Count6530
L 05/30/2016 - 20:33:58: TypeCellStack           |Count1
L 05/30/2016 - 20:33:58: TypeCellArray           |Count19589
L 05/30/2016 - 20:33:58: TypeRegex               |Count1
L 05/30/2016 - 20:33:58: -- Approximately 53107344 bytes of memory are in use by (32650) Handles.

Is there any way to override this limitation?

Spoiler

This is the code that generates the limitation

    if (!FileExists("scripts/items/items_game_fixed.txt"))
    {
        Dynamic dKV = Dynamic();
        
        if(!Dynamic_ReadKeyValues(dKV, "scripts/items/items_game.txt", false, 10240))
        {
            dKV.Dispose();
            SetFailState("Unable to process items_game.txt");
        }
        
        if(!Dynamic_WriteKeyValues(dKV, "scripts/items/items_game_fixed.txt"))
        {
            dKV.Dispose();
            SetFailState("Unable to write item_games_fixed.txt");
        }
        
        dKV.Dispose();
    }

[WildCard65]

No, the limit is in the SM binary itself. To override it is to have SM users recompile SM themselves with a new limit set.
https://github.com/alliedmodders/sou...andleSys.h#L42

[Neuro Toxin]

It would be really nice if dynamic could do something like:

#declare HANDLESYS_MAX_HANDLES_BYPASS

I dont have much of a clue in relation to this being possible. I dont know if the upper limit is hard coded or if an if statement just throws an error.

[WildCard65]

No, the handle limit is compile time constant of sourcemod.logic.dll as the limit itself is a preprocessor define which works the same way as SP preprocessor defines work (in that the define is replaced with it's value in all places it's used in before any compiling is done). Not only that, but the error is only printed for the plugin that owns the MOST handles at the time SM goes and tries to free more handles for it to assign a new handle to a plugin.

[Neuro Toxin]

Ok. That's really clear.

Thanks for the info!!!

[ThatOneGuy]

If I understand correctly, you're pushing each bit of the kv to an array, so very large kv files hit the limit. It would be much less efficient, but if you must cache the whole file, perhaps on kv files > XX size you might combine data chunks into single handles in some way (e.g. CSV or other delimited data would be a simple example, or perhaps saving the section, line breaks and all). Gets messy real fast there though, and uses more processing just to save on handles.

Why did you want dynamic to process kv files anyways? Will dynamic provide a feature more so than coders processing the cfg file themselves and only pushing needed data to dynamic objects (thereby cutting out unneeded data such as tier section names, etc.)?

I love your work making SP more OO, but I'm not understanding the push/payoff to saving entire kv files.

[Neuro Toxin]

Kv is supported so one can serialise/deserialise dynamic objects to disk with one line of code.

The objective of the person reading items.txt is because Dynamic merges duplicate keys if they are named twice in a kv based file.

When i posted this thread. Dynamic used 3 arrays and one trie per Dynamic().

I recently pushed an update to Dynamic that removed one array.

I'm now implementing a const char[] key param so Dynamic can read only the key you want to stop this overkill.