[SpannerSpammer]

Originally Posted by OciXCrom It's not a correct way to do it.

Originally Posted by EFFx You should use get_players()

LOL, I'm curious as to why you both think his looping function won't work.

[Craxor]

It works, but oxicorm says is not the correct way to do it.

[edon1337]

Originally Posted by SpannerSpammer LOL, I'm curious as to why you both think his looping function won't work.

That's what I'm thinking too.

[OciXCrom]

Nobody said it won't work. You tell me why would you loop all 32 players when you cal loop the exact number of connected ones.

[edon1337]

So get_players doesn't use a 32 player loop? Compare my method and yours using get_players now.

PHP Code:

static cell AMX_NATIVE_CALL get_players(AMX *amx, cell *params) /* 4 param */
{
    int iNum = 0;
    int ilen;
    char* sptemp = get_amxstring(amx, params[3], 0, ilen);
    int flags = UTIL_ReadFlags(sptemp);

    cell *aPlayers = get_amxaddr(amx, params[1]);
    cell *iMax = get_amxaddr(amx, params[2]);

    int team = 0;

    if (flags & 48)
    {
        sptemp = get_amxstring(amx, params[4], 0, ilen);

        if (flags & 16)
        {
            if (flags & 64)
                team = g_teamsIds.findTeamId(sptemp);
            else
                team = g_teamsIds.findTeamIdCase(sptemp);
        }
    }

    for (int i = 1; i <= gpGlobals->maxClients; ++i)
    {
        CPlayer* pPlayer = GET_PLAYER_POINTER_I(i);
        if (pPlayer->ingame || ((flags & 256) && pPlayer->initialized))
        {
            if (pPlayer->IsAlive() ? (flags & 2) : (flags & 1))
                continue;
            if (pPlayer->IsBot() ? (flags & 4) : (flags & 8))
                continue;
            if ((flags & 16) && (pPlayer->teamId != team))
                continue;
            if ((flags & 128) && (pPlayer->pEdict->v.flags & FL_PROXY))
                continue;
            if (flags & 32)
            {
                if (flags & 64)
                {
                    if (stristr(pPlayer->name.chars(), sptemp) == NULL)
                        continue;
                }
                else if (strstr(pPlayer->name.chars(), sptemp) == NULL)
                    continue;
            }
            aPlayers[iNum++] = i;
        }
    }

    *iMax = iNum;
    
    return 1;
} 


[HamletEagle]

You forget that get_players does the loop in a module, it's faster. It also return only valid players. When you loop from 1 to maxplayers you loop all possible player indexes.

You can just search, this was discussed a million times.

[edon1337]

Added validity check. Also people are exaggerating the module speed, it's not like it is 300x faster.

[HamletEagle]

The matter is to keep good practices. I'm really not going to debate again why it's better to use get_players in most of cases.