[Visual77]

Originally Posted by friagram Createdatatimer automatically closes the handle when it expires, the flag is not necessary for datatimers. You only need to close it if you manually create a data pack and pass that, be it a timer, or anywhere.

You can do it 3 ways, correct? Supposly you may also need to set hChooseTeamMenuTimer back to INVALID_HANDLE in the timer callbacks and
a if (hChooseTeamMenuTimer != INVALID_HANDLE) check OnMapEnd() were in the case you would have to kill the timer and set the handle back to invalid.

new Handle:pack;
hChooseTeamMenuTimer = CreateDataTimer(0.5, Timer_ChooseTeamMenu, pack);
WritePackCell(pack, client);

public Action:Timer_ChooseTeamMenu(Handle:timer, Handle:pack)
{
    ResetPack(pack);
    new client = ReadPackCell(pack);
}

OR

new Handle:pack = CreateDataPack();
WritePackCell(pack, client);
hChooseTeamMenuTimer = CreateTimer(0.5, Timer_ChooseTeamMenu, pack);

public Action:Timer_ChooseTeamMenu(Handle:timer, Handle:pack)
{
    ResetPack(pack);
    new client = ReadPackCell(pack);
    CloseHandle(pack);
}

OR

new Handle:pack = CreateDataPack();
WritePackCell(pack, client);
hChooseTeamMenuTimer = CreateTimer(0.5, Timer_ChooseTeamMenu, pack, TIMER_DATA_HNDL_CLOSE);

public Action:Timer_ChooseTeamMenu(Handle:timer, Handle:pack)
{
    ResetPack(pack);
    new client = ReadPackCell(pack);
    //CloseHandle(pack);
}

[Powerlord]

Originally Posted by QOOOOOOOOQ Also I've always wondered why add an extra check for IsClientInGame if them being a valid client on the server is already true?

What are you using to guarantee that they're a valid client? Oh right, IsClientInGame...

Originally Posted by QOOOOOOOOQ Also... what's the point of MaxClients instead of MAXPLAYERS... they'd both end up with the same end-result no?

MAXPLAYERS is (currently) hard-coded at the max number of players any Source game supports. Currently this is 65 due to CS:S suppporting 64 players plus SourceTV. You can see this value by looking in scripting/include/clients.inc.

MaxClients is equal to your -maxplayers command-line setting (or gamemodes setting/-maxplayers_override for CS:GO). MaxClients isn't set until the first time a map starts and in unavailable at compile-time, so you can't create global arrays using it.

[QOOOOOOOOQ]

Originally Posted by Visual77 Shouldn't TIMER_DATA_HNDL_CLOSE only be used when a datapack is passed to the timer and CreateDataTimer isn't being used? It's to avoid adding CloseHandle to the datapack timer function from my understanding. MAXPLAYERS is bad form for loops, it's a fixed value of 64 or 65. MaxClients is all the players on the server - could be 8 players if your server has 8 players. You need IsClientInGame because native GetClientTeam(client) can error out if the client is not in game? What Marcus_Brown001 said btw too. If you wouldn't have GetClientTeam in your loop, you most likely wouldn't need IsClientInGame. For example, just resetting a boolean on all clients back to false wouldn't be needing IsClientInGame. http://docs.sourcemod.net/api/index....d=show&id=411&

Ah I got the MaxClients and MAXPLAYERS defines mixed up...

Originally Posted by friagram Createdatatimer automatically closes the handle when it expires, the flag is not necessary for datatimers. You only need to close it if you manually create a data pack and pass that, be it a timer, or anywhere.

Do handles set to timers close when the timer is done automatically then? Because I have many instances where it uses that to check if a timer is running, so only one instance of the timer can be run at once instead of multiple timers for the exact same thing are running and will make it very buggy.

@Visual77 All instances include datapacks, which is useless for what I'm doing, in fact adding it would just make it unnecessarily complicated for no reason, when a player leaves the game, it tells spectators to enter commands - which has nothing to do with the client that left, the client that left doesn't even matter.

[Visual77]

It was an example as to were TIMER_DATA_HNDL_CLOSE could be used. Shouldn't be used unless you work with data packs anyway so
you may have used it incorrectly, but I'm not sure. Wiki dosn't really explain much about this timer flag.

[Powerlord]

Originally Posted by Visual77 It was an example as to were TIMER_DATA_HNDL_CLOSE could be used. Shouldn't be used unless you work with data packs anyway so you may have used it incorrectly, but I'm not sure. Wiki dosn't really explain much about this timer flag.

Mainly because it's essentially a deprecated flag and you should be using CreateDataTimer instead.

Really, though, all it does is call CloseHandle on whatever Handle you passed as the data arg when the timer ends.

[QOOOOOOOOQ]

Ok I've narrowed down basically most of the errors, and now there's about 20 undefined variable errors. EVERY timer function, which takes up about 70%+ of them, so I'll post some examples here.

Know that the same errors occur whether I have only the first 2 parameters of CreateTimer(), or all 4.

Spoiler

Timer_ChooseTeamMenu - (Purpose: When someone leaves a game, it displays the chooseteam menu to clients in spectate, made by someone else, can't remember who or find the topic)

PHP Code:

public OnClientDisconnect(client)
{
    bTempBlock[client] = false;
    bTempBlockTeams[client] = false;

    if(vShowTeamMenu == 2 && hChooseTeamMenuTimer == INVALID_HANDLE)
    {
        for(new who = 1; who <= MAXPLAYERS+1; who++)
        {
            if(GetClientTeam(who) == 1)
            {
                bTempBlockTeams[who] = true;
            }
        }

        hChooseTeamMenuTimer = CreateTimer(0.5, Timer_ChooseTeamMenu, _, TIMER_DATA_HNDL_CLOSE); *******HERE*******
    }
}

public Action:Timer_ChooseTeamMenu(Handle:timer)
{
    for (new who = 1; who <= MAXPLAYERS+1; who++)
    {
        if(GetClientTeam(who) == 1)
        {
            bTempBlockTeams[who] = false;

            FakeClientCommand(who, "chooseteam");
        }
    }
} 


Spoiler

Timer_Respectate - (Purpose: To have players that join the game start out in spectate, then manually choose a team they want to be on(yes I know people will start in spec on map changes)

PHP Code:

public Action:Event_PlayerTeam(Handle:event, const String:name[], bool:broadcast)
{
    new client = GetClientOfUserId(GetEventInt(hEvent, "userid"));
    new oldTeam = GetEventInt(hEvent, "oldteam");
    new bIsBot = GetEventBool(hEvent, "isbot");

    if(!IsClientInGame(client) || bIsBot || bTempBlockTeams[client])
    {
        return Plugin_Handled;
    }

    if(bNewlyJoined(client, oldTeam))
    {
        CreateTimer(0.2, Timer_Respectate, client); *******HERE*******
    }
}

static bool:bNewlyJoined(client, oldTeam)
{
    new value;

    decl String:sAuthId[32];
    GetClientAuthString(client, authId, sizeof(authId));

    (!oldTeam && !GetTrieValue(hPlayerTeamsTrie, authId, value)) ? true : false;
}

public Action:Timer_Respectate(Handle:timer, any:client)
{
    FakeClientCommand(client, "jointeam 1");
} 


Spoiler

Timer_AnnounceDisconnect AND hAnnounceDisconnectPack - (Purpose: To create custom disconnect messages, based on the reason for the client disconnecting.)

PHP Code:

public Event_PlayerDisconnect(Handle:event, const String:name[], bool:broadcast)
{
    new bIsBot = GetEventBool(event, "bot");

    if(!bIsBot)
    {
        new client = GetClientOfUserId(GetEventInt(cvent, "userid"));

        decl String:sReason[64];
        GetEventString(hEvent, "reason", sReason, sizeof(sReason));

        if(StrContains(sReason, "Disconnect by user.")) //Most common disconnect reasons, later on add a more fully custom disconnect reason, for self-disconnect, kick by admin, kick by vote, ban by admin, kick by steam, kick by internet lagging out, and kick by game crash
        {
            strcopy(sReason, sizeof(sReason), "Self");
        }
        else if(StrContains(sReason, "Kicked by administrator"))
        {
            strcopy(sReason, sizeof(sReason), "Admin Kicked");
        }
        else if(StrContains(sReason, "Kicked by Console : You have been voted off"))
        {
            strcopy(sReason, sizeof(sReason), "Team Kicked");
        }

        if(!bSayingClientDisconnect[client]) //Yes, this is declared in the beginning of the plugin, above plugininfo
        {
            bSayingClientDisconnect[vClient] = true;

            new Handle:hAnnounceDisconnectPack;
            CreateDataTimer(0.5, Timer_AnnounceDisconnect, hAnnounceDisconnectPack); *******BOTH HERE*******

            WritePackCell(hAnnounceDisconnectPack, client);
            WritePackString(hAnnounceDisconnectPack, sReason);
        }
    }
}

public Action:Timer_AnnounceDisconnect(Handle:timer, Handle:hAnnounceDisconnectPack)
{
    ResetPack(hAnnounceDisconnectPack);

    new vClient;
    decl String:sReason[64];
    client = ReadPackCell(hAnnounceDisconnectPack);
    ReadPackString(hAnnountDisconnectPack, sReason, sizeof(sReason));

    bSayingClientDisconnect[client] = false;

    CPrintToChatAll(who, "%N Disconnected - Reason: %s", client, sReason);
} 


[Marcus_Brown001]

I can't tell what is undefined from looking at those snippets ... Inside the snippets provided, can you bold, underline, or italicize the specific lines that are spitting errors.

Some things I did notice, however:

• When looping through the players, you should use MaxClients instead of MAXPLAYERS + 1
• Instead of passing a client's index inside of a timer, you should pass his serial or userid (GetClientSerial or GetClientUserId).
• When looping through the players on a server, you should always check the client's validity (you should probably do that inside timers as well). This check could be something as simple as IsClientInGame.

[QOOOOOOOOQ]

Well I listed the words that were undefined... marked the lines now, since you can't bold PHP, that's as good as I can do. Makes a good point for auth method over time through timers, I might as well do that for everything, would probably make it a lot easier, and will add the checks, do all that stuff at the end when I want to optimize. (Like during events, do everything I can using userid, since it appears to be more reliable)

[Powerlord]

The number one cause of a function you're defining showing up as an undefined symbol is that a block isn't closed somewhere (i.e. you're missing a "}" )

[GsiX]

i doubt he actually didn't declare the variable properly..