[MafiaBoss]

Originally Posted by Arkarr Hum, what's wrong ? Any error(s) in console and logs ?

I placed the files, did the configuration and got my guys to test it out, nothing happened. I'll copy paste an example later.

"ChatCommand"
{
"1"
{
"chat" "golden frying pan"
"command" "sm_giveweapon [PLAYER_NAME] 1071"
"flag" "a"
}
}

Thats just one of it.

[jpwanabe]

Yea no longer works after updating.

Plus some plugins don't run off of steam id.

[ddhoward]

Originally Posted by jpwanabe Yea no longer works after updating. Plus some plugins don't run off of steam id.

Steam ID? You mean userID right? Every command that uses ProcessTargetString() can use the userID. Every last one, as that is a function of ProcessTargetString(). Unless the plugin author has manually recreated the @all, @me, @!me, @alive, etc targeting strings, then every command that can use @me, etc., can use the userID.

If you would knowingly and willingly install any plugin that passes the client's name through ServerCommand, then you deserve any grief that exploiters may cause you.


The only problem is with this plugin; Arkarr made an error around line 50-51.

[jpwanabe]

So I should be able to target my self using 76561197992143964 and this plugin

[ddhoward]

Originally Posted by jpwanabe So I should be able to target my self using 76561197992143964 and this plugin

You are severely confused sir. A client's userID is NOT THE SAME THING as his Steam ID. A userID is just a number that the server gives to a client based on how many players joined the server before him since the last server restart. A Steam ID is a unique identifier that is assigned to a person's Steam Account. Now, this CAN also be used to target the player, but not in the form that you have suggested. You need to use the other form of the Steam ID which looks like STEAM_0:1:234567 or [U:1:123456789]. The community ID (which looks like this: 76561197992143964) numbers are NOT applicable for usage in ProcessTargetString().

Let's say that I joined a server. Let's say that

• I am the 378th player to join since the server was last restarted, making my userID 378.
• My Steam ID is STEAM_0:1:48287056 (or STEAM_1:1:48287056 or even [U:1:96574113], depending on the game.)
• My community ID is 76561198056839841
• My player name on the server is "Derek Howard"

Now, assuming that you wanted to give me the GRU for whatever reason, the following ways would ALL BE VALID.

vvvv unspoiler this vvvv

Spoiler

This is what I am suggesting that he use:

sm_givew #378 239

This is an attempt to target me using the steam ID. Since I'm keeping the : in there, I need to put the whole thing in quotes.

sm_givew "#STEAM_0:1:48287056" 239

Another way to use the steam ID. Since I've replaced the : with _, I do not need quotes.

sm_givew #STEAM_0_1_48287056 239

This would work if no other player on the server had the string "Derek" in their name:

sm_givew Derek 239

This would work better than the above, but still wouldn't work if someone was on the server named "Derek Howard is my homeboy":

sm_givew "Derek Howard" 239

This method looks for an exact and complete match after the # sign, and will work even if the "homeboy" guy was on the server:

sm_givew "#Derek Howard" 239

I am suggesting that he use the userID, which is merely a number indicating how many player connections to the server have been established. The first person to connect to a server after it restarts would be #1, the second person would be #2, etc.

https://wiki.alliedmods.net/Admin_Commands_(SourceMod)

^^^ unspoiler this ^^^



The sm_givew command does not need an update. It can already handle userIDs as it makes use of ProcessTargetString(). The ONLY thing that must be done to fix this plugin is to correct the small error on line 51 that I pointed out in my previous post.

I will restate it once more. Every command with targeting that can use @me, @all, etc. can also use #<userid>.

[MafiaBoss]

So it's

"ChatCommand"
{
"1"
{
"chat" "golden frying pan"
"command" "sm_giveweapon #<userid> 1071"
"flag" "a"
}
}

Is it that way?

[ddhoward]

Originally Posted by MafiaBoss So it's "ChatCommand" { "1" { "chat" "golden frying pan" "command" "sm_giveweapon #<userid> 1071" "flag" "a" } } Is it that way?

No. You don't need to change anything that you are doing. Follow the instructions exactly as they are on the first post, and wait for the plugin to be fixed.

"ChatCommand"
{
	"1"
	{
		"chat" "golden frying pan"
		"command" "sm_giveweapon [PLAYER_NAME] 1071"
		"flag" "a"
	}
}

[rowedahelicon]

Fixed it, line 50 was calling for the ID as a string rather than an interger

Format(player_final, sizeof(player_final), "%s", player_id);

Where it should be

Format(player_final, sizeof(player_final), "%d", player_id);

[ddhoward]

Originally Posted by rowedahelicon Fixed it

No you didn't, as you removed the # before the %s/%d.

line 50 was calling for the ID as a string rather than an interger Format(player_final, sizeof(player_final), "%s", player_id); Where it should be Format(player_final, sizeof(player_final), "%d", player_id);

I believe that's what line 49's purpose is. He probably meant to do this on line 50:

Format(player_final, sizeof(player_final), "#%s", player_idSTR);

which also works. It is worth noting that your solution makes line 49 and the player_idSTR variable completely irrelevant.

Attached is an actual fix (I think.)

[Arkarr]

@ddhoward and @rowedahelicon
Well, thanks to you both, I'm too slow for you... Can't fix it until now, didn't have enough time. Anyway, thanks !

@ddhoward
Your version will be posted in the main post. Thanks again.