[cravenge]

Here's one that works on Windows too.

[HarryPotter]

Originally Posted by cravenge Here's one that works on Windows too.

oh nice

[cravenge]

Updated my post!

+ Fixed the return value of the function

In case anyone's wondering what the main difference between mine and Dragokas, it's how the mid-function detour does its job:

Dragokas' version:

PHP Code:

ChargerReturnToNavMesh *__stdcall ChargerReturnToNavMesh::Update(ChargerReturnToNavMesh *this, Charger *a2, float a3)
{
    CNavArea *v3; // edi
    ChargerReturnToNavMesh *result; // eax
    int v5; // eax
    int v6; // eax
    int v7[9]; // [esp+24h] [ebp-24h] BYREF
    
    v3 = (CNavArea *)(*(int (__cdecl **)(_DWORD))(*(_DWORD *)LODWORD(a3) + 1324))(LODWORD(a3));
    if ( (*(_BYTE *)(LODWORD(a3) + 333) & 8) != 0 )
        CBaseEntity::CalcAbsolutePosition((CBaseEntity *)LODWORD(a3)); // gets called for no reason if the last known nav was NULL (out-of-bounds)
    if ( v3 )
    {
        if ( (unsigned __int8)CNavArea::Contains(v3, LODWORD(a3) + 736) )
        {
            *(_DWORD *)this = 3;
            *((_DWORD *)this + 1) = 0;
            *((_DWORD *)this + 2) = 0;
            return this;
        }
        
        v7[0] = *((_DWORD *)v3 + 11);
        v7[1] = *((_DWORD *)v3 + 12);
        v7[2] = *((_DWORD *)v3 + 13);
        v5 = (*(int (__cdecl **)(_DWORD))(*(_DWORD *)LODWORD(a3) + 2484))(LODWORD(a3));
        (*(void (__cdecl **)(int, int *, int, _DWORD, _DWORD, _DWORD, int, int))(*(_DWORD *)v5 + 192))(
          v5,
          v7,
          2,
          0,
          0,
          0,
          1,
          1048576000);
        v6 = (*(int (__cdecl **)(_DWORD))(*(_DWORD *)LODWORD(a3) + 2480))(LODWORD(a3));
        (*(void (__cdecl **)(int, int *, int))(*(_DWORD *)v6 + 180))(v6, v7, 1065353216);
        
        *(_DWORD *)this = 0;
        *((_DWORD *)this + 1) = 0;
        *((_DWORD *)this + 2) = 0;
        return this;
    }
    
    return v3;
    // I don't get why it should have a CNavArea address as the return value
    // may make the Charger remain in stuck state even if he was teleported
    // from an inaccessible area to an accessible one by a plug-in
} 


My version:

PHP Code:

ChargerReturnToNavMesh *__stdcall ChargerReturnToNavMesh::Update(ChargerReturnToNavMesh *this, Charger *a2, float a3)
{
    CNavArea *v3; // edi
    ChargerReturnToNavMesh *result; // eax
    int v5; // eax
    int v6; // eax
    int v7[9]; // [esp+24h] [ebp-24h] BYREF
    
    v3 = (CNavArea *)(*(int (__cdecl **)(_DWORD))(*(_DWORD *)LODWORD(a3) + 1324))(LODWORD(a3));
    if ( v3 ) // do nothing as soon as the area is inaccessible
    {
        if ( (*(_BYTE *)(LODWORD(a3) + 333) & 8) != 0 )
            CBaseEntity::CalcAbsolutePosition((CBaseEntity *)LODWORD(a3));
        if ( (unsigned __int8)CNavArea::Contains(v3, LODWORD(a3) + 736) )
        {
            *(_DWORD *)this = 3;
            *((_DWORD *)this + 1) = 0;
            *((_DWORD *)this + 2) = 0;
            return this;
        }
        
        v7[0] = *((_DWORD *)v3 + 11);
        v7[1] = *((_DWORD *)v3 + 12);
        v7[2] = *((_DWORD *)v3 + 13);
        v5 = (*(int (__cdecl **)(_DWORD))(*(_DWORD *)LODWORD(a3) + 2484))(LODWORD(a3));
        (*(void (__cdecl **)(int, int *, int, _DWORD, _DWORD, _DWORD, int, int))(*(_DWORD *)v5 + 192))(
          v5,
          v7,
          2,
          0,
          0,
          0,
          1,
          1048576000);
        v6 = (*(int (__cdecl **)(_DWORD))(*(_DWORD *)LODWORD(a3) + 2480))(LODWORD(a3));
        (*(void (__cdecl **)(int, int *, int))(*(_DWORD *)v6 + 180))(v6, v7, 1065353216);
    }
    
    *(_DWORD *)this = 0;
    *((_DWORD *)this + 1) = 0;
    *((_DWORD *)this + 2) = 0;
    return this;
    // make sure the action event keeps updating until the Charger in question
    // is back to an accessible area by external means
} 


[Dragokas]

cravenge, thank you. That was done not for intention.

[HarryPotter]

Valve fixed today?

Version 2.2.3.7

An update has been released for Left 4 Dead 2:

- Fixed a potential crash if a Charger failed to return to valid nav for an extended period of time.

[HarryPotter]

Originally Posted by cravenge Here's one that works on Windows too.

I think this bug recently fixed by valve update

PHP Code:

 04/25/2024 - 02:48:27: [SM] Exception reported: Address for "CRTNMUpdate" returned NULL!
L 04/25/2024 - 02:48:27: [SM] Blaming: charger_nav_path_fix-l4d2.smx
L 04/25/2024 - 02:48:27: [SM] Call stack trace:
L 04/25/2024 - 02:48:27: [SM]   [0] SetFailState
L 04/25/2024 - 02:48:27: [SM]   [1] Line 99, charger_nav_path_fix-l4d2.sp::MemoryEx_InitPEB
L 04/25/2024 - 02:48:27: [SM]   [3] Call_Finish
L 04/25/2024 - 02:48:27: [SM]   [4] Line 97, D:\Program Files (x86)\Steam\steamapps\common\Left 4 Dead 2 Dedicated Server\left4dead2\addons\sourcemod\scripting 1.11\include\MemoryEx\ServerLibrary.inc::MemoryExInit
L 04/25/2024 - 02:48:27: [SM]   [5] Line 85, D:\Program Files (x86)\Steam\steamapps\common\Left 4 Dead 2 Dedicated Server\left4dead2\addons\sourcemod\scripting 1.11\include\MemoryEx\ServerLibrary.inc::CheckInitPEB 


[cravenge]

Originally Posted by HarryPotter I think this bug recently fixed by valve update PHP Code:  04/25/2024 - 02:48:27: [SM] Exception reported: Address for "CRTNMUpdate" returned NULL! L 04/25/2024 - 02:48:27: [SM] Blaming: charger_nav_path_fix-l4d2.smx L 04/25/2024 - 02:48:27: [SM] Call stack trace: L 04/25/2024 - 02:48:27: [SM]   [0] SetFailState L 04/25/2024 - 02:48:27: [SM]   [1] Line 99, charger_nav_path_fix-l4d2.sp::MemoryEx_InitPEB L 04/25/2024 - 02:48:27: [SM]   [3] Call_Finish L 04/25/2024 - 02:48:27: [SM]   [4] Line 97, D:\Program Files (x86)\Steam\steamapps\common\Left 4 Dead 2 Dedicated Server\left4dead2\addons\sourcemod\scripting 1.11\include\MemoryEx\ServerLibrary.inc::MemoryExInit L 04/25/2024 - 02:48:27: [SM]   [5] Line 85, D:\Program Files (x86)\Steam\steamapps\common\Left 4 Dead 2 Dedicated Server\left4dead2\addons\sourcemod\scripting 1.11\include\MemoryEx\ServerLibrary.inc::CheckInitPEB

Yup, case closed.

[Dragokas]

ahah, 2 years have passed