Raised This Month: $12 Target: $400
 3% 

Server crash when LR


Post New Thread Reply   
 
Thread Tools Display Modes
databomb
Veteran Member
Join Date: Jun 2009
Location: california
Old 09-23-2017 , 07:28   Re: Server crash when LR
Reply With Quote #11

toxiic5760, good work and thanks for the patience. I should have asked you to test just Hosties on its own before going through the others. It looked like OnGameFrame code but I guess taking another look it could be any timer we have in Hosties. So I have not completely isolated the issue yet based on the stack trace. Try this fix:
https://github.com/dataviruset/sm-ho...40d633511fd218

Also, does this happen *every* time during these LRs or only some of the time?
__________________
databomb is offline
toxiic5760
Member
Join Date: Aug 2015
Location: Omelette du fromage
Old 09-24-2017 , 07:01   Re: Server crash when LR
Reply With Quote #12

So i tested with the fix and it crash : https://crash.limetech.org/d2axn3zts22n

And yes, its seems like crash *every* time
toxiic5760 is offline
databomb
Veteran Member
Join Date: Jun 2009
Location: california
Old 09-24-2017 , 10:39   Re: Server crash when LR
Reply With Quote #13

Still not sure why this would happen all of the sudden. CS:GO devs seem to make a lot of breaking changes...

Try setting:
sm_hosties_lr_beacon 0
sm_hosties_lr_beams 0

Then try:
sm_hosties_lr_cf_slay 0
And see if Chicken Fight still causes the crash.
__________________
databomb is offline
toxiic5760
Member
Join Date: Aug 2015
Location: Omelette du fromage
Old 09-24-2017 , 11:32   Re: Server crash when LR
Reply With Quote #14

There is no crash with Chicken Fight, the looser turn yellow and that all.

Others LR make crash : https://crash.limetech.org/qfjzfrbsbkdr
toxiic5760 is offline
databomb
Veteran Member
Join Date: Jun 2009
Location: california
Old 09-24-2017 , 17:42   Re: Server crash when LR
Reply With Quote #15

Okay, try this fix for the Rock Paper Scissors crash:

https://github.com/dataviruset/sm-ho...6967ab355ba398

The test is to have Rock Paper Scissors Last Request and one player needs to Cancel the menu. This will cause them to be slayed. The server should not crash when this happens..

Really puzzled on this. I mean, at one point the ForcePlayerSuicide signature was broken and we temporarily replaced it with an entity that just caused damage instead. This is an option in this case as well.
__________________
databomb is offline
toxiic5760
Member
Join Date: Aug 2015
Location: Omelette du fromage
Old 09-25-2017 , 11:46   Re: Server crash when LR
Reply With Quote #16

So i tested the fix and the Rock Paper Scissors LR don't make crash and the player is slay, well played ^^
toxiic5760 is offline
databomb
Veteran Member
Join Date: Jun 2009
Location: california
Old 09-25-2017 , 19:29   Re: Server crash when LR
Reply With Quote #17

Okay! Still not exactly sure why but the problem seems to be caused by slaying players at certain times. It is documented that player_hurt slays cause crashes and we tried delaying one game-frame without help. With RPS we delayed 0.1 seconds and it fixed the crash. So the next step is to go back and change the other calls to have a 0.1 second delay for slays, add in some additional safety checks, and we will need to test again. I should have time in a few hours to work on this commit.
__________________
databomb is offline
databomb
Veteran Member
Join Date: Jun 2009
Location: california
Old 09-25-2017 , 22:39   Re: Server crash when LR
Reply With Quote #18

https://github.com/dataviruset/sm-ho...74397e4ea21189

This commit changes the delay time to 0.1 seconds, which was what worked for RPS and it does it for every slay in CS:GO. If the problem is related to calling a slay during certain callbacks then this should fix that.
__________________
databomb is offline
toxiic5760
Member
Join Date: Aug 2015
Location: Omelette du fromage
Old 09-26-2017 , 11:26   Re: Server crash when LR
Reply With Quote #19

Hey,
I tested the last version, and RPS works with no problem but race and hot potato are still make crash
( https://crash.limetech.org/5w3nup2dfht3 )
toxiic5760 is offline
databomb
Veteran Member
Join Date: Jun 2009
Location: california
Old 09-27-2017 , 01:52   Re: Server crash when LR
Reply With Quote #20

And Race and Hot Potato both crash as soon as someone wins?

Post your hosties config file so I can see your race and hot potato convars.
__________________
databomb is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 13:09.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode