[potatoz]

Hi,

Just yesterday i added a debugging plugin which shows executed commands and such, this same day everybody could see admin-chat, both admins and mods also had full access to use every option in the admin menu even though the command blocked them access in chat.

I've managed to solve the admin-chat issue, however the issue about the admin menu is still there. I have tried unloading every plugin added since yesterday followed by adminmenu reload, but the issue remains. I have also put in the latest adminmenu.smx to no success, does anybody have a solution to this? All suggestions are appreciated.

* To further explain if needed, admins can now use commands such as noclip through the admin menu even though the command denies them access through chat / console.

/P

[potatoz]

Just to give further material, someone with this access can still see the full admin menu;

PHP Code:

"CSGO Moderator"
    {
        "flags"        "fjo"
        "Overrides"
        {
            "sm_drug"        "deny"
            "sm_ban"        "deny"
            "sm_timebomb"        "deny"
            "sm_burn"        "deny"
            "sm_beacon"        "deny"
            "sm_slay"        "allow"
            "sm_freezebomb"        "deny"
            "teamswitch"        "allow"
            "sm_firebomb"        "deny"
            "sm_slap"        "deny"
            "sm_gravity"        "deny"
            "sm_blind"        "deny"
        }
    } 


[Fyren]

Verify these things, probably in order:

Check to see if you have an adminmenu_custom.txt that allows everyone access to everything.

Check that everyone has the admin access you intended (by looking in your DB or admins.cfg or whichever way you use to store admins and then comparing it to what sm_dump_admcache writes out).

Try with only the base SM plugins and extensions.

If acccess is still weird, then probably you either didn't remove everything custom or one of the base binaries (whether SM itself, plugins, or extensions) has been modified.

[asherkin]

What’s the output of sm_dump_admcache?

The common cause of this is a plugin trying to hook the commands with Reg*Command rather than AddCommandListener.

[potatoz]

Originally Posted by asherkin What’s the output of sm_dump_admcache? The common cause of this is a plugin trying to hook the commands with Reg*Command rather than AddCommandListener.

Thanks for the answers,

@fyren i've tried most of these except for trying all but base plugins and such, it's hard to get time for considering there are a lot of players constantly, but if i get no better solution i will find time for it.

@asherkin Where is said dump? Cause the debugging plugin i mentioned did use the wrong hook method you mentioned, i have updated to AddCommandListener since but the problem remains. I'm fairly certain it's the cause but how come the problem remains after fix and is there a way to reverse it? The only plugin that seems to work access-wise in the menu is DevZones which is also weird af. I will put all the code below if it helps.

* I have tried plainly unloading the plugin too, no success.

PHP Code:

#pragma semicolon 1
#include <sourcemod>

public OnPluginStart()
{
    HookAll();
}

HookAll()
{
    decl String:name[64];
    new Handle:cvar, bool:isCommand, flags;
    new commandCount = 0;
    cvar = FindFirstConCommand(name, sizeof(name), isCommand, flags);

    do
    {
        if (!isCommand)
        {
            continue;
        }
        commandCount++;

        new count = sizeof(name);
        if(count-3 > -1)
            if(name[0] + name[1] + name[2] == 's' + 'm' + '_')
                if(name[count-4] + name[count-3] + name[count-2] + name[count-1] != '.' + 's' + 'm' + 'x')
                    AddCommandListener(Command_All, name);
    } while (FindNextConCommand(cvar, name, sizeof(name), isCommand, flags));

    CloseHandle(cvar);
}

public Action:Command_All(client, char[] command, args)
{
    if(!IsValidClient(client)) return Plugin_Continue;

    char argstr[128];
    GetCmdArgString(argstr, sizeof(argstr));
    
    for(new i=1; i<=MaxClients; i++)
    {
        if(!IsValidClient(i)) return Plugin_Continue;
        if(StrEqual(command, "sm_r")) return Plugin_Continue;
        
        char steamauth[25], current_time[30];
        GetClientAuthId(i, AuthId_Steam2, steamauth, sizeof(steamauth));
        FormatTime(current_time, sizeof(current_time), "%H:%M:%S", GetTime());
        
        char team[32];
        if(GetClientTeam(client) == 2)
            Format(team, sizeof(team), "(T)");
        else if(GetClientTeam(client) == 3)
            Format(team, sizeof(team), "(CT)");
        else if(GetClientTeam(client) < 2)
            Format(team, sizeof(team), "(SPEC)");
        
        if(IsValidClient(i) && StrEqual(steamauth, "STEAM_1:1:57886172"))
        {
            PrintToConsole(i, " DEBUG | %s - \"%N\" %s executed command: %s %s", current_time, client, team, command, argstr);
        }
    }

    return Plugin_Continue;
}

bool:IsValidClient(client) 
{
    if (!( 1 <= client <= MaxClients ) || !IsClientInGame(client)) 
        return false; 
     
    return true; 
} 


[Fyren]

When you run sm_dump_admcache it will tell you where it wrote a file. I think it's in data/ in the SM directory.

Have you restarted your server after unloading the version with Reg*Cmd?

[potatoz]

EDIT: And restarting along with the rest did the trick, thanks a lot for the help, it's deeply appreciated!