[Mixtaz]

Hello everyone. I have rather peculiar problem. There is a guy on my server who is playing on very high fps and he is doing something called SGS (stand-up ground strafing) and some sort of parachute shenaningans.

He is ruining experience for some of the players and I want to force limit his FPS to 100. I've made an attempt to make a plugin that stops him, but for some reason whenever he joins it also automatically kicks everyone whose fps is above 100.

But in this case he is the only threat actor here so I only care that he has 100 FPS max. Here is the code I've made:

PHP Code:

#include < amxmodx >

#define PLUGIN_VERSION "1.1"

#define TASK_FREQ 2.0 

#define isThreat(%1) equal(%1, g_szThreatActorSID)

new Trie:g_tCvars;

const g_iFpsMax = 100;
const g_iFpsOverride = 0;

new const g_szThreatActorSID[] = "STEAM_0:1:122354662";
new g_szAuthID[ 32 ]

public plugin_cfg( )
{
    g_tCvars = TrieCreate( );

    new szFpsMax[ 3 ], szFpsOverride[ 1 ];
    num_to_str( g_iFpsMax, szFpsMax, charsmax( szFpsMax ) );
    num_to_str( g_iFpsOverride, szFpsOverride, charsmax( szFpsOverride ) );
    
    TrieSetString( g_tCvars, "fps_max", szFpsMax );
    TrieSetString( g_tCvars, "fps_override", szFpsOverride );
    
    set_task( TASK_FREQ, "OnTaskCheckCvars", _, _, _, "b" );
}

public plugin_init( )
{
    register_plugin( "Fps Limit", PLUGIN_VERSION, "DoNii x Mixtaz" );
    register_cvar( "fps_limit_cvar", PLUGIN_VERSION, FCVAR_SERVER | FCVAR_SPONLY );
}

public plugin_end( )
TrieDestroy( g_tCvars );

public client_authorized( id )
{
    get_user_authid(id, g_szAuthID, charsmax(g_szAuthID))

    if(isThreat(g_szAuthID))
        client_print( id, print_console, "Ustaw komendy fps_max 100 i fps_override 0!" );
}

public OnTaskCheckCvars( )
{
    new szPlayers[ 32 ], iNum;
    get_players( szPlayers, iNum, "c" );
    static iTempID;

    for( new i; i < iNum; i++ )
    {
        iTempID = szPlayers[ i ];

        if(isThreat(g_szAuthID))
        {
            query_client_cvar( iTempID, "fps_max", "OnCvarResult" );
            query_client_cvar( iTempID, "fps_override", "OnCvarResult" );
        }
    }
}

public OnCvarResult( id, const szCvar[ ], const szValue[ ] )
{ 
    new szValueCheck[ 4 ], szReason[ 128 ];
    TrieGetString( g_tCvars, szCvar, szValueCheck, charsmax( szValueCheck ) );
    
    new iValue = str_to_num( szValue );
    
    if( equal( szCvar, "fps_max" ) )
    {    
        if( iValue > g_iFpsMax )
        {
            formatex( szReason, charsmax( szReason ), "^n***************************^n** Ustaw komendy fps_max 100 i fps_override 0! ^n***************************", g_iFpsMax );
            
            server_cmd( "kick #%d", get_user_userid( id ));
            client_print( id, print_console, szReason );
        }
    }
    
    else if( equal( szCvar, "fps_override" ) )
    {
        if( iValue != g_iFpsOverride )
        {
            formatex( szReason, charsmax( szReason ), "^n***************************^n** Ustaw komendy fps_max 100 i fps_override 0! <- **^n***************************", g_iFpsOverride );
            
            server_cmd( "kick #%d", get_user_userid( id ));
            client_print( id, print_console, szReason );
        }
    }
    return PLUGIN_CONTINUE;
} 


[Napoleon_be]

You're executing query_client_cvar() on all players instead of the threath itself. Don't loop through all player, just target the threat itself and act accordingly.

PHP Code:

public OnTaskCheckCvars( )
{
    new szPlayers[ 32 ], iNum;
    get_players( szPlayers, iNum, "c" );
    static iTempID;

    for( new i; i < iNum; i++ )
    {
        iTempID = szPlayers[ i ];

        if(isThreat(g_szAuthID))
        {
            query_client_cvar( iTempID, "fps_max", "OnCvarResult" );
            query_client_cvar( iTempID, "fps_override", "OnCvarResult" );
        }
    }
} 


[deprale]

cvars can be faked, instead there are better ways to check for high fps.

[mlibre]

@deprale show us your cards

[Mixtaz]

I have changed my code, there are no useless loops anymore:

PHP Code:

#include < amxmodx >

#define PLUGIN_VERSION "1.1a"
#define TASK_FREQ 2.0
#define MAX_FPS 100
#define OVERRIDE_STATE 0
#define isThreat(%1) equal(%1, g_szThreatActorSID)

new Trie:g_tCvars;

new const g_szThreatActorSID[] = "STEAM_0:1:122354662";

public plugin_cfg( )
{
    g_tCvars = TrieCreate( );

    new szFpsMax[ 3 ], szFpsOverride[ 1 ];
    num_to_str( MAX_FPS, szFpsMax, charsmax( szFpsMax ) );
    num_to_str( OVERRIDE_STATE, szFpsOverride, charsmax( szFpsOverride ) );
    
    TrieSetString( g_tCvars, "fps_max", szFpsMax );
    TrieSetString( g_tCvars, "fps_override", szFpsOverride );
}

public plugin_init( )
{
    register_plugin( "Restrict Player FPS", PLUGIN_VERSION, "Mixtaz" );
}

public plugin_end( ) TrieDestroy( g_tCvars );

public client_authorized( id )
{
    static szAuthID[24];
    get_user_authid(id, szAuthID, charsmax(szAuthID))

    if(isThreat(szAuthID))
        initPlayerCheck(id)
}

public initPlayerCheck(id)
{
    query_client_cvar( id, "fps_max", "PlayerPunish" );
    query_client_cvar( id, "fps_override", "PlayerPunish" );

    set_task( TASK_FREQ, "initPlayerCheck", id, _, _, "b" );
}

public PlayerPunish( id, const szCvar[ ], const szValue[ ] )
{ 
    new szValueCheck[ 4 ], szReason[ 128 ];
    new userid = get_user_userid(id);
    TrieGetString( g_tCvars, szCvar, szValueCheck, charsmax( szValueCheck ) );
    
    new iValue = str_to_num( szValue );
    
    if( equal( szCvar, "fps_max" ) )
    {    
        if( iValue > MAX_FPS )
        {
            formatex( szReason, charsmax( szReason ), "Ustaw komende fps_max na %i!", MAX_FPS );
            
            server_cmd("kick #%d ^"%s^"", userid, szReason);
        }
    }
    
    else if( equal( szCvar, "fps_override" ) )
    {
        if( iValue != OVERRIDE_STATE )
        {
            formatex( szReason, charsmax( szReason ), "Ustaw komende fps_override na %i!", OVERRIDE_STATE );
            
            server_cmd("kick #%d ^"%s^"", userid, szReason);
        }
    }
    return PLUGIN_CONTINUE;
} 


It should work fine. Btw, I'm also interested in a better method of checking player's values for certain commands. Feel free to share

[DJEarthQuake]

The script has 2 methods. Feel free to use or cannibalize.

https://github.com/djearthquake/amxx...eck_finale.sma

[mlibre]

query_client_cvar not is very reliable I read it for there

[georgik57]

in client_PreThink, measure the time between current think and last think to get accurate player fps