Raised This Month: $51 Target: $400
 12% 

[MVP] MVP Of the Round + Custom Sounds (reAPI Support)


Post New Thread Reply   
 
Thread Tools Display Modes
Shadows Adi
AlliedModders Donor
Join Date: Aug 2019
Location: Romania
Old 09-01-2021 , 11:09   Re: [MVP] MVP Of the Round + Custom SoundTracks (reAPI Support)
Reply With Quote #71

Quote:
Originally Posted by HamletEagle View Post
In your first post, I don't see any description or information about the custom sound tracks(how it works, commands that can be used, etc), please have a proper description.
Done everything.

Quote:
Originally Posted by HamletEagle View Post
3. This is mainly a question, but in the menu, for selecting tracks you already block non VIP players from selecting VIP-only tracks. However, inside PlayTrack I see that you added checks to make sure the currently selected track(line 1346) is not a VIP-only track if the player is not VIP. The only way you could reach this scenario is if someone removes his VIP access during the game and does amx_reloadadmins.
Supporting this case is perfectly fine, I'm just curious if there is another reason for adding this check.
Yes, this is the reason for adding that check.
__________________


Accepting Paid Requests, contact PM.

MVP Of The Round View project on GITHUB / AlliedModders
CSGO REMAKE ~ CSGO MOD [STABLE + SOURCE CODE]
Shadows Adi is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 09-01-2021 , 11:46   Re: [MVP] MVP Of the Round + Custom SoundTracks (reAPI Support)
Reply With Quote #72

Everything looks fine after an extremely fast check.
Good job, approved.
__________________
HamletEagle is offline
Shadows Adi
AlliedModders Donor
Join Date: Aug 2019
Location: Romania
Old 09-01-2021 , 12:06   Re: [MVP] MVP Of the Round + Custom SoundTracks (reAPI Support)
Reply With Quote #73

Thank you for review and help!
__________________


Accepting Paid Requests, contact PM.

MVP Of The Round View project on GITHUB / AlliedModders
CSGO REMAKE ~ CSGO MOD [STABLE + SOURCE CODE]
Shadows Adi is offline
Shadows Adi
AlliedModders Donor
Join Date: Aug 2019
Location: Romania
Old 12-08-2021 , 10:34   Re: [MVP] MVP Of the Round + Custom Sounds (reAPI Support)
Reply With Quote #74

Update
Version 2.7


- Stop any sound playing before playing MVP sound
__________________


Accepting Paid Requests, contact PM.

MVP Of The Round View project on GITHUB / AlliedModders
CSGO REMAKE ~ CSGO MOD [STABLE + SOURCE CODE]
Shadows Adi is offline
kudoclasm
Junior Member
Join Date: Dec 2021
Old 12-22-2021 , 07:29   Re: [MVP] MVP Of the Round + Custom Sounds (reAPI Support)
Reply With Quote #75

Hey there!

Great plugin, and thank you and all the contributors for the effort

I have one question. I would like to keep the track of #of MVPs a player received and I guess Player MVP section in the database is for that. Did I understand this correctly? If so the Player MVP section for all the players in my server stays 0 at all times. No matter how many rounds - maps they play.

I checked the instructions and configuration many times and seems like I followed everything correctly. Am I missing something or do I need to change something in the configuration?

Some more context:
* AMXX Version 1.8.2
* The SQL settings and credential are correct.
* SQL connection is working as intended as the STEAM IDs of the players immediately being recorded in the mvp_otr table as soon as they login to the server.
* No errors are present in the log
* I have other plugins in the server that are using the SQL option and all of them are working as intended.

Thanks in advance
Attached Thumbnails
Click image for larger version

Name:	Capture.PNG
Views:	65
Size:	13.5 KB
ID:	192752  
kudoclasm is offline
Shadows Adi
AlliedModders Donor
Join Date: Aug 2019
Location: Romania
Old 12-22-2021 , 07:57   Re: [MVP] MVP Of the Round + Custom Sounds (reAPI Support)
Reply With Quote #76

Yes, column "Player MVP" is to keep tracking a player's MVP times.
Thanks for feedback, I will look into it.
__________________


Accepting Paid Requests, contact PM.

MVP Of The Round View project on GITHUB / AlliedModders
CSGO REMAKE ~ CSGO MOD [STABLE + SOURCE CODE]

Last edited by Shadows Adi; 12-22-2021 at 08:06.
Shadows Adi is offline
Shadows Adi
AlliedModders Donor
Join Date: Aug 2019
Location: Romania
Old 12-22-2021 , 10:32   Re: [MVP] MVP Of the Round + Custom Sounds (reAPI Support)
Reply With Quote #77

Update
Version 2.8
:
  • Added player's MVP count in MVP Menu.
  • Added instant save for player's data after being MVP if the INSTANT_SAVE setting is 1.
__________________


Accepting Paid Requests, contact PM.

MVP Of The Round View project on GITHUB / AlliedModders
CSGO REMAKE ~ CSGO MOD [STABLE + SOURCE CODE]
Shadows Adi is offline
kudoclasm
Junior Member
Join Date: Dec 2021
Old 12-22-2021 , 11:44   Re: [MVP] MVP Of the Round + Custom Sounds (reAPI Support)
Reply With Quote #78

Thank you so much

According to my initial tests I think it's working now. I will run few more tests with more players and I will let you know if I encounter anything fishy.

Just a note, I received the following warning when I compiled the plugin:

most_valuable_player.sma(443 -- 444) : warning 213: tag mismatch
most_valuable_player.sma(444 -- 445) : warning 213: tag mismatch


One functionality question. We are making event nights in our private server and I would like to determine the MVPs based on the maps we play. So is it possible for you to add the played map data to mvp_otr SQL table as well? Will that be too much work or out of the scope of this plugin?

Thank you so much!!!
Attached Thumbnails
Click image for larger version

Name:	warning.PNG
Views:	64
Size:	14.7 KB
ID:	192754  
kudoclasm is offline
Shadows Adi
AlliedModders Donor
Join Date: Aug 2019
Location: Romania
Old 12-22-2021 , 12:28   Re: [MVP] MVP Of the Round + Custom Sounds (reAPI Support)
Reply With Quote #79

Quote:
Originally Posted by kudoclasm View Post
Just a note, I received the following warning when I compiled the plugin:

most_valuable_player.sma(443 -- 444) : warning 213: tag mismatch
most_valuable_player.sma(444 -- 445) : warning 213: tag mismatch
I know about these warnings, I don't know why it appears, but it seems only on amxmodx 1.8.2.

Quote:
Originally Posted by kudoclasm View Post
One functionality question. We are making event nights in our private server and I would like to determine the MVPs based on the maps we play. So is it possible for you to add the played map data to mvp_otr SQL table as well? Will that be too much work or out of the scope of this plugin?
Can you explain what data should be passed into that column?
__________________


Accepting Paid Requests, contact PM.

MVP Of The Round View project on GITHUB / AlliedModders
CSGO REMAKE ~ CSGO MOD [STABLE + SOURCE CODE]
Shadows Adi is offline
kudoclasm
Junior Member
Join Date: Dec 2021
Old 12-22-2021 , 12:57   Re: [MVP] MVP Of the Round + Custom Sounds (reAPI Support)
Reply With Quote #80

I want the name of the map file to be passed to that column. Like de_dust2, or de_tuscan etc.
kudoclasm is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 00:08.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode