[edon1337]

Hi,

How would I find the last line in a file? Let's say I've written these in my file:

"This Is First Line" "This Is Second Line" "This Is Third Line"

So how would I find the fourth line with a stock and then use write_file with it, when I use -1 as the last parameter it mixes lines with each other.

If you still didn't understand, here's another explanation:

As I said before, this is what I've manually written in the file myself:

"This Is First Line" --> So this supposedly is line number 0 "This Is Second Line" --> Line number 1 "This Is Third Line" --> Line number 2 --> This here isn't a line but it should be line number 3, how would I find it?

So basically I need to find the last line + 1.

This is what I've done so far but it isn't working properly.

PHP Code:

new g_iLine;

public OnAddNewAdmin( id )
{
    if( ~ get_user_flags( id ) & ADMIN_ADD_FLAG )
    {
        client_print( id, print_console, "You have no Access to this command" );
        return PLUGIN_HANDLED;
    }

    if( read_argc( ) != 5 )
    {
        client_print( id, print_console, "Usage is : amx_addadmin <Nick|SteamID> <Password> <Flags> <Prefix>" );
        return PLUGIN_HANDLED;
    }

    new szAdminName[ 32 ], szAdminPassword[ 18 ], szAdminFlags[ 32 ], szAdminPrefix[ 18 ];
    
    read_argv( 1, szAdminName, charsmax( szAdminName ) );
    read_argv( 2, szAdminPassword, charsmax( szAdminPassword ) );
    read_argv( 3, szAdminFlags, charsmax( szAdminFlags ) );
    read_argv( 4, szAdminPrefix, charsmax( szAdminPrefix ) );
    
    if( ( strlen( szAdminName ) < 3 ) || ( strlen( szAdminFlags ) < 1 ) )
    {
        client_print( id, print_console, "ERROR: Incorrect Format of Admin" );
        return PLUGIN_HANDLED;
    }

    ReadFile( );
    
    new szConfigs[ 64 ], szFormat[ 128 ], szData[ 128 ];
    get_configsdir( szConfigs, charsmax( szConfigs ) );
    formatex( szFormat, charsmax( szFormat ), "%s/%s", szConfigs, g_szFile );
    
    formatex( szData, charsmax( szData ), "^"%s^" ^"%s^" ^"%s^" ^"%s^"", szAdminName, szAdminPassword, szAdminFlags, szAdminPrefix );
    write_file( szFormat, szData, GetLines( szFormat ) );
    
    client_print( id, print_console, "Successfully Added New Admin: Name: %s | Password: %s | Flags: %s | Prefix: %s |", szAdminName, szAdminPassword, szAdminFlags, szAdminPrefix );
    return PLUGIN_CONTINUE;
}

ReadFile( )
{
    new szConfigs[ 32 ], szFormat[ 64 ], szPlayerData[ 512 ], szName[ 32 ], szPassword[ 18 ], szAccessFlags[ 25 ], szPrefix[ 18 ];
    get_configsdir( szConfigs, charsmax( szConfigs ) );
    
    formatex( szFormat, charsmax( szFormat ), "%s/%s", szConfigs, g_szFile );
    
    new iFile = fopen( szFormat, "r" );
    
    if( iFile )
    {
        while( ! feof( iFile ) )
        {    
            fgets( iFile, szPlayerData, charsmax( szPlayerData ) );
            trim( szPlayerData );
            
            if( szPlayerData[ 0 ] == ';' || ( szPlayerData[ 0 ] == '/' && szPlayerData[ 1 ] == '/' ) )
            continue;
            
            while( szPlayerData[ 0 ] == EOS )
            g_iLine--;
            
            parse( szPlayerData, szName, charsmax( szName ), szPassword, charsmax( szPassword ), szAccessFlags, charsmax( szAccessFlags ), szPrefix, charsmax( szPrefix ) );
            
            g_iItems[ Player_Name ] = szName;
            g_iItems[ Player_Password ] = szPassword;
            g_iItems[ Player_AccessFlags ] = szAccessFlags;
            g_iItems[ Player_Prefix ] = szPrefix;
            
            ArrayPushArray( g_aDatabase, g_iItems );
            
            g_iLine++;
        }
        fclose( iFile );
    }
}

GetLines( const szFile[ ] )
{
    if( file_exists( szFile ) )
    {
        new szData[ 128 ], iTextLength;

        while( read_file( szFile, g_iLine, szData, charsmax( szData ), iTextLength ) )
        {            
            if( szData[ 0 ] )
            {
                g_iLine++;
                continue;
            }
        }
        return g_iLine;
    }
    return -1;
} 


I'm trying to re-create admin.sma as it is too old and poorly written. I've made it to be able to set admins by an .ini file (already done) and by an in-game command (doesn't work properly). So when you execute the command, it should automatically find a new line for the new entry.

[HamletEagle]

Someone did not bother to read the documentation. There's flag "a" for fopen.

[edon1337]

Originally Posted by HamletEagle Someone did not bother to read the documentation. There's flag "a" for fopen.

Sorry, I never thought fopen would have such option, what exactly does flag "a" do? It says 'append' in the Doc but I don't quite understand it..

[Bugsy]

More info on fopen()

http://pubs.opengroup.org/onlinepubs...ons/fopen.html

So you're just trying to add a line to the end of a file?

PHP Code:

new iFile = fopen( "file.txt" , "a" );

fputs( iFile , "New line^r^n" );
    
fclose( iFile ); 


[edon1337]

Originally Posted by Bugsy More info on fopen() http://pubs.opengroup.org/onlinepubs...ons/fopen.html So you're just trying to add a line to the end of a file? PHP Code: new iFile = fopen( "file.txt" , "a" ); fputs( iFile , "New line^r^n" );      fclose( iFile );

First of all, thanks for your reply, and the link. I'll take a look at it.
No, I just want to find the last line of the file and then increase it by 1 (that would take me to the line I'm searching for).

I already tried to explain my situation, let's say this is my .ini file with the infos:

"edon" "bugsy"

Now I have a command to set new entries to the .ini file via a console command.

So now we add a new entry:

PHP Code:

write_file( "MyFile.ini", "hamleteagle" ); 


By default the line of write_file is -1 (auto detect or something), it mixes lines up like this

"edon" "bugsy""hamleteagle"

My point is to ignore that mix, so it should be like this:

"edon" "bugsy" "hamleteagle"

Hope you understood!

[E1_531G]

You should always write in the file using newline char at the end: fputs( iFile , "New line^n" );
If you write good first 2 lines, the 3th line will be writen fine.

[Bugsy]

That depends on the last person/app that wrote to the file.

You would either need to write "[newline]new line of text" or "new line of text[newline]"

To be safe, I would always read the 2 bytes at the end of the file prior to writing to check if the new line bytes exist, then you can conditionally include when when writing.

[edon1337]

This is what I was actually looking for, thanks anyways!

PHP Code:

    new szConfigs[ 64 ], szFormat[ 128 ];
    get_configsdir( szConfigs, charsmax( szConfigs ) );
    
    formatex( szFormat, charsmax( szFormat ), "%s/%s", szConfigs, g_szFile );
    new iFile = fopen( szFormat, "a" );
    
    fprintf( iFile, "^n^"%s^" ^"%s^" ^"%s^" ^"%s^"", szAdminName, szAdminPassword, szAdminFlags, szAdminPrefix );
    fclose( iFile ); 


[Bugsy]

That's the same thing that I told, except that will always write starting with new-line.

So if the last written line included a new-line at the end, you will end up with a blank line in the file. IMO, it would be better to check the last 1/2 bytes for this before writing.

Last line in file

New line in file

[edon1337]

Originally Posted by Bugsy it would be better to check the last 1/2 bytes for this before writing.

How would I check that?