[Diversity]

it's ok?

/*

V 1.0:

    * Now if you have the knife in your hand you are invisible



*/

#include < amxmodx >
#include < amxmisc >
#include < cstrike >
#include < hamsandwich >
#include < fun >
#include < engine >

new const   PLUGIN[ ] = "Nightcrawler Main",
            VERSION[ ] = "1.0",
            AUTHOR[ ] = "Diversity"

new g_MaxClients

new NoKnife[ 33 ]

#define NIGHT_TEAM CS_TEAM_T
#define HUMAN_TEAM CS_TEAM_CT

public plugin_init( ) {

    register_plugin( PLUGIN, VERSION, AUTHOR )

    register_event( "CurWeapon", "_CurWeapon", "be", "1=1" )

    set_task( 1.0, "_MakeInvis", 0, "", 0, "b", 0 )

    g_MaxClients = get_global_int( GL_maxClients )
}

public client_putinserver( id )
{
    NoKnife[ id ] = 1
}

public _MakeInvis( id )
{
    for( new i = 1; i <= g_MaxClients; i++ )
        if( cs_get_user_team( i ) == NIGHT_TEAM && NoKnife[ id ] == 0 && is_user_alive( i ) )
            return set_user_rendering( i, kRenderFxNone, 0, 0, 0, kRenderTransAlpha , 0 )

    return PLUGIN_HANDLED
}

public _CurWeapon( id )
{
    if( is_user_alive( id ) && get_user_weapon( id ) != CSW_KNIFE )
        return NoKnife[ id ] = 1

    if( is_user_alive( id ) && get_user_weapon( id ) == CSW_KNIFE )
        return NoKnife[ id ] = 0

    return PLUGIN_HANDLED
}

[fysiks]

Why do you ask? Does it work?

[Diversity]

I want to know if there is another faster option

[fysiks]

There are a couple simple optimizations that can be done but they won't likely speed it up all that much, probably negligibly.

In _MakeInvis(), make the entire code conditional based on NoKnife[id] and use get_players(). So, if NoKnife[ id ] == 0 then use get_players() to get only alive Terrorist and then set the rendering on the first player in the array.

In _CurWeapon(), you can refactor it to use the conditionals more efficiently by only calling is_user_alive() and get_user_weapon() once each. Like so:

if player is alive
    if user's weapon is knife
        NoKnife[ id ] = 0
    else
        NoKnife[ id ] = 1

return

[Diversity]

Is good now?

public _MakeInvis( id )
{
    new players[32], asd
    get_players( players, asd, "ae", "TERRORIST" )

    if( asd == 1 )
        if( NoKnife[ players[ 0 ] ] && is_user_alive( players[ 0 ] ) )
            return set_user_rendering( players[ 0 ], kRenderFxNone, 0, 0, 0, kRenderTransAlpha , 0 )

    return PLUGIN_HANDLED
}

public _CurWeapon( id )
{
    if( is_user_alive( id ) && get_user_weapon( id ) == CSW_KNIFE )
        return NoKnife[ id ] = 0
    else
        return NoKnife[ id ] = 1

    return PLUGIN_HANDLED
}

[fysiks]

Your implementation of _CurWeapon() looks like it should work.

Your implementation of _MakeInvis() is not equivalent to the original code and does not match what I said. However, I just noticed that even the original implementation of _MakeInvis() is not correct because there is no "id" passed to the function. Also, you return the set_user_rendering() which means that it will only set rendering for one player. If you did not mean to do this then you should remove the return there.


So, it likely should be like this:

get alive terrorist players
loop through players[]
    if NoKnife[ id ] == 0
        set rendering

[Diversity]

Originally Posted by fysiks Your implementation of _CurWeapon() looks like it should work. Your implementation of _MakeInvis() is not equivalent to the original code and does not match what I said. However, I just noticed that even the original implementation of _MakeInvis() is not correct because there is no "id" passed to the function. Also, you return the set_user_rendering() which means that it will only set rendering for one player. If you did not mean to do this then you should remove the return there. So, it likely should be like this: get alive terrorist players loop through players[] if NoKnife[ id ] == 0 set rendering

now?

public _MakeInvis( id )
{
    new players[32], asd
    get_players( players, asd, "ae", "TERRORIST" )

    if( asd == 1 )
        for(new i = 0; i < players[ 0 ] i++)
            if( NoKnife[ i ] == 0 && is_user_alive( i ) )
                set_user_rendering( i, kRenderFxNone, 0, 0, 0, kRenderTransAlpha , 0 )

    return PLUGIN_HANDLED
}

[Diversity]

Solved.

[fysiks]

Originally Posted by Diversity now? public _MakeInvis( id ) { new players[32], asd get_players( players, asd, "ae", "TERRORIST" ) if( asd == 1 ) for(new i = 0; i < players[ 0 ] i++) if( NoKnife[ i ] == 0 && is_user_alive( i ) ) set_user_rendering( i, kRenderFxNone, 0, 0, 0, kRenderTransAlpha , 0 ) return PLUGIN_HANDLED }

You say it's solve but I just want to clarify to anybody reading this that this code will not work and is not what I suggested.

[eyal282]

PHP Code:

public _MakeInvis( id )
{
    new players[32], asd
    get_players( players, asd, "ae", "TERRORIST" )

    if( asd == 1 )
        for(new i = 0; i < players[ 0 ] i++)
            if( NoKnife[ i ] == 0 && is_user_alive( i ) )
                set_user_rendering( i, kRenderFxNone, 0, 0, 0, kRenderTransAlpha , 0 )

    return PLUGIN_HANDLED 


---->

PHP Code:

public _MakeInvis( id )
{
    new players[32], asd
    get_players( players, asd, "ae", "TERRORIST" )

    if( asd > 0 )
    {
        for(new i = 0; i < asd; i++)
        {  
            new client = players[i];
            if( NoKnife[ client ] == 0 && is_user_alive( client ) )
                set_user_rendering( client, kRenderFxNone, 0, 0, 0, kRenderTransAlpha , 0 )
        }
    }

    return PLUGIN_HANDLED 


I quickly wrote it so it might be wrong / not work / not even compile but it should solve your issue which you falsely claimed to be solved.