[HarryPotter]

Hello, guys, I have a question.

If IsClientInGame(client) return true, IsClientConnected(client) also definitely 100% true ?

All this time I thought when IsClientInGame(client) is true, then IsClientConnected(client) is definitely 100% true until today I saw an error.

L 12/19/2022 - 00:18:20: [SM] Exception reported: Client 6 is not connected
L 12/19/2022 - 00:18:20: [SM] Blaming: AI_HardSI.smx
L 12/19/2022 - 00:18:20: [SM] Call stack trace:
L 12/19/2022 - 00:18:20: [SM] [0] SetUserFlagBits

But when I checked source code, it does check "IsClientInGame(client)" , so it is making me confused at the moment.

PHP Code:

if ( IsValidClient(commandDummy) ) {
    int originalUserFlags = GetUserFlagBits(commandDummy);
    int originalCommandFlags = GetCommandFlags(commandName);            
    SetUserFlagBits(commandDummy, ADMFLAG_ROOT); 
    SetCommandFlags(commandName, originalCommandFlags ^ FCVAR_CHEAT);               
    FakeClientCommand(commandDummy, "%s %s %s", commandName, argument1, argument2);
    SetCommandFlags(commandName, originalCommandFlags);
    SetUserFlagBits(commandDummy, originalUserFlags);            
}


bool IsValidClient(int client) {
    if( client > 0 && client <= MaxClients && IsClientInGame(client) ) {
        return true;
    } else {
        return false;
    }    
} 


Then I investigate functions and in include/clients.inc, it says

PHP Code:

/**
...
 * @param client        Player index (index does not have to be connected).
...
 */
native bool IsClientInGame(int client);

/** 
 * Sets access flags on a client using bits instead of flags.  If the
 * client is not an admin, and flags not 0, a temporary, anonymous AdminId is given.
 *
 * @param client        Player's index.
 * @param flags         Bitstring of flags to set on client.
 * @error               Invalid client index, or client not connected.
 */
native void SetUserFlagBits(int client, int flags); 


Edit: the client could be kick when executing FakeClientCommand,
add IsClientConnected() check after FakeClientCommand.

PHP Code:

int userflags = GetUserFlagBits(client);
int cmdflags = GetCommandFlags("give");
SetUserFlagBits(client, ADMFLAG_ROOT);
SetCommandFlags("give", cmdflags & ~FCVAR_CHEAT);
FakeClientCommand(client, "give health"); //could be kicked (reason: run too many commands or other reason else)
SetCommandFlags("give", cmdflags);
if (IsClientConnected(client)) SetUserFlagBits(client, userflags); 


[LinLinLin]

i don't know this but this is the info i can found

PHP Code:

static cell_t sm_IsClientConnected(IPluginContext *pCtx, const cell_t *params)
{
    int index = params[1];
    if ((index < 1) || (index > playerhelpers->GetMaxClients()))
    {
        return pCtx->ThrowNativeError("Client index %d is invalid", index);
    }

    return (playerhelpers->GetGamePlayer(index)->IsConnected()) ? 1 : 0;
}

static cell_t sm_IsClientInGame(IPluginContext *pCtx, const cell_t *params)
{
    int index = params[1];
    if ((index < 1) || (index > playerhelpers->GetMaxClients()))
    {
        return pCtx->ThrowNativeError("Client index %d is invalid", index);
    }

    return (playerhelpers->GetGamePlayer(index)->IsInGame()) ? 1 : 0;
} 


PHP Code:

namespace SourceMod
{
    /**
     * @brief Abstracts some Half-Life 2 and SourceMod properties about clients.
     */
    class IGamePlayer
    {
    public:
        /**
         * @brief Returns whether the player is in game (putinserver).
         *
         * @return        True if in game, false otherwise.
         */
        virtual bool IsInGame() =0;

        /**
         * @brief Returns whether the player is connected.
         *
         * Note: If this returns true, all above functions except for
         * GetAuthString() should return non-NULL results.
         *
         * @return        True if connected, false otherwise.
         */
        virtual bool IsConnected() =0; 


[little_froy]

i don't know but i can confirm that, FakeClientCommand() cause player disconnected if it runs too often.

#pragma tabsize 0
#pragma semicolon 1
#pragma newdecls required
#include <sourcemod>

#define COUNT   (1000)

public Action cmd_test(int client, int args) 
{
    if(client > 0 && client <= MaxClients && IsClientInGame(client) && IsClientConnected(client))
    {
        for(int i = 0; i < COUNT; i++)
        {
            int userflags = GetUserFlagBits(client);
            int cmdflags = GetCommandFlags("give");
            SetUserFlagBits(client, ADMFLAG_ROOT);
            SetCommandFlags("give", cmdflags & ~FCVAR_CHEAT);
            FakeClientCommand(client, "give health");
            SetCommandFlags("give", cmdflags);
            SetUserFlagBits(client, userflags);
        }
    }
    return Plugin_Handled;
}

public void OnPluginStart()
{
    RegConsoleCmd("sm_test", cmd_test);
}

[HarryPotter]

Originally Posted by little_froy public Action cmd_test(int client, int args) { if(client > 0 && client <= MaxClients && IsClientInGame(client) && IsClientConnected(client)) { for(int i = 0; i < COUNT; i++) { int userflags = GetUserFlagBits(client); int cmdflags = GetCommandFlags("give"); SetUserFlagBits(client, ADMFLAG_ROOT); SetCommandFlags("give", cmdflags & ~FCVAR_CHEAT); FakeClientCommand(client, "give health"); SetCommandFlags("give", cmdflags); SetUserFlagBits(client, userflags); } } return Plugin_Handled; }

You might be right, this could be the reason, I test your code, and there is an exactly same error.

L 12/21/2022 - 03:40:23: SourceMod error session started
L 12/21/2022 - 03:40:23: Info (map "c2m2_fairgrounds") (file "D:\Left 4 Dead 2 Test Server\left4dead2\addons\sourcemod\logs\errors_20221221.log")
L 12/21/2022 - 03:40:23: [SM] Exception reported: Client 1 is not connected
L 12/21/2022 - 03:40:23: [SM] Blaming: test.smx
L 12/21/2022 - 03:40:23: [SM] Call stack trace:
L 12/21/2022 - 03:40:23: [SM]   [0] SetUserFlagBits
L 12/21/2022 - 03:40:23: [SM]   [1] Line 64, d:\Github\Private-Work\L4D2-插件\scripting_1.11\test.sp::Cmd_test
L 12/21/2022 - 03:40:29: Error log file session closed.

[Bacardi]

You should also expect, if some "natives" not take action exactly in that time/same frame.
Maybe change itself happen in next frame ?

*edit
...indeed. Try change order of those natives.
FakeClientCommand to last ?

[HarryPotter]

Originally Posted by Bacardi Try change order of those natives. FakeClientCommand to last ?

Thank you, I add IsClientConnected() check after FakeClientCommand.

PHP Code:

            int userflags = GetUserFlagBits(client);
            int cmdflags = GetCommandFlags("give");
            SetUserFlagBits(client, ADMFLAG_ROOT);
            SetCommandFlags("give", cmdflags & ~FCVAR_CHEAT);
            FakeClientCommand(client, "give health"); //could be kicked (reason: run too many commands)
            SetCommandFlags("give", cmdflags);
            if (IsClientConnected(client)) SetUserFlagBits(client, userflags); 


[luki1412]

They are not the same. You connect first, then you enter the game. You just need to check them in the right order.

if(client > 0 && client <= MaxClients && IsClientConnected(client) && IsClientInGame(client)) { }

In your case you do not need IsClientInGame check at all though.
Check Errors section of each command to see what is needed to be checked.

[Silvers]

Originally Posted by luki1412 You just need to check them in the right order.

In a loop like this you don't need IsClientConnected only IsClientInGame since that validates they are connected.

[luki1412]

Originally Posted by Silvers In a loop like this you don't need IsClientConnected only IsClientInGame since that validates they are connected.

What do you mean?

Not sure why that loop was added or why he needs to execute that command 1000 times but those commands require the client to be connected. Assuming they dont execute in one frame, in the next frame the client is not guaranteed to still be connected.

[Silvers]

The 1000 loop was a test.

What I'm saying is IsClientInGame supersedes IsClientConnected, you don't need to call IsClientConnected if you're calling IsClientInGame.