[OciXCrom]

Originally Posted by Natsheh PHP Code: #define MAX_NAME_LENGTH 32 new szName[MAX_NAME_LENGTH + 2], len; get_user_name(id, szName, MAX_NAME_LENGTH-1); szName[(len=strlen(szName))] = ' '; szName[len+1] = 0;

At some point you need to question whether readability or 0.0000000001 second faster execution is more important.

[HamletEagle]

I agree with OciXCrom, I don't see the point in not using formatex to add a space.

[Natsheh]

yeah, you're right for personal use i recommend using anything which might increase the speed.

[HamletEagle]

Originally Posted by Natsheh yeah, you're right for personal use i recommend using anything which might increase the speed.

But you are increasing the speed of appending a space to the end of a potentially 32 characters long string... which does literally nothing. If your string had millions of characters it would make sense to be concerned about it.

[fysiks]

Originally Posted by kww What do you mean? I know that. I wrote I need NOT only the name but a space after it too formatex(szTemp, charsmax(szTemp), "%s ", szName) ^ If you know how to do it another way then please tell me Sure, I can do this to add a space but what's the difference then: case NAME_ONLY: { get_user_name(iSender, szTemp, charsmax(szTemp)) add(szTemp, charsmax(szTemp), " ") }

I thought you were asking a question if you needed to add a space in the format string to make it work. Your sentence didn't end with any punctuation so I misinterpreted your post.

[Supremache]

PHP Code:


#if !defined MAX_TEXT_LENGTH
const MAX_TEXT_LENGTH = 192
#endif

enum _:eNotifyType {
    ID_ONLY = 1,
    NAME_ONLY
}

enum _:ePrintType {
    PRINT_CHAT = 1,
    PRINT_CONSOLE
}
// Put the player id first thing when creating the stock
// Make the every option be the default i see it will be better
// for using this stock like this " Notify_Ex( id, "test message", "plugin name" ) == will show everything for all players
stock Notify_Ex( iSender, const szInput[ ], const szPluginName[ ], eNotifyType:iShowUserInfo = 0, ePrintType:iPrintDestination = 0 )
{
    new szOutput[ MAX_TEXT_LENGTH ], szTemp[ MAX_NAME_LENGTH ]
    
    if( !szInput[ 0 ] )
    {
        log_amx("Warning! There's nothing to send to players")
        return;
    }
    
    //if(szPluginName[ 0 ] ) Why you are checking if the plugin name are found? if is not found then will show as empty
    //    formatex(szOutput, charsmax(szOutput), "[%s] ", szPluginName)

    switch( iShowUserInfo ) // Use a formatex just one time for everything !!
    {
        case 0: // 0 = Everything
        {
            new szName[ MAX_NAME_LENGTH ]
            get_user_name( iSender, szName, charsmax( szName ) )
            formatex( szTemp, charsmax( szTemp ), "%s (ID: %i)", szName, iSender )
        }
        case ID_ONLY:
        {
            formatex( szTemp, charsmax( szTemp ), "(ID: %i)", iSender )
        }
        case NAME_ONLY:
        {
            get_user_name( iSender, szTemp, charsmax( szTemp ) ) //faster than adding to format
        }
    }

    formatex( szOutput, charsmax( szOutput ), "%s %s %s", szPluginName, iSender ? szTemp : "", szInput )
    trim( szOutput )// iam not sure if it will work but try, if "plugin name" or "iSender" is not founded will be empty with adding space i think this will remove the space
    
    new szPlayers[ MAX_PLAYERS ], iPnum
    get_players(szPlayers, iPnum)
    
    for( new iPlayer, i; i < iPnum; i++) // Use the loop for one time
    {
        iPlayer = szPlayers[ i ]
        
        switch( iPrintDestination )
        {
            case 0:
            {
                console_print( iPlayer, szOutput )
                client_print( iPlayer, print_chat, szOutput )
            }
            case PRINT_CHAT:
            {
                client_print( iPlayer, print_chat, szOutput )
            }
            
            case PRINT_CONSOLE:
            {
                console_print( iPlayer, szOutput)
            }
        }
    }
} 


Edit: After reading the comments i understood everything