[Napoleon_be]

cstrike_running() No idea why i should use this since i specify in my topic that this plugin is for counter-strike only.

Also, iDamage & iDamagebits aren't needed, i know that but i don't think it really matters.

whats wrong with (iAttacker == iInflictor)?

[DJEarthQuake]

Well I could not get it to work with both cstrike and Half-life with that in there actively testing both. It was only a suggestion.

[Napoleon_be]

Originally Posted by DJEarthQuake Well I could not get it to work with both cstrike and Half-life with that in there actively testing both. It was only a suggestion.

Thanks for the suggestion though. On what game were u testing it on? And were u testing your own code?

I mean i'm generaly creating plugins for CS 1.6, it's possible for some plugins to work on other gamemodes but that's not my purpose or my goal. All other goldsource games are basicly dead anyways.

[DJEarthQuake]

Half-Life, Gearbox, CS 1.6. Your code. Anytime get_user_team is introduced without the cstrike_running() other mods are no longer compatible. Take 'get_user_team' out, they work. Put it back with cstrike_running() it bridges the gap. It then works on more than 1 mod.

[Napoleon_be]

Originally Posted by DJEarthQuake Half-Life, Gearbox, CS 1.6. Your code. Anytime get_user_team is introduced without the cstrike_running() other mods are no longer compatible. Take 'get_user_team' out, they work. Put it back with cstrike_running() it bridges the gap. It then works on more than 1 mod.

Thanks, will add cstrike_running() in my code, thanks for making it clear for me.

EDIT: Had to use this in order for it to work properly. When i used your code, hitmarkers were shown when hitting teammates. updated line

PHP Code:

if(is_user_connected(iAttacker) && (get_pcvar_num(pPlugin)) && (cstrike_running()) && get_user_team(iVictim) != get_user_team(iAttacker)) 


[Xalus]

Few suggestions:
- There is no point of saving 'xPos', 'yPos', 'Holdtime' cvars global when only using them in one function
- Same with 'symbol' variable

PHP Code:

public PostTakeDamage(iVictim, iInflictor, iAttacker, Float:iDamage, iDamagebits)
{
    if(is_user_connected(iAttacker)
        && get_pcvar_num(pPlugin)
        && (get_user_team(iVictim) != get_user_team(iAttacker)))
    {
        new const hud_symbols[][] = { "x", "-", "\", "|", "/", "*", "+" };

        static bool:hud_rainbowffect
        hud_rainbowffect = bool:get_pcvar_num(pRainbow)

        set_hudmessage
        (
            .red = hud_rainbowffect ? iRainbow : get_pcvar_num(pColorRed),
            .green = hud_rainbowffect ? iRainbow : get_pcvar_num(pColorGreen),
            .blue = hud_rainbowffect ? iRainbow : get_pcvar_num(pColorBlue),
            .x = get_pcvar_float(pXPosition),
            .y = get_pcvar_float(pYPosition),
            .fxtime = 2.0,
            .holdtime = get_pcvar_float(pHoldTime),
            .fadeintime = 0.0,
            .fadeouttime = 0.0
        );
        show_hudmessage(iAttacker, "%s", hud_symbols[ (get_pcvar_num(pRandomHitmarkers) ? random_num(0, 6) : 0) ] );
    }
} 


[Natsheh]

He can use static variable to hold the value which will more optimized but the cvar change won't be set immediately. Need to change the map.

PHP Code:


public PostTakeDamage(iVictim, iInflictor, iAttacker, Float:iDamage, iDamagebits)
{
    static Float:fHoldValue = 0.0;
    if(fHoldValue == 0.0) fHoldValue = get_pcvar_float(pHoldTime); 


[DJEarthQuake]

@Napoleon_be, we both had cstrike_running() askew. @Xalus nice sanitization.

What I envisioned was this 'spinner script' in the crosshairs.

#!/bin/sh

i=0
while [ $i -le 60 ]; do
  for s in / - \\ \|; do
    printf "\r$s"
    sleep .1
  done
  i=$((i+1))
done

This example uses the damage variable and cstrike_running properly. Works on multiple mods, but not on friendlies.

public PostTakeDamage(iVictim, iInflictor, iAttacker, Float:iDamage, iDamagebits)

{

    if (get_pcvar_num(pPlugin)) {

    if (is_user_connected(iAttacker)) {


    if( cstrike_running() && get_user_team(iVictim) != get_user_team(iAttacker) || !cstrike_running() )

    {

        new const hud_symbols[][] = { "x", "-", "\", "|", "/", "*", "+" };



        static bool:hud_rainbowffect

        hud_rainbowffect = bool:get_pcvar_num(pRainbow)



        set_hudmessage

        (

            .red = hud_rainbowffect ? iRainbow : get_pcvar_num(pColorRed),

            .green = hud_rainbowffect ? iRainbow : get_pcvar_num(pColorGreen),

            .blue = hud_rainbowffect ? iRainbow : get_pcvar_num(pColorBlue),

            .x = get_pcvar_float(pXPosition),

            .y = get_pcvar_float(pYPosition),

            .fxtime = 2.0,

            .holdtime = get_pcvar_float(pHoldTime),

            .fadeintime = 0.0,

            .fadeouttime = 0.0

        );

        show_hudmessage(iAttacker, "%s", hud_symbols[ (get_pcvar_num(pRandomHitmarkers) ? random_num(0, 6) : 0) ] );

        if( iDamage > 150.0) {

        @FnWow(iAttacker, iDamage, iVictim);

        }

      }

    }

  }

}




@FnWow(iAttacker, Float:iDamage, iVictim) {

    client_print(0,print_console,"%n obliterated %n doing %i damage!",iAttacker,iVictim,floatround(iDamage))

    set_hudmessage(iRainbow,iRainbow,iRainbow, -1.0, 0.55, 1, 2.0, 3.0, 0.7, 0.8, 3);

    show_hudmessage(0, "%n obliterated %n doing %i damage!",iAttacker,iVictim,floatround(iDamage))

} 

Thanks for the credit!

SPiNX obliterated Maxjk0 doing 448 damage! *** SPiNX killed Maxjk0 with a headshot from awp ***

[thEsp]

Pretty pointless in my opinion, I'd better use ABD instead.

[Napoleon_be]

cvars are there to be changed immediatly, i won't be changing my code which will lead the plugin to require a map change in order for the cvars to change, even though that would optimize my code.

Also, i won't be displaying any messages that show how much damage has been done, abd is there to do that. This is just simply a remake of the COD Hitmarker, this plugin has no other purpose. If i implent all that, i would just be recreating an already existing plugin, which isn't my goal.