[DarthMan]

Hello. Could anyone help me with a fakemeta version of set_lights ? (EngFunc_LightStyle)
I know I could just do engfunc(EngFunc_LightStyle, 0, "value") where value would be a letter from a to z and then execute the 3 server commands.
Problem is that I want to also be able to reset lights to default value by using #OFF as the value just like it works with engine.

Original C++ code from engine.cpp

PHP Code:

static cell AMX_NATIVE_CALL set_lights(AMX *amx, cell *params) { 
    int iLength;
    char *szLights = MF_GetAmxString(amx, params[1], 0, &iLength);

    if (FStrEq(szLights, "#OFF")) {
        glinfo.bCheckLights = false;
        memset(glinfo.szLastLights, 0x0, 128);
        LIGHT_STYLE(0, glinfo.szRealLights);
        return 1;
    }
    
    glinfo.bCheckLights = true;

    //Reset LastLights and store custom lighting
    ke::SafeStrcpy(glinfo.szLastLights, sizeof(glinfo.szLastLights), szLights);

    LightStyleDetour->DisableDetour();
    LIGHT_STYLE(0, glinfo.szLastLights);
    LightStyleDetour->EnableDetour();

    // These make it so that players/weaponmodels look like whatever the lighting is
    // at. otherwise it would color players under the skybox to these values.
    SERVER_COMMAND("sv_skycolor_r 0\n");
    SERVER_COMMAND("sv_skycolor_g 0\n");
    SERVER_COMMAND("sv_skycolor_b 0\n");

    return 1;
} 


Thanks !

[E1_531G]

You have no reason to use fakemeta instead of the engine.
Also, engine already does what you want.

[fysiks]

If engine works then you should use that. There is most often no good reason to convert to anything else if the original works just fine.

[CrazY.]

It's just going to be a waste of precious time. It doesn't make sense since the engine version it's working correctly.

[HamletEagle]

Will this kind of posts ever stop? GET THIS INTO YOUR HEAD PEOPLE, stop trying to convert one module to another and stop trying to use only one module, you are not gaining anything and in certain cases you can even lose efficiency.

[DarthMan]

Originally Posted by HamletEagle Will this kind of posts ever stop? GET THIS INTO YOUR HEAD PEOPLE, stop trying to convert one module to another and stop trying to use only one module, you are not gaining anything and in certain cases you can even lose efficiency.

I was trying to convert it to FakeMeta becuz I don't feel like using engine only for 1 command. The whole plug-in makes use of FakeMeta and I'm using engine only to set lights. Also, what's wrong in converting? I know, execution is slower since it's not done directly from the c++ module but that isn't a problem. It's just that it makes no sense to use engine only for 1 small thing that can also be done using FakeMeta.

[klippy]

Originally Posted by DarthMan It's just that it makes no sense to use engine only for 1 small thing that can also be done using FakeMeta.

It does make perfect sense. You lose absolutely nothing.

[CrazY.]

I see no problem adding another include. It is certain that some have the preference to use only one of the modules, but depending on what you want to do, it is a real waste of time to find another way, being that it already exists.

I particularly use the engine more, and yet I've never come across any performance-related issues.

[HamletEagle]

Originally Posted by DarthMan I was trying to convert it to FakeMeta becuz I don't feel like using engine only for 1 command. The whole plug-in makes use of FakeMeta and I'm using engine only to set lights. Also, what's wrong in converting? I know, execution is slower since it's not done directly from the c++ module but that isn't a problem. It's just that it makes no sense to use engine only for 1 small thing that can also be done using FakeMeta.

Well, it clearly can not be done with "default" fakemeta, otherwise you would not be asking for help.