[berni]

You have three ways how to close data timer handles:

• Pass TIMER_DATA_HNDL_CLOSE as timer flag when creating the timer, the handle will be closed automatically then.
• Close the handle yourself with CloseHandle()
• pass true as second parameter when killing the timer with KillTimer()

All of the ways mentioned above will close the datatimer's data handle.

[psychonic]

Originally Posted by berni You have three ways how to close data timer handles: Pass TIMER_DATA_HNDL_CLOSE as timer flag when creating the timer, the handle will be closed automatically then. Close the handle yourself with CloseHandle() pass true as second parameter when killing the timer with KillTimer() All of the ways mentioned above will close the datatimer's data handle.

The whole point of using the CreateDataTimer stock is that you don't not need to worry about doing any of the above. It handles it for you.

His suspected issue was doing something similar to:

new Handle:pack = CreateDataPack();
CreateDataTimer(time, pack)  // this was creating a pack itself, leaving the one above unused and accumulating 

[berni]

So what's TIMER_DATA_HNDL_CLOSE good for then ?

[psychonic]

Originally Posted by berni So what's TIMER_DATA_HNDL_CLOSE good for then ?

In case you prefer to do it manually instead of using the included stock.

From timers.inc

stock Handle:CreateDataTimer(Float:interval, Timer:func, &Handle:datapack, flags=0)
{
    datapack = CreateDataPack();
    flags |= TIMER_DATA_HNDL_CLOSE;
    return CreateTimer(interval, func, datapack, flags);
}

[berni]

That means it would only do it if you don't specify your own flags,
in case you specify TIMER_REPEAT or TIMER_FLAG_NO_MAPCHANGE you also have to add | TIMER_DATA_HNDL_CLOSE to it.

The CreateDataTimer() function is confusing a shitload of people by the way

[psychonic]

Originally Posted by berni That means it would only do it if you don't specify your own flags, in case you specify TIMER_REPEAT or TIMER_FLAG_NO_MAPCHANGE you also have to add | TIMER_DATA_HNDL_CLOSE to it.

No, with CreateDataTimer, you give it whatever other flags you want, if any. You can include TIMER_DATA_HNDL_CLOSE if you want, but it's not needed. It will get added automatically to whatever flags are given to it. You are only ever required to add the TIMER_DATA_HNDL_CLOSE if you want SM to automatically close the handle for you and you are not already using CreateDataTimer.[/QUOTE]

Originally Posted by berni The CreateDataTimer() function is confusing a shitload of people by the way

What it does is noted in the function doc above the actual stock (which of course also shows the logic). The function doc is visible on the api site, and there is also a detailed example of it on the wiki.

The documentation is only good if you read it.

[berni]

Originally Posted by psychonic No, with CreateDataTimer, you give it whatever other flags you want, if any. You can include TIMER_DATA_HNDL_CLOSE if you want, but it's not needed. It will get added automatically to whatever flags are given to it. You are only ever required to add the TIMER_DATA_HNDL_CLOSE if you want SM to automatically close the handle for you and you are not already using CreateDataTimer.

Oh yeah I get it now.

Originally Posted by psychonic What it does is noted in the function doc above the actual stock (which of course also shows the logic). The function doc is visible on the api site, and there is also a detailed example of it on the wiki. The documentation is only good if you read it.

I know.

ffs you bugged the quote