Save health of entity - Page 2

wicho · 03-02-2015 , 03:14 Re: Save health of entity

i used this https://forums.alliedmods.net/showthread.php?t=79581 but the forward think is different so i think i need to get and set the hp in returnmine and spawn, here:

PHP Code:


			
new Float: iMineHP[33]
new iRemoved[33] 

public ReturnMine(id)
{
    id -= TASK_RELEASE;
    new tgt,body,Float:vo[3],Float:to[3];
    get_user_aiming(id,tgt,body);
    if(!pev_valid(tgt)) return;
    pev(id,pev_origin,vo);
    pev(tgt,pev_origin,to);
    if(get_distance_f(vo,to) > 70.0) return;
    
    new EntityName[32];
    pev(tgt, pev_classname, EntityName, 31);
    if(!equal(EntityName, ENT_CLASS_NAME)) return;
    if(pev(tgt,LASERMINE_OWNER) != id) return;
    RemoveEntity(tgt);

    iMineHP[id] = pev(tgt, pev_health) 
    iRemoved[id] = true

    g_havemine[id] ++;
    g_deployed[id] --;
    
    emit_sound(id, CHAN_ITEM, ENT_SOUND5, VOL_NORM, ATTN_NORM, 0, PITCH_NORM)
    //ShowAmmo(id)

    return;
}

public Spawn( id )
{
    id -= TASK_PLANT
    // motor
    new i_Ent = engfunc(EngFunc_CreateNamedEntity,g_EntMine);
    if(!i_Ent)
    {
        client_print(id,print_chat,"[ZP] Can't Create Entity");
        return PLUGIN_HANDLED_MAIN;
    }
    set_pev(i_Ent,pev_classname,ENT_CLASS_NAME);

    engfunc(EngFunc_SetModel,i_Ent,ENT_MODELS);

    set_pev(i_Ent,pev_solid,SOLID_NOT);
    set_pev(i_Ent,pev_movetype,MOVETYPE_FLY);

    set_pev(i_Ent,pev_frame,0);
    set_pev(i_Ent,pev_body,3);
    set_pev(i_Ent,pev_sequence,TRIPMINE_WORLD);
    set_pev(i_Ent,pev_framerate,0);
    
    set_pev(i_Ent,pev_takedamage,DAMAGE_YES);
    
    set_pev(i_Ent,pev_dmg,100.0);
    set_user_health(i_Ent,get_pcvar_num(g_LHEALTH));
    new Float:vOrigin[3];
    new    Float:vNewOrigin[3],Float:vNormal[3],Float:vTraceDirection[3],
        Float:vTraceEnd[3],Float:vEntAngles[3];
    pev( id, pev_origin, vOrigin );
    velocity_by_aim( id, 128, vTraceDirection );
    xs_vec_add( vTraceDirection, vOrigin, vTraceEnd );
    
    engfunc( EngFunc_TraceLine, vOrigin, vTraceEnd, DONT_IGNORE_MONSTERS, id, 0 );
    
    new Float:fFraction;
    get_tr2( 0, TR_flFraction, fFraction );
    

    // -- We hit something!
    if ( fFraction < 1.0 )
    {
        // -- Save results to be used later.
        get_tr2( 0, TR_vecEndPos, vTraceEnd );
        get_tr2( 0, TR_vecPlaneNormal, vNormal );
    }


    xs_vec_mul_scalar( vNormal, 8.0, vNormal );
    xs_vec_add( vTraceEnd, vNormal, vNewOrigin );

    engfunc(EngFunc_SetSize, i_Ent, Float:{ -4.0, -4.0, -4.0 }, Float:{ 4.0, 4.0, 4.0 } );
    engfunc(EngFunc_SetOrigin, i_Ent, vNewOrigin );

    // -- Rotate tripmine.
    vector_to_angle(vNormal,vEntAngles );
    set_pev(i_Ent,pev_angles,vEntAngles );

    // -- Calculate laser end origin.
    new Float:vBeamEnd[3], Float:vTracedBeamEnd[3];
        
    xs_vec_mul_scalar(vNormal, 8192.0, vNormal );
    xs_vec_add( vNewOrigin, vNormal, vBeamEnd );

    engfunc( EngFunc_TraceLine, vNewOrigin, vBeamEnd, IGNORE_MONSTERS, -1, 0 );

    get_tr2( 0, TR_vecPlaneNormal, vNormal );
    get_tr2( 0, TR_vecEndPos, vTracedBeamEnd );

    // -- Save results to be used later.
    set_pev(i_Ent, LASERMINE_OWNER, id );
    set_pev(i_Ent,LASERMINE_BEAMENDPOINT,vTracedBeamEnd);
    set_pev(i_Ent,LASERMINE_TEAM,2);
    new Float:fCurrTime = get_gametime();

    set_pev(i_Ent,LASERMINE_POWERUP, fCurrTime + 2.5 );
   
    set_pev(i_Ent,LASERMINE_STEP,POWERUP_THINK);
    set_pev(i_Ent,pev_nextthink, fCurrTime + 0.2 );

    PlaySound(i_Ent,POWERUP_SOUND );

    if(iRemoved[id]) 
    { 
       set_pev(i_Ent, pev_health, iMineHP[id]) = iMineHP[id] 
       iRemoved[id] = false 
    } 

    g_deployed[id]++;
    g_havemine[id]--;
    DeleteTask(id);

    //ShowAmmo(id);
    client_print(id, print_chat, "[ZP] LaserMine has been planted, You have %i LaserMines Remaining", g_havemine[id])
    return 1;
}

i only use one mine so i suppose i dont need to use the double array right?

P.S: i cant test now but tell me if it's okay..

**HamletEagle** · 03-02-2015 , 08:39 Re: Save health of entity

Almost fine, but:

PHP Code:


			
set_user_health(i_Ent,get_pcvar_num(g_LHEALTH));

You set default hp, and only after it you check if the mine is removed and set the new health. It doesn't matter much, but I would do as:

PHP Code:


			
if(iRemoved[id]) 
{ 
       set_pev(i_Ent, pev_health, iMineHP[id])
       iRemoved[id] = false 
} 
else
{
       set_user_health(i_Ent,get_pcvar_num(g_LHEALTH));
}

Notice that I removed =iMineHP[id] from your code, it's wrong.

wicho · 03-02-2015 , 10:55 Re: Save health of entity

u mean this?

PHP Code:


			
public Spawn( id )
{
    id -= TASK_PLANT
    // motor
    new i_Ent = engfunc(EngFunc_CreateNamedEntity,g_EntMine);
    if(!i_Ent)
    {
        client_print(id,print_chat,"[ZP] Can't Create Entity");
        return PLUGIN_HANDLED_MAIN;
    }
    set_pev(i_Ent,pev_classname,ENT_CLASS_NAME);

    engfunc(EngFunc_SetModel,i_Ent,ENT_MODELS);

    set_pev(i_Ent,pev_solid,SOLID_NOT);
    set_pev(i_Ent,pev_movetype,MOVETYPE_FLY);

    set_pev(i_Ent,pev_frame,0);
    set_pev(i_Ent,pev_body,3);
    set_pev(i_Ent,pev_sequence,TRIPMINE_WORLD);
    set_pev(i_Ent,pev_framerate,0);
    
    set_pev(i_Ent,pev_takedamage,DAMAGE_YES);
    
    set_pev(i_Ent,pev_dmg,100.0);

    if(iRemoved[id]) 
    { 
       set_pev(i_Ent, pev_health, iMineHP[id])
       iRemoved[id] = false 
    } 
     else
    {
       set_user_health(i_Ent,get_pcvar_num(g_LHEALTH));
    } 

    new Float:vOrigin[3];
    new    Float:vNewOrigin[3],Float:vNormal[3],Float:vTraceDirection[3],
        Float:vTraceEnd[3],Float:vEntAngles[3];
    pev( id, pev_origin, vOrigin );
    velocity_by_aim( id, 128, vTraceDirection );
    xs_vec_add( vTraceDirection, vOrigin, vTraceEnd );
    
    engfunc( EngFunc_TraceLine, vOrigin, vTraceEnd, DONT_IGNORE_MONSTERS, id, 0 );
    
    new Float:fFraction;
    get_tr2( 0, TR_flFraction, fFraction );
    

    // -- We hit something!
    if ( fFraction < 1.0 )
    {
        // -- Save results to be used later.
        get_tr2( 0, TR_vecEndPos, vTraceEnd );
        get_tr2( 0, TR_vecPlaneNormal, vNormal );
    }


    xs_vec_mul_scalar( vNormal, 8.0, vNormal );
    xs_vec_add( vTraceEnd, vNormal, vNewOrigin );

    engfunc(EngFunc_SetSize, i_Ent, Float:{ -4.0, -4.0, -4.0 }, Float:{ 4.0, 4.0, 4.0 } );
    engfunc(EngFunc_SetOrigin, i_Ent, vNewOrigin );

    // -- Rotate tripmine.
    vector_to_angle(vNormal,vEntAngles );
    set_pev(i_Ent,pev_angles,vEntAngles );

    // -- Calculate laser end origin.
    new Float:vBeamEnd[3], Float:vTracedBeamEnd[3];
        
    xs_vec_mul_scalar(vNormal, 8192.0, vNormal );
    xs_vec_add( vNewOrigin, vNormal, vBeamEnd );

    engfunc( EngFunc_TraceLine, vNewOrigin, vBeamEnd, IGNORE_MONSTERS, -1, 0 );

    get_tr2( 0, TR_vecPlaneNormal, vNormal );
    get_tr2( 0, TR_vecEndPos, vTracedBeamEnd );

    // -- Save results to be used later.
    set_pev(i_Ent, LASERMINE_OWNER, id );
    set_pev(i_Ent,LASERMINE_BEAMENDPOINT,vTracedBeamEnd);
    set_pev(i_Ent,LASERMINE_TEAM,2);
    new Float:fCurrTime = get_gametime();

    set_pev(i_Ent,LASERMINE_POWERUP, fCurrTime + 2.5 );
   
    set_pev(i_Ent,LASERMINE_STEP,POWERUP_THINK);
    set_pev(i_Ent,pev_nextthink, fCurrTime + 0.2 );

    PlaySound(i_Ent,POWERUP_SOUND );

    g_deployed[id]++;
    g_havemine[id]--;
    DeleteTask(id);

    //ShowAmmo(id);
    client_print(id, print_chat, "[ZP] LaserMine has been planted, You have %i LaserMines Remaining", g_havemine[id])
    return 1;
}

**HamletEagle** · 03-02-2015 , 11:03 Re: Save health of entity

Yes.

wicho · 03-02-2015 , 11:48 Re: Save health of entity

i have tag mismatch here iMineHP[id] = pev(tgt, pev_health) I do not understand if it is a float..

**HamletEagle** · 03-02-2015 , 12:12 Re: Save health of entity

This is not the right way of doing it, you should read again my post: https://forums.alliedmods.net/showpo...13&postcount=2

RateX · 03-02-2015 , 12:16 Re: Save health of entity

Change it to:

PHP Code:


			
pev(tgt, pev_health, iMineHp[id])

Unlike engine, fakemeta way of retrieving value use byref for all value types except interger.

wicho · 03-02-2015 , 14:27 Re: Save health of entity

i tested and for some reason when i plant again says that i dont have the mine, why?

appears this error:

L 03/02/2015 - 11:21:09: [FAKEMETA] Invalid entity
L 03/02/2015 - 11:21:09: [AMXX] Displaying debug trace (plugin "zp_extra_lasermine.amxx", version "1.4")
L 03/02/2015 - 11:21:09: [AMXX] Run time error 10: native error (native "pev")
L 03/02/2015 - 11:21:09: [AMXX] [0] Untitled.sma::ReturnMine (line 424)

this line:

PHP Code:


			
pev(tgt, pev_health, iMineHP[id])

but why invalid, if it already checked if its valid or not..

PHP Code:


			
public ReturnMine(id)

{

    id -= TASK_RELEASE;

    new tgt,body,Float:vo[3],Float:to[3];

    get_user_aiming(id,tgt,body);

    if(!pev_valid(tgt)) return;

    pev(id,pev_origin,vo);

    pev(tgt,pev_origin,to);

    if(get_distance_f(vo,to) > 70.0) return;

    

    new EntityName[32];

    pev(tgt, pev_classname, EntityName, 31);

    if(!equal(EntityName, ENT_CLASS_NAME)) return;

    if(pev(tgt,LASERMINE_OWNER) != id) return;

    RemoveEntity(tgt);

    

    pev(tgt, pev_health, iMineHP[id]) 

         iRemoved[id] = true 



    g_havemine[id] ++;

    g_deployed[id] --;

    emit_sound(id, CHAN_ITEM, ENT_SOUND5, VOL_NORM, ATTN_NORM, 0, PITCH_NORM)

    //ShowAmmo(id)



    return;

}

RateX · 03-02-2015 , 19:57 Re: Save health of entity

Dude, just look at the line above it -.-

wicho · 03-03-2015 , 01:34 Re: Save health of entity

Ya i know i already fixed i forgot to edit the post, thx to all..