Raised This Month: $32 Target: $400
 8% 

DHooks (Dynamic Hooks - Dev Preview)


Post New Thread Reply   
 
Thread Tools Display Modes
Peace-Maker
SourceMod Plugin Approver
Join Date: Aug 2008
Location: Germany
Old 07-22-2019 , 16:31   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #691

Yeah, same for changing return strings. The current hack to not leak memory doesn't seem to work anymore.
__________________
Peace-Maker is offline
Peace-Maker
SourceMod Plugin Approver
Join Date: Aug 2008
Location: Germany
Old 08-03-2019 , 13:46   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #692

I've put up a new version which fixes changing charptr (and vectorptr) parameters and return values. I've also added the fastcall calling convention to the list, to make it easier to work with those functions, even though you could have set the register locations of the first two arguments yourself before.
Thanks to Silvers for a nice test case!
__________________
Peace-Maker is offline
Silvers
SourceMod Plugin Approver
Join Date: Aug 2010
Location: SpaceX
Old 08-03-2019 , 17:49   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #693

omg it's here
__________________
Silvers is offline
MAGNAT2645
Senior Member
Join Date: Nov 2015
Location: AlliedMods.net
Old 08-16-2019 , 15:58   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #694

Server crashed only once (weird...), I will continue testing.

I was running (before crash) only one plugin (FireBulletsFix) that requires DHooks.

https://crash.limetech.org/j2hzext2koxz

I have latest DHooks with Detour 8.
Maybe somebody should look at this?
__________________
MAGNAT2645 is offline
paulo_crash
AlliedModders Donor
Join Date: May 2016
Location: Brazil
Old 08-16-2019 , 20:35   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #695

Quote:
Originally Posted by MAGNAT2645 View Post
Server crashed only once (weird...), I will continue testing.

I was running (before crash) only one plugin (FireBulletsFix) that requires DHooks.

https://crash.limetech.org/j2hzext2koxz

I have latest DHooks with Detour 8.
Maybe somebody should look at this?
Code:
This plugin needs dhooks in order to work.
Please use this version of dhooks if you don't want your server to crash https://github.com/XutaxKamay/dhooks/releases, 
I'm waiting for the author (Drifter) of DHooks to fix this issue.
https://github.com/XutaxKamay/firebu.../master/README

https://github.com/XutaxKamay/dhooks/releases
paulo_crash is offline
MAGNAT2645
Senior Member
Join Date: Nov 2015
Location: AlliedMods.net
Old 08-17-2019 , 04:14   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #696

I know but i thought DHooks with Detour has this fix applied.
__________________

Last edited by MAGNAT2645; 08-17-2019 at 09:36.
MAGNAT2645 is offline
paulo_crash
AlliedModders Donor
Join Date: May 2016
Location: Brazil
Old 08-17-2019 , 13:30   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #697

Quote:
Originally Posted by MAGNAT2645 View Post
I know but i thought DHooks with Detour has this fix applied.
I see, then in case I would have to check with the author of DHooks if he already made these changes to his project on GitHub, so I saw the author of the plugin you mentioned had already contacted him for this.
paulo_crash is offline
HarryPotter
Veteran Member
Join Date: Sep 2017
Location: Taiwan, Asia
Old 08-19-2019 , 04:43   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #698

Quote:
Originally Posted by Peace-Maker View Post
Experimental dynamic detour support

2.2.0-detours8 - 03.08.2019:
  • Add |fastcall| calling convention support
  • Fix changing of charptr and vectorptr returns and parameters (thanks Silvers)
Peace-Maker, sorry to bother you
Cloud you make your dhooks.ext update and work well with this plugin?
firebulletsfix.smx by Xutax_Kamay: https://forums.alliedmods.net/showthread.php?t=315405

Xutax_Kamay's dhooks.ext doesn't have DHookCreateFromConf
and your dhooks.ext crashes when loading firebulletsfix.smx
__________________

Last edited by HarryPotter; 08-19-2019 at 04:49.
HarryPotter is offline
Peace-Maker
SourceMod Plugin Approver
Join Date: Aug 2008
Location: Germany
Old 08-19-2019 , 11:27   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #699

Oh, sorry. I forgot to merge the changes Drifter made before building. I've put up a new version which includes those changes and thus fixes changing vector returns in virtual hooks.
__________________
Peace-Maker is offline
HarryPotter
Veteran Member
Join Date: Sep 2017
Location: Taiwan, Asia
Old 08-20-2019 , 02:24   Re: DHooks (Dynamic Hooks - Dev Preview)
Reply With Quote #700

Quote:
Originally Posted by Peace-Maker View Post
Oh, sorry. I forgot to merge the changes Drifter made before building. I've put up a new version which includes those changes and thus fixes changing vector returns in virtual hooks.
thanks, that's so quick
windows/linux both work with firebulletsfix.smx
__________________

Last edited by HarryPotter; 08-20-2019 at 02:24.
HarryPotter is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 14:26.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode