Vault Save Problems

siriusmd99 · **Author**

Hello, i have this plugin:

PHP Code:


			
#include <amxmodx>
#include <amxmisc>
#include <nvault>
#include <nvault_util>

#define MAX_BUFFER_LENGTH       2047
#define MOTD_HOURS_NAME "Hours Admins"

new const NVAULT_NAME[] = "Hours_Admins"

new g_sBuffer[ MAX_BUFFER_LENGTH + 1] = "";

native get_auth_type(id);

public plugin_init()
{
    register_plugin("Hours Admins", "1.0", "siriusmd99")
    
    register_clcmd("say /time", "cmdHoursAdmins", ADMIN_RCON)
    register_event("HLTV", "hook_NewRound", "a", "1=0", "2=0")
    
    g_sBuffer[0] = 0;
    
    new iVault = nvault_open( NVAULT_NAME );
    
    if ( iVault == INVALID_HANDLE )
    {
        new fail_msg[64]
        formatex(fail_msg, charsmax(fail_msg), "Cannot open nVault file ^"%s^".", NVAULT_NAME)
        set_fail_state( fail_msg )
    }
    else
    {
        nvault_close( iVault )
    }
}

public hook_NewRound()
{
    new month[3], lastmonth[3];
    new day[4], lastday[4];
    
    get_time("%m",month,charsmax(month))
    get_time("%j",day,charsmax(day))
    
    get_vaultdata("lastMonthHours", lastmonth, charsmax(lastmonth));
    
    if( !lastmonth[0] )
    {
        set_vaultdata("lastMonthHours", month);
        set_vaultdata("lastDayHours", day);
        return;
    }
    
    new iVault = nvault_util_open( NVAULT_NAME );
    
    if( !equal(lastmonth, month))
    {
        set_vaultdata("lastMonthHours", month);
        nvault_util_close( iVault)
        
        iVault = nvault_open( NVAULT_NAME )
        nvault_prune(iVault, 0, get_systime() + 1); 
        nvault_set( iVault , month , day );
        nvault_close( iVault);         
    }
    else
    {
        get_vaultdata("lastDayHours", lastday, charsmax(lastday));
    
        if( !equal(lastday, day))
        {
            set_vaultdata("lastDayHours", day);
            
            new iKey[35];
            new iDays[4]
            new iPos;
            
            new isecVault = nvault_open( NVAULT_NAME )
        
            for (new i; i < nvault_util_count( iVault ); i++)
            {
                
                iPos = nvault_util_read( iVault , iPos , iKey , charsmax( iKey ) , iDays , charsmax( iDays ) );
                
                iDays[0] = 0;
                
                nvault_set( isecVault , iKey , iDays);
            }
            
            nvault_close( isecVault);     
        }
        
        nvault_util_close(iVault)
    }
}

public client_disconnect(id)
{
    if(is_user_admin(id))
    {
        new data[35], nv_data[4];
        new iAuthType = get_auth_type(id);
        
        switch(iAuthType)
        {
            case 1:
                get_user_name(id, data, charsmax(data))
            case 2:
                get_user_ip(id, data, charsmax(data), 1)
            case 3:
                get_user_authid(id, data, charsmax(data))
        }
        
        new iVault = nvault_open( NVAULT_NAME );
        
        new tmp_time = get_user_time(id);
        nv_data[0] += tmp_time;
        nv_data[1] += tmp_time;
        nv_data[2] = iAuthType;
        
        nvault_set( iVault , data , nv_data );
        
        nvault_close( iVault );
    }
}


public cmdHoursAdmins(id, level, cid)
{
    if(!cmd_access(id, level, cid, 1))
        return PLUGIN_HANDLED
    
    format_top15(g_sBuffer)
    show_motd(id, g_sBuffer, MOTD_HOURS_NAME)
    
    return PLUGIN_HANDLED
}


format_top15(sBuffer[MAX_BUFFER_LENGTH + 1])
{
new iKey[32], iHours[4];
new iLen = 0;
new szHours[12], szmHours[12]

iLen = format( sBuffer, MAX_BUFFER_LENGTH,
"<head><META http-equiv=Content-Type content='text/html ;charset=UTF-8'></head><style>body{color:#FFCC99;background-color:black;margin-top:5}.A{background-color:#310000}.B{background-color:#630000}td{font-size:14px}</style><center><b><font size=4>Admins Time</b><table width=500>" )
iLen += format( sBuffer[iLen], MAX_BUFFER_LENGTH - iLen,
"<tr bgcolor=#9C0000><td>%s<td>%s<td>%s<td>%s",
"#", "Admin Name", "Today", "This Month")

new iVault = nvault_util_open( NVAULT_NAME ) 
new iPos;

for (new i; i < (nvault_util_count( iVault )) && MAX_BUFFER_LENGTH - iLen > 0; i++)
{
    iPos = nvault_util_read( iVault , iPos , iKey , charsmax( iKey ) , iHours , charsmax( iHours ) );
    
    if(iHours[2] > 1)
    {
        new plid = find_player( iHours[2] == 2 ? "d" : "c", iKey)
        if(plid)
        {
            get_user_name(plid, iKey, charsmax(iKey))
        }
        
        new tmp_curtime = get_user_time(plid)
        
        iHours[0] += tmp_curtime
        iHours[1] += tmp_curtime
    }
    
    iHours[0] /= 60;
    iHours[1] /= 60;
    
    if(iHours[0] < 60)
    {
        formatex(szHours, charsmax(szHours), "%d%s", iHours[0], "m")
    }
    else
    {
        formatex(szHours, charsmax(szHours), "%d%s %d%s", iHours[0] / 60, "h", iHours[0] % 60, "m")
    }
    
    if(iHours[1] < 60)
    {
        formatex(szmHours, charsmax(szmHours), "%d%s", iHours[1], "m")
    }
    else
    {
        formatex(szmHours, charsmax(szmHours), "%d%s %d%s", iHours[1] / 60, "h", iHours[1] % 60, "m")
    }
    
    iLen += format(sBuffer[iLen], MAX_BUFFER_LENGTH - iLen, "<tr class=%s><td>%d<td>%s<td>%s<td>%s", "B", i + 1, iKey, szHours, szmHours)
}
nvault_util_close( iVault )
}

Update.

I made apart date and time which are used to prune nvault keys.

I also change systime to get_user_time, which anyway has no sense.

So it's not working anyway.

I don't understand why.
I stay on server 4 minutes, i disconnect and after i reconnect and check my time , it shows 2 minutes

How the hell this can happen?

wickedd · 10-12-2016 , 15:40 Re: Vault Save Problems

Why are you doing this?

PHP Code:


			
g_time[id] = get_systime()

If anything it should be

PHP Code:


			
g_time[id] = get_user_time( id )

PHP Code:


			
new tmp_time = get_systime() - g_time[id];

PHP Code:


			
new tmp_time = get_systime() - get_user_time( id );

siriusmd99 · 10-12-2016 , 16:22 Re: Vault Save Problems

g_time[id] is systime when player connected to server.

And i do systime - g_time to calculate seconds left from connect to disconnect.

The problem is not in the time because it adds properly.
Problem is in nvault. It doesnt save properly.

Ant1Lamer · 10-12-2016 , 17:53 Re: Vault Save Problems

Before 3 years i want same plugin and fr make this if you think will this help

Is not with navault but maybe you reworked аs you like it

Code:

#include <amxmodx>
#include <amxmisc>

#define PLUGIN "Ataraa Maikke"
#define VERSION "1.0"
#define AUTHOR "Betchualeng Arnaikem"

new logdir[] = "addons/amxmodx/logs/AdminConnects/";

public plugin_init() 
{
    register_plugin(PLUGIN, VERSION, AUTHOR)
}

public client_disconnect(id) 
{
    if(is_user_admin(id)) 
    {
        new filelog[128]
        
        new szName[32];
        get_user_name(id, szName, charsmax(szName));
        CleanName(szName, charsmax(szName));
        
        formatex(filelog, charsmax(filelog), "%s%s.txt", logdir, szName)
        if(!file_exists(filelog)) 
            write_file(filelog, "------------------------------------------------------------------")
        
        new Log[300], ip[32], timeng[32], nickname[42]
        get_time("%m/%d/%Y - %H:%M:%S", timeng,31)
        get_user_ip(id, ip, charsmax(ip))
        get_user_name(id, nickname, charsmax(nickname))
        formatex(Log, charsmax(Log), "Disconnect admin: %s (%s) ^nDisconection time: %s ^n", nickname, ip, timeng)
        write_file(filelog,Log)
    }
}

public client_putinserver(id) 
{    
    if(is_user_admin(id))
    {
        set_task(90.0,"joinwr",id);
    }
}

public joinwr(id) 
{
    if(is_user_connected(id)) 
    {
        new filelog[128]
        
        new szName[32];
        get_user_name(id, szName, charsmax(szName));
        CleanName(szName, charsmax(szName));

        formatex(filelog, charsmax(filelog), "%s%s.txt", logdir, szName)
        if(!file_exists(filelog)) 
            write_file(filelog, "------------------------------------------------------------------")
        
        new Log[300], ip[32], timeng[32], nickname[42], team[32]
        get_time("%m/%d/%Y - %H:%M:%S", timeng,31)
        get_user_ip(id, ip, charsmax(ip))
        get_user_name(id, nickname, charsmax(nickname))
        get_user_team(id, team, charsmax(team))
        formatex(Log, charsmax(Log), "Admin %s (%s) join %s ^nJoin time: %s ^n", nickname, ip, team, timeng)    
        write_file(filelog,Log)
    } 
}

CleanName(szName[], len)
{
    static chars[][] = 
    {
        "?",
        "/",
        "\",
        ">",
        "<",
        "*",
        "|",
        ":",
        "^""
    }
    
    for(new i; i < sizeof(chars); i++)
    replace_all(szName, len, chars[i], "");
}

siriusmd99 · 10-13-2016 , 07:50 Re: Vault Save Problems

This is scripting forum, not request.
I want to fix my plugin.

I mean it looks that code is ok but it doesnt save properly , maybe it's nvault or nvault_util issue?

I used different handlers when working with both utilities , like in the tutorial.

siriusmd99 · 10-13-2016 , 08:56 Re: Vault Save Problems

Update.

I made apart date and time which are used to prune nvault keys.

I also changed systime to get_user_time, which anyway has no sense.

So it's not working anyway.

I don't understand why.
I stay on server 4 minutes, i disconnect and after i reconnect and check my time , it shows 2 minutes

How the hell this can happen?

PHP Code:


			
#include <amxmodx>
#include <amxmisc>
#include <nvault>
#include <nvault_util>

#define MAX_BUFFER_LENGTH       2047
#define MOTD_HOURS_NAME "Hours Admins"

new const NVAULT_NAME[] = "Hours_Admins"

new g_sBuffer[ MAX_BUFFER_LENGTH + 1] = "";

native get_auth_type(id);

public plugin_init()
{
    register_plugin("Hours Admins", "1.0", "siriusmd99")
    
    register_clcmd("say /time", "cmdHoursAdmins", ADMIN_RCON)
    register_event("HLTV", "hook_NewRound", "a", "1=0", "2=0")
    
    g_sBuffer[0] = 0;
    
    new iVault = nvault_open( NVAULT_NAME );
    
    if ( iVault == INVALID_HANDLE )
    {
        new fail_msg[64]
        formatex(fail_msg, charsmax(fail_msg), "Cannot open nVault file ^"%s^".", NVAULT_NAME)
        set_fail_state( fail_msg )
    }
    else
    {
        nvault_close( iVault )
    }
}

public hook_NewRound()
{
    new month[3], lastmonth[3];
    new day[4], lastday[4];
    
    get_time("%m",month,charsmax(month))
    get_time("%j",day,charsmax(day))
    
    get_vaultdata("lastMonthHours", lastmonth, charsmax(lastmonth));
    
    if( !lastmonth[0] )
    {
        set_vaultdata("lastMonthHours", month);
        set_vaultdata("lastDayHours", day);
        return;
    }
    
    new iVault = nvault_util_open( NVAULT_NAME );
    
    if( !equal(lastmonth, month))
    {
        set_vaultdata("lastMonthHours", month);
        nvault_util_close( iVault)
        
        iVault = nvault_open( NVAULT_NAME )
        nvault_prune(iVault, 0, get_systime() + 1); 
        nvault_set( iVault , month , day );
        nvault_close( iVault);         
    }
    else
    {
        get_vaultdata("lastDayHours", lastday, charsmax(lastday));
    
        if( !equal(lastday, day))
        {
            set_vaultdata("lastDayHours", day);
            
            new iKey[35];
            new iDays[4]
            new iPos;
            
            new isecVault = nvault_open( NVAULT_NAME )
        
            for (new i; i < nvault_util_count( iVault ); i++)
            {
                
                iPos = nvault_util_read( iVault , iPos , iKey , charsmax( iKey ) , iDays , charsmax( iDays ) );
                
                iDays[0] = 0;
                
                nvault_set( isecVault , iKey , iDays);
            }
            
            nvault_close( isecVault);     
        }
        
        nvault_util_close(iVault)
    }
}

public client_disconnect(id)
{
    if(is_user_admin(id))
    {
        new data[35], nv_data[4];
        new iAuthType = get_auth_type(id);
        
        switch(iAuthType)
        {
            case 1:
                get_user_name(id, data, charsmax(data))
            case 2:
                get_user_ip(id, data, charsmax(data), 1)
            case 3:
                get_user_authid(id, data, charsmax(data))
        }
        
        new iVault = nvault_open( NVAULT_NAME );
        
        new tmp_time = get_user_time(id);
        nv_data[0] += tmp_time;
        nv_data[1] += tmp_time;
        nv_data[2] = iAuthType;
        
        nvault_set( iVault , data , nv_data );
        
        nvault_close( iVault );
    }
}


public cmdHoursAdmins(id, level, cid)
{
    if(!cmd_access(id, level, cid, 1))
        return PLUGIN_HANDLED
    
    format_top15(g_sBuffer)
    show_motd(id, g_sBuffer, MOTD_HOURS_NAME)
    
    return PLUGIN_HANDLED
}


format_top15(sBuffer[MAX_BUFFER_LENGTH + 1])
{
new iKey[32], iHours[4];
new iLen = 0;
new szHours[12], szmHours[12]

iLen = format( sBuffer, MAX_BUFFER_LENGTH,
"<head><META http-equiv=Content-Type content='text/html ;charset=UTF-8'></head><style>body{color:#FFCC99;background-color:black;margin-top:5}.A{background-color:#310000}.B{background-color:#630000}td{font-size:14px}</style><center><b><font size=4>Admins Time</b><table width=500>" )
iLen += format( sBuffer[iLen], MAX_BUFFER_LENGTH - iLen,
"<tr bgcolor=#9C0000><td>%s<td>%s<td>%s<td>%s",
"#", "Admin Name", "Today", "This Month")

new iVault = nvault_util_open( NVAULT_NAME ) 
new iPos;

for (new i; i < (nvault_util_count( iVault )) && MAX_BUFFER_LENGTH - iLen > 0; i++)
{
    iPos = nvault_util_read( iVault , iPos , iKey , charsmax( iKey ) , iHours , charsmax( iHours ) );
    
    if(iHours[2] > 1)
    {
        new plid = find_player( iHours[2] == 2 ? "d" : "c", iKey)
        if(plid)
        {
            get_user_name(plid, iKey, charsmax(iKey))
        }
        
        new tmp_curtime = get_user_time(plid)
        
        iHours[0] += tmp_curtime
        iHours[1] += tmp_curtime
    }
    
    iHours[0] /= 60;
    iHours[1] /= 60;
    
    if(iHours[0] < 60)
    {
        formatex(szHours, charsmax(szHours), "%d%s", iHours[0], "m")
    }
    else
    {
        formatex(szHours, charsmax(szHours), "%d%s %d%s", iHours[0] / 60, "h", iHours[0] % 60, "m")
    }
    
    if(iHours[1] < 60)
    {
        formatex(szmHours, charsmax(szmHours), "%d%s", iHours[1], "m")
    }
    else
    {
        formatex(szmHours, charsmax(szmHours), "%d%s %d%s", iHours[1] / 60, "h", iHours[1] % 60, "m")
    }
    
    iLen += format(sBuffer[iLen], MAX_BUFFER_LENGTH - iLen, "<tr class=%s><td>%d<td>%s<td>%s<td>%s", "B", i + 1, iKey, szHours, szmHours)
}
nvault_util_close( iVault )
}

Ant1Lamer · 10-13-2016 , 13:14 Re: Vault Save Problems

try

Code:

nvault_prune(iVault, 0, get_systime() + 1);

to

Code:

nvault_prune(iVault, 0, get_systime() * 60);

siriusmd99 · 10-13-2016 , 14:15 Re: Vault Save Problems

Quote:

Originally Posted by Ant1Lamer

try

Code:

nvault_prune(iVault, 0, get_systime() + 1);

to

Code:

nvault_prune(iVault, 0, get_systime() * 60);

It has no sense, this just deletes all entries from nvault once in a month.

I solved my problem myself.
The problem was that I didn't use correctly get_vaultdata native.

When i get a string(or array) i must use charsmax to define the length
so it's something like this :

PHP Code:


			
get_vaultdata("lastMonthOre", lastmonth);

PHP Code:


			
get_vaultdata("lastMonthOre", lastmonth, charsmax(lastmonth));

Problem Solved.

siriusmd99 · 10-13-2016 , 17:30 Re: Vault Save Problems

Oh my godness.
I thought problem was solved but new problem.

It works normal and after some reconnections it's starting to set negative values or for example if I saved to nvault 135 seconds after reconnect it gets only 20 or -140 , like random values.

Is it something out of maximum possible value for nvault?

After 134 it goes to negative , like it reaches maximum limit or something. I don't understand.

This is the code:

PHP Code:


			
#include <amxmodx>
#include <amxmisc>
#include <nvault>
#include <nvault_util>

#define MAX_BUFFER_LENGTH       2047
#define MOTD_ORE_NAME "Time Admins"

new const NVAULT_NAME[] = "Time_Admins"

new g_sBuffer[ MAX_BUFFER_LENGTH + 1] = "";

native get_auth_type(id);

public plugin_init()
{
    register_plugin("Time Admins", "1.0", "siriusmd99")
    
    register_clcmd("say /time", "cmdTimeAdmins", ADMIN_RCON)
    register_event("HLTV", "hook_NewRound", "a", "1=0", "2=0")
    
    g_sBuffer[0] = 0;
    
    new iVault = nvault_open( NVAULT_NAME );
    
    if ( iVault == INVALID_HANDLE )
    {
        new fail_msg[64]
        formatex(fail_msg, charsmax(fail_msg), "Cannot open nVault file ^"%s^".", NVAULT_NAME)
        set_fail_state( fail_msg )
    }
    else
    {
        nvault_close( iVault )
    }
}

public hook_NewRound()
{
    new month[3], lastmonth[3];
    new day[4], lastday[4];
    
    get_time("%m",month,charsmax(month))
    get_time("%j",day,charsmax(day))
    
    get_vaultdata("lastMonthOre", lastmonth, charsmax(lastmonth));
    
    if( !lastmonth[0] )
    {
        set_vaultdata("lastMonthTime", month);
        set_vaultdata("lastDayTime", day);
        return;
    }
    
    new iVault = nvault_util_open( NVAULT_NAME );
    
    if( !equal(lastmonth, month))
    {
        set_vaultdata("lastMonthTime", month);
        nvault_util_close( iVault)
        
        iVault = nvault_open( NVAULT_NAME )
        nvault_prune(iVault, 0, get_systime() + 1); 
        nvault_set( iVault , month , day );
        nvault_close( iVault);         
    }
    else
    {
        get_vaultdata("lastDayTime", lastday, charsmax(lastday));
        
        if( !equal(lastday, day))
        {
    
            set_vaultdata("lastDayTime", day);
            
            new iKey[35];
            new iDays[4]
            new iPos;
            
            new isecVault = nvault_open( NVAULT_NAME )
            
            for (new i; i < nvault_util_count( iVault ); i++)
            {
                
                iPos = nvault_util_read( iVault , iPos , iKey , charsmax( iKey ) , iDays , charsmax( iDays ) );
                
                iDays[0] = 0;
                
                nvault_set( isecVault , iKey , iDays);
            }
            
            nvault_close( isecVault);     
        }
        
        nvault_util_close(iVault)
    }
}

public client_disconnect(id)
{
    if(is_user_admin(id))
    {
        new data[35], nv_data[4];
        new iAuthType = get_auth_type(id);
        
        switch(iAuthType)
        {
            case 1: get_user_name(id, data, charsmax(data))
            case 2:    get_user_ip(id, data, charsmax(data), 1)
            case 3: get_user_authid(id, data, charsmax(data))
        }
        
        new iVault = nvault_open( NVAULT_NAME );
        
        nvault_get( iVault , data, nv_data, charsmax(nv_data) );
        
        log_amx("get %d seconds , %d seconds", nv_data[0], nv_data[1])
        
        new tmp_time = get_user_time(id);
        nv_data[0] += tmp_time;
        nv_data[1] += tmp_time;
        nv_data[2] = iAuthType;
        
        nvault_set( iVault , data , nv_data );
        
        log_amx("set %d seconds, set %d seconds", nv_data[0], nv_data[1])
        
        nvault_close( iVault );
    }
}


public cmdOreAdmins(id, level, cid)
{
    if(!cmd_access(id, level, cid, 1))
    return PLUGIN_HANDLED
    
    format_top15(g_sBuffer)
    show_motd(id, g_sBuffer, MOTD_ORE_NAME)
    
    return PLUGIN_HANDLED
}


format_top15(sBuffer[MAX_BUFFER_LENGTH + 1])
{
    new iKey[32], iSeconds[4];
    new iLen = 0;
    new szHours[12], szmHours[12]

    iLen = format( sBuffer, MAX_BUFFER_LENGTH,
    "<head><META http-equiv=Content-Type content='text/html ;charset=UTF-8'></head><style>body{color:#FFCC99;background-color:black;margin-top:5}.A{background-color:#310000}.B{background-color:#630000}td{font-size:14px}</style><center><b><font size=4>Admins Time</b><table width=500>" )
    iLen += format( sBuffer[iLen], MAX_BUFFER_LENGTH - iLen,
    "<tr bgcolor=#9C0000><td>%s<td>%s<td>%s<td>%s",
    "#", "Admin Name", "Today", "This Month")

    new iVault = nvault_util_open( NVAULT_NAME ) 
    new iPos;

    for (new i; i < (nvault_util_count( iVault )) && MAX_BUFFER_LENGTH - iLen > 0; i++)
    {
        iPos = nvault_util_read( iVault , iPos , iKey , charsmax( iKey ) , iSeconds , charsmax( iSeconds ) );
    
        if(iSeconds[2] > 1)
        {
            new plid = find_player( iSeconds[2] == 2 ? "d" : "c", iKey)
            if(plid)
            {
               get_user_name(plid, iKey, charsmax(iKey))
            }
        
            new tmp_curtime = get_user_time(plid)
        
            iSeconds[0] += tmp_curtime
            iSeconds[1] += tmp_curtime
        }
    
        iSeconds[0] /= 60; //Converting seconds to minutes
        iSeconds[1] /= 60;
    
        if(iSeconds[0] < 60)
        {
            formatex(szHours, charsmax(szHours), "%d%s", iSeconds[0], "m")
        } 
        else
        {
            formatex(szHours, charsmax(szHours), "%d%s %d%s", iSeconds[0] / 60, "h", iSeconds[0] % 60, "m")
        }
    
        if(iSeconds[1] < 60)
        {
            formatex(szmHours, charsmax(szmHours), "%d%s", iSeconds[1], "m")
        }
        else
        {
            formatex(szmHours, charsmax(szmHours), "%d%s %d%s", iSeconds[1] / 60, "h", iSeconds[1] % 60, "m")
        }
    
        iLen += format(sBuffer[iLen], MAX_BUFFER_LENGTH - iLen, "<tr class=%s><td>%d<td>%s<td>%s<td>%s", "B", i + 1, iKey, szHours, szmHours)
    }
    
    nvault_util_close( iVault )
}

I put log and it shows on admin disconnect this:

Set 130 seconds and 130 seconds (daily and monthly)

After i reconnect and disconnect back it shows:

get -40 seconds and -40 seconds.

How is this possible?

I saved 130 seconds and when i get the value from nvault it's -40?

I looked and checked the code and there is nothing in code that could change value from 130 to -40 like this.

Thanks for help in advance.

Craxor · 10-13-2016 , 17:39 Re: Vault Save Problems

Just offtopic, why you would want to use vault and nvault in the same plugin?

Edit: Also... Nvault util, oh my god..

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode