[Solved] AmxModX 1.8.3-dev+4608: Server, Game hang on "quit" command.

yokomo · **Author**

Hi, i think this is critical, everytime i use "quit" command to close hlds or listen server it hang with error message. Tested on Windows OS only, not sure in Linux.

[IMG]http://s12.************/q0onz6gpp/amxx_error.png[/IMG]

as you can see the cause is by amxmodx_mm.dll itself.

More details Windows OS

End of bug report

**Arkshine** · *Last edited by Arkshine; 02-12-2015 at 04:50.*

Well, tried under linux, and I can't reproduce.

Under windows, I've got a weird behavior, like several seconds after I type quit, I have a crash message but I can't do something since hlds is already closed. It doesn't happen always. Really weird.

Can try this one to see. Forgot to free memory of stuffs related to cvar hooking on amxx shutdown, but it's probably not the issue. Snce it happens all the time for you, it should be fast to see.

EDIT: it will probably won't help since I actually free stuffs, in another place. But still, try it just in case.

yokomo

Quote:

Originally Posted by Arkshine

Well, tried under linux, and I can't reproduce.

Under windows, I've got a weird behavior, like several seconds after I type quit, I have a crash message but I can't do something since hlds is already closed. It doesn't happen always. Really weird.

Can try this one to see. Forgot to free memory of stuffs related to cvar hooking on amxx shutdown, but it's probably not the issue. Snce it happens all the time for you, it should be fast to see.

EDIT: it will probably won't help since I actually free stuffs, in another place. But still, try it just in case.

Still got the same error, but when i use an older dev version it not hang at all.

Old dev build:

Code:

] amxx version
AMX Mod X 1.8.3-dev+4518 (http://www.amxmodx.org)
Authors:
    David "BAILOPAN" Anderson, Pavol "PM OnoTo" Marko
    Felix "SniperBeamer" Geyer, Jonny "Got His Gun" Bergstrom
    Lukasz "SidLuke" Wlasinski, Christian "Basic-Master" Hammacher
    Borja "faluco" Ferrer, Scott "DS" Ehlert
Compiled: Jan 11 2015 15:53:45
Built from: https://github.com/alliedmodders/amxmodx/commit/328c3d7Build ID: 4518:328c3d7Core mode: JIT+ASM32

Please investigate more

**Arkshine** · *Last edited by Arkshine; 02-12-2015 at 08:15.*

It's probably related to cvar hooking, like I free wrongly memory on amxx shutdown.

It seems that such feature is not included in git4579. You can test this one, it should be okay.
Then if so, try the next one git4584, it contains cvar hooking and you should have the issue.
Can you confirm? Meanwhile, will try to debug my shit code.

EDIT: test first that below:

yokomo

Quote:

Originally Posted by Arkshine

It's probably related to cvar hooking, like I free wrongly memory on amxx shutdown.

It seems that such feature is not included in git4579. You can test this one, it should be okay.
Then if so, try the next one git4584, it contains cvar hooking and you should have the issue.
Can you confirm? Meanwhile, will try to debug my shit code.

EDIT: test first that below:

Ok both git4579 and 4584 hang on quit command.

The new .dll you attached has no issue anymore, it seems game load faster with that new .dll. Why size is 2x bigger than normal amxmodx_mm.dll ?

I can confirm the new amxmodx_mm.dll is no longer hang

**Arkshine**

You likely did not test properly for git4579 and 4584 and first doesn't contain cvar hooking stuffs lol.

But anyway, if you say the attached dll is working, it's what I thought, freeing memory the wrong way for cvar hooking stuffs. Will fix that soon.

As note, size is bigger because compiled in debug mode.

**Arkshine**

Fix pushed in git4614.

Thanks for reporting my retardness.

yokomo · *Last edited by yokomo; 02-12-2015 at 09:07.*

Quote:

Originally Posted by Arkshine

You likely did not test properly for git4579 and 4584 and first doesn't contain cvar hooking stuffs lol.

But anyway, if you say the attached dll is working, it's what I thought, freeing memory the wrong way for cvar hooking stuffs. Will fix that soon.

As note, size is bigger because compiled in debug mode.

I speak the truth buddy. Run listenserver with 4579 and 4584 using stock plugins. Both result in crash boom bang. But the new .dll you attached above is no crash at all.

Quote:

Originally Posted by Arkshine

Fix pushed in git4614.

Thanks for reporting my retardness.

No problem, it would be good for others too.

**Arkshine** · *Last edited by Arkshine; 02-12-2015 at 09:13.*

Lies!

That's not possible really. Well, maybe you downloaded wrong package or said wrong git number. You can check easily if you see "cvars.inc" in the package, it means package contains the cvar hooking stuff.
Maybe we are all drunk.

yokomo

Quote:

Originally Posted by Arkshine

Lies!

That's not possible really. Well, maybe you downloaded wrong package or said wrong git number. You can check easily if you see "cvars.inc" in the package, it means package contains the cvar hooking stuff.
Maybe we are all drunk.

Haha, ok problem solved, change thread tag to [Solved]. Thanks for the fix by the way.