[friagram]

I believe there may be a bug with sm 1.6.4+ that is causing a lot of problems with plugins hooking events, but i'm not 100% sure,

It seems that any time a plugin is loaded from server boot / when sourcemod is starting up, hookevent will call the callback it is hooking. If it stack traces there, well.. since it's usually in OnPluginStart, very bad things will happen (like nothing will get initialized). Reloading the plugin later, does not exhibit this behavior. This happens for me a lot because I usually call my hookevents right after I register my convars, and then I allocate my arrays. I do not intend for hookevent to call the events (like round start or whatever):

I tested with this:

Spoiler

#include <sourcemod>
#include <sdktools>
#include <sdkhooks>
#include <tf2_stocks>

#pragma semicolon 1

new Handle:gh_cp_touched[MAXPLAYERS+1];

public OnPluginStart()
{
	LogMessage("PluginStart");

	HookEvent("teamplay_round_start", eventRoundStart);

	for (new client = 1; client <= MaxClients; client++)
	{
		LogMessage("allocating client:%d", client);
		gh_cp_touched[client] = CreateArray();
	}

	FindControlPoints();

}

public OnMapStart()
{	
    LogMessage("MapStart");
}

public OnClientPutInServer(iClient) {
    LogMessage("ClientPutInServer: %d", iClient);
}

public OnClientPostAdminCheck(iClient) {
    LogMessage("PostAdmin: %d", iClient);
}

public OnClientDisconnect(iClient) {
    LogMessage("Disconnect: %d", iClient);
}

FindControlPoints()
{
    for(new client=1; client<=MaxClients; client++)
    {
LogMessage("clearing client:%d", client);
        ClearArray(gh_cp_touched[client]);
    }
}

public Action:eventRoundStart(Handle:event, const String:name[], bool:dontBroadcast)
{
	LogMessage("EventRoundStart");

    FindControlPoints();
}

From server start:

Spoiler

L 03/19/2015 - 21:01:56: -------- Mapchange to mlp_appleloosa_v2 --------
L 03/19/2015 - 21:01:58: [testplugin.smx] PluginStart
L 03/19/2015 - 21:02:18: [testplugin.smx] MapStart
L 03/19/2015 - 21:02:21: [jumpmenu.smx] clearing client:1
L 03/19/2015 - 21:02:21: [testplugin.smx] EventRoundStart
L 03/19/2015 - 21:02:21: [testplugin.smx] clearing client:1




L 03/19/2015 - 20:58:11: [SM] Native "ClearArray" reported: Invalid Handle 0 (error: 4)
L 03/19/2015 - 20:58:11: [SM] Displaying call stack trace for plugin "testplugin.smx":
L 03/19/2015 - 20:58:11: [SM] [0] Line 52, D:\Friagram\Documents\Sourcemod\Compiler16\cu stom\dog\testplugin.sp::FindControlPoints()
L 03/19/2015 - 20:58:11: [SM] [1] Line 58, D:\Friagram\Documents\Sourcemod\Compiler16\cu stom\dog\testplugin.sp::eventRoundStart()

From reload:

Spoiler

L 03/19/2015 - 21:10:34: [testplugin.smx] PluginStart
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:1
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:2
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:3
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:4
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:5
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:6
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:7
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:8
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:9
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:10
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:11
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:12
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:13
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:14
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:15
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:16
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:17
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:18
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:19
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:20
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:21
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:22
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:23
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:24
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:25
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:26
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:27
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:28
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:29
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:30
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:31
L 03/19/2015 - 21:10:34: [testplugin.smx] allocating client:32
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:1
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:2
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:3
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:4
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:5
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:6
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:7
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:8
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:9
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:10
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:11
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:12
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:13
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:14
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:15
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:16
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:17
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:18
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:19
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:20
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:21
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:22
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:23
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:24
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:25
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:26
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:27
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:28
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:29
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:30
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:31
L 03/19/2015 - 21:10:34: [testplugin.smx] clearing client:32
L 03/19/2015 - 21:10:34: [testplugin.smx] MapStart

[asherkin]

You're a little off the mark, MaxClients isn't initialised until you're in OnMapStart, so your plugin is never initialising the array when loaded at server start. You just need to move your loop, OnMapStart is always called even for late-loaded plugin (which is why the late-load works, MaxClients has already been initialised).

EDIT: It's always worked this way.

[friagram]

On late load maxclients is set properly, and used to work (i think) ?
It will anyways now.

In this situation I would only need the array initialized once, so if onpluginstart is too early I would have to use onallpluginsloaded or something.

Also, if you look at the debug, event round start is being called (why is it even being called?), this is causing the stack trace.

[Dr. Greg House]

Because waitingforplayers.

[friagram]

If it's waitingforplayers causing it to fire (before the map loads during plugin start right when I hook it) that is odd behavior).
Anyways, its not a big problem, i can just allocate the array to a static value in this situation

[asherkin]

Not OnPluginStart, not OnAllPluginsLoaded, OnMapStart.
OnMapStart is where MaxClients is guaranteed to be initialised.
OnMapStart is the first time you can use it.

It does indeed work before that on a late load, that's because the hook backing OnMapStart has (obviously) already happened, SourceMod is just triggering OnMapStart in your plugin on late load so you can always use it for exactly this purpose.

The behaviour of game events is not affected by SourceMod, it is all up to the game. WFP is indeed considered the first round in TF2.

[WildCard65]

Originally Posted by asherkin Not OnPluginStart, not OnAllPluginsLoaded, OnMapStart. OnMapStart is where MaxClients is guaranteed to be initialised. OnMapStart is the first time you can use it. It does indeed work before that on a late load, that's because the hook backing OnMapStart has (obviously) already happened, SourceMod is just triggering OnMapStart in your plugin on late load so you can always use it for exactly this purpose. The behaviour of game events is not affected by SourceMod, it is all up to the game. WFP is indeed considered the first round in TF2.

I think I noticed that behaviour of tf2 and events in ff2.

[friagram]

It's probably just a case of me never having to initialize client variables that early before, usually i'd do it later on client connect or round start. Anyways, I can just set the array to initialize to like 36 or somesuch number that will always be greater than tf2s maxclient possible count.

[Mathias.]

Originally Posted by friagram It's probably just a case of me never having to initialize client variables that early before, usually i'd do it later on client connect or round start. Anyways, I can just set the array to initialize to like 36 or somesuch number that will always be greater than tf2s maxclient possible count.

do you not listen to what people wrote you?