[Dragokas]

Description:

Prints on center screen who's speaking. Original work done by Accelerator.

Optimized for the best performance.

Settings (ConVars):

None

Requirements:

- SourceMod v1.11+

ChangeLog

* 1.4.1 (26-Jan-2020) (Dragokas)
- Client in game check fixed
- Code is simplified
- New syntax

* 1.4.2 (23-Dec-2020) (Dragokas)
- Updated to use with SM 1.11
- Timer is increased 0.7 => 1.0

* 1.4.4 (10-Oct-2022) (Grey83)
- Optimization: timer moved from OnPluginStart to OnMapStart.
- Optimization: max. buffer checks and caching.

Credits:

- @Accelerator - for the original work and contribution to SourceMod core, made opportunity this plugin to be so simple
- @Grey83 - for optimizations.

[Grey83]

Maybe it's better like this?

PHP Code:

/*
    ChangeLog:
    
     * 1.4.1 (26-Jan-2020) (Dragokas)
      - Client in game check fixed
      - Code is simplified
      - New syntax
      
     * 1.4.2 (23-Dec-2020) (Dragokas)
      - Updated to use with SM 1.11
      - Timer is increased 0.7 => 1.0
*/
#pragma semicolon 1
#pragma newdecls required

bool bSpeaking[MAXPLAYERS+1];
char sPlayers[PLATFORM_MAX_PATH];

public Plugin myinfo = 
{
    name        = "SpeakingList",
    author        = "Accelerator (Fork by Dragokas)",
    description    = "Voice Announce. Print To Center Message who Speaking",
    version        = "1.4.2",
    url            = "https://forums.alliedmods.net/showthread.php?t=339934"
}

public void OnMapStart()
{
    for(int i = 1; i <= MaxClients; i++) bSpeaking[i] = false;

    CreateTimer(1.0, Timer_List, _, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE);
}

public void OnClientSpeaking(int client)
{
    bSpeaking[client] = true;
}
/*
public void OnClientSpeakingEnd(int client)
{
    bSpeaking[client] = false;
}
*/
public Action Timer_List(Handle timer)
{
    static bool show;
    static int i;
    for(i = 1, sPlayers[0] = 0, show = false; i <= MaxClients; i++) if(bSpeaking[i])
    {
        bSpeaking[i] = false;
        if(!IsClientInGame(i)) continue;

        show = true;
        if(Format(sPlayers, sizeof(sPlayers), "%s\n%N", sPlayers, i) == (sizeof(sPlayers) - 1)) break;    // buffer full
    }

    if(show) PrintCenterTextAll(sPlayers);

    return Plugin_Continue;
} 


[Dragokas]

In such case, it's better to check the return value of Format().
For performance purposes.
AFAIK, strlen counting each character again, before returning the length.

[Grey83]

Originally Posted by Dragokas AFAIK, strlen counting each character again, before returning the length.

fixed

[Dragokas]

Thanks, updated.

[101]

Originally Posted by Grey83 Maybe it's better like this? PHP Code: /*     ChangeLog:           * 1.4.1 (26-Jan-2020) (Dragokas)       - Client in game check fixed       - Code is simplified       - New syntax             * 1.4.2 (23-Dec-2020) (Dragokas)       - Updated to use with SM 1.11       - Timer is increased 0.7 => 1.0 */ #pragma semicolon 1 #pragma newdecls required bool bSpeaking[MAXPLAYERS+1]; char sPlayers[PLATFORM_MAX_PATH]; public Plugin myinfo =  {     name        = "SpeakingList",     author        = "Accelerator (Fork by Dragokas)",     description    = "Voice Announce. Print To Center Message who Speaking",     version        = "1.4.2",     url            = "https://forums.alliedmods.net/showthread.php?t=339934" } public void OnMapStart() {     for(int i = 1; i <= MaxClients; i++) bSpeaking[i] = false;     CreateTimer(1.0, Timer_List, _, TIMER_REPEAT|TIMER_FLAG_NO_MAPCHANGE); } public void OnClientSpeaking(int client) {     bSpeaking[client] = true; } /* public void OnClientSpeakingEnd(int client) {     bSpeaking[client] = false; } */ public Action Timer_List(Handle timer) {     static bool show;     static int i;     for(i = 1, sPlayers[0] = 0, show = false; i <= MaxClients; i++) if(bSpeaking[i])     {         bSpeaking[i] = false;         if(!IsClientInGame(i)) continue;         show = true;         if(Format(sPlayers, sizeof(sPlayers), "%s\n%N", sPlayers, i) == (sizeof(sPlayers) - 1)) break;    // buffer full     }     if(show) PrintCenterTextAll(sPlayers);     return Plugin_Continue; }

Why ?
there is no need to use repeated timers While there is two forwards (SpkStart,SpkEnd)!

[101]

Updated .
Multiple choices of displayment (author can edit script-if he need)
*Centermsg life time is about 2 secends and it need timer to be revived, so"i was wrong" .
*panel and Consolemsg can handle the msg 4 long time and don't need timers .
* Msg is instantly refreshed and doesn't wait for timer , TIMER's main mission is: reviving Centermsg
* Mute fix included

[Dragokas]

@101, looks good.
Also I would add IsClientInGame() check in OnClientDisconnect.

Original is written at times when SM engine didn't have those forwards. OnClientSpeaking is covered by separate extension at that moment, until @Accelerator finally added it to SM.

[Accelerator]

Updated version with EMS Hud support: https://github.com/accelerator74/sp-...peakingList.sp

[101]

Originally Posted by Dragokas @101, looks good. Also I would add IsClientInGame() check in OnClientDisconnect. Original is written at times when SM engine didn't have those forwards. OnClientSpeaking is covered by separate extension at that moment, until @Accelerator finally added it to SM.

yes , i have read that .
luckily , these forwards were added in the last version of sourcemod .