[Solved] How can i fix this Array index is out of bounds? :/

Elitcky · **Author**

Errors:

Code:

L 11/10/2017 - 16:14:56: [SM] Exception reported: Array index is out of bounds
L 11/10/2017 - 16:14:56: [SM] Blaming: skill.smx
L 11/10/2017 - 16:14:56: [SM] Call stack trace:
L 11/10/2017 - 16:14:56: [SM]   [1] Line 949, C:\Users\Mot\addons\sourcemod\scripting\skill.sp::Function_GetRank3
L 11/10/2017 - 16:14:56: [SM]   [2] Line 999, C:\Users\Mot\addons\sourcemod\scripting\skill.sp::Native_GetChatRank
L 11/10/2017 - 16:14:56: [SM]   [4] SB_GetChatRank
L 11/10/2017 - 16:14:56: [SM]   [5] Line 349, C:\Users\Mot\custom-chatcolors-csgo.sp::OnChatMessage
L 11/10/2017 - 16:14:56: [SM]   [7] Call_Finish
L 11/10/2017 - 16:14:56: [SM]   [8] Line 387, C:\Users\anthony\Desktop\JoshOG\Sourcemod\addons\sourcemod\scripting\simple-chatprocessor.sp::OnSayText2

skill.sp Lines

PHP Code:


			
public void Function_GetRank3(int rank, char[] string, int maxlength) 

{

    char sRank[64];

    Format(sRank, sizeof(sRank), "%s", Ranks[rank][tagRank]); // Line 949

    strcopy(string, maxlength, sRank);

}





public int Native_GetChatRank(Handle plugin, int numParams)

{

    int client = GetNativeCell(1);

    

    char rank[64], status[8];

    GetClientCookie(client, gH_sChatTag, status, sizeof(status));

    if (!StrEqual(status, "off", false))

    {

        Function_GetRank3(Function_GetRankNumber(client), rank, sizeof(rank)); //Line 999

        SetNativeString(2, rank, GetNativeCell(3), false);

    }

    else

    {

        SetNativeString(2, "", GetNativeCell(3), false);

    }

}

custom-chatcolors

PHP Code:


			
public Action:OnChatMessage(&author, Handle:recipients, String:name[], String:message[]) {

    new String:tempString[12];

    new String:tagtemp[64];

    new tempAuthor = author;

    

    //new String:name[MAXLENGTH_NAME];

    //Format(name, sizeof(name), "%s", iname);

    //strcopy(name, MAXLENGTH_NAME, iname);

    CStrip(name, MAXLENGTH_INPUT);

    

    //new String:message[MAXLENGTH_MESSAGE];

    //Format(message, sizeof(message), "%s", imessage);

    CStrip(message, MAXLENGTH_MESSAGE);

    

    if(CheckForward(author, message, CCC_NameColor)) {

        if(StrEqual(usernameColor[author], "G", false)) {

            Format(name, MAXLENGTH_INPUT, "\x04%s", name);

        } else if(StrEqual(usernameColor[author], "O", false)) {

            Format(name, MAXLENGTH_INPUT, "\x05%s", name);

        } else if(strlen(usernameColor[author]) == 6) {

            Format(name, MAXLENGTH_INPUT, "\x07%s%s", usernameColor[author], name);

        } else if(strlen(usernameColor[author]) == 8) {

            Format(name, MAXLENGTH_INPUT, "\x08%s%s", usernameColor[author], name);

        } else if(strlen(usernameColor[author]) == 4) {

            strcopy(tempString, sizeof(tempString), usernameColor[author]);

            if(StrEqual(tempString, "{03}")) {

                tempAuthor = -1;

            }

            CFormat(tempString, sizeof(tempString));

            Format(name, MAXLENGTH_INPUT, "%s%s", tempString, name);

        } else {

            Format(name, MAXLENGTH_INPUT, "\x03%s", name); // team color by default!

        }

    } else {

        Format(name, MAXLENGTH_INPUT, "\x03%s", name); // team color by default!

    }



    if(CheckForward(author, message, CCC_TagColor)) {

        if(strlen(tag[author]) > 0) {

            if(StrEqual(tagColor[author], "T", false)) {

                Format(name, MAXLENGTH_INPUT, "\x03%s%s", tag[author], name);

            } else if(StrEqual(tagColor[author], "G", false)) {

                Format(name, MAXLENGTH_INPUT, "\x04%s%s", tag[author], name);

            } else if(StrEqual(tagColor[author], "O", false)) {

                Format(name, MAXLENGTH_INPUT, "\x05%s%s", tag[author], name);

            } else if(strlen(tagColor[author]) == 6) {

                Format(name, MAXLENGTH_INPUT, "\x07%s%s%s", tagColor[author], tag[author], name);

            } else if(strlen(tagColor[author]) == 8) {

                Format(name, MAXLENGTH_INPUT, "\x08%s%s%s", tagColor[author], tag[author], name);

            } else if(strlen(tagColor[author]) == 4) {

                strcopy(tempString, sizeof(tempString), tagColor[author]);

                strcopy(tagtemp, sizeof(tagtemp), tag[author]);

                CFormat(tagtemp, sizeof(tagtemp));

                if(StrEqual(tempString, "{03}")) {

                    tempAuthor = -1;

                }

                CFormat(tempString, sizeof(tempString));

                Format(name, MAXLENGTH_INPUT, "%s%s%s", tempString, tagtemp, name);

            } else {

                Format(name, MAXLENGTH_INPUT, "\x01%s%s", tag[author], name);

            }

        }

    }



    if(skillbot) 

    {

        new String:rank[64];

        SB_GetChatRank(author, rank, sizeof(rank));  // Line 999



        if(strlen(rank) != 0)

        {

            CFormat(rank, sizeof(rank));

            Format(name, MAXLENGTH_INPUT, "%s %s", rank, name);

        }

    }

    

    new MaxMessageLength = MAXLENGTH_MESSAGE - strlen(name) - 5; // MAXLENGTH_MESSAGE = maximum characters in a chat message, including name. Subtract the characters in the name, and 5 to account for the colon, spaces, and null terminator

    

    if(strlen(chatColor[author]) > 0 && CheckForward(author, message, CCC_ChatColor)) {

        if(StrEqual(chatColor[author], "T", false)) {

            Format(message, MaxMessageLength, "\x03%s", message); 

        } else if(StrEqual(chatColor[author], "G", false)) {

            Format(message, MaxMessageLength, "\x04%s", message);

        } else if(StrEqual(chatColor[author], "O", false)) {

            Format(message, MaxMessageLength, "\x05%s", message);

        } else if(strlen(chatColor[author]) == 6) {

            Format(message, MaxMessageLength, "\x07%s%s", chatColor[author], message);

        } else if(strlen(chatColor[author]) == 8) {

            Format(message, MaxMessageLength, "\x08%s%s", chatColor[author], message);

        } else if(strlen(chatColor[author]) == 4) {

            strcopy(tempString, sizeof(tempString), chatColor[author]); 

            if(StrEqual(tempString, "{03}")) {

                tempAuthor = -1;

            }

            CFormat(tempString, sizeof(tempString));

            Format(message, MaxMessageLength, "%s%s", tempString, message);

        }

    }

    decl String:game[64];

    GetGameFolderName(game, sizeof(game));

    if(StrEqual(game, "csgo")) {

        Format(name, MAXLENGTH_NAME, "\x01\x0B %s", name);

    }

    

    Call_StartForward(messageForward);

    Call_PushCell(author);

    Call_PushStringEx(message, MaxMessageLength, SM_PARAM_STRING_UTF8|SM_PARAM_STRING_COPY, SM_PARAM_COPYBACK);

    Call_PushCell(MaxMessageLength);

    Call_Finish();

    author = tempAuthor;

    return Plugin_Changed;

}

The thing is, it's supposed to show a tag when a player has a rank...

Totenfluch · 11-11-2017 , 10:56 Re: How can i fix this Array index is out of bounds? :/

PHP Code:


			
Format(sRank, sizeof(sRank), "%s", Ranks[rank][tagRank]); // Line 949

to

PHP Code:


			
Format(sRank, sizeof(sRank), "%s", Ranks[rank]); // Line 949

Elitcky · 11-11-2017 , 15:33 Re: How can i fix this Array index is out of bounds? :/

didn't worked

( but thanks for the try :// anyone else ? :c

Walgrim · 11-12-2017 , 08:57 Re: How can i fix this Array index is out of bounds? :/

Not sure but, here you use a String.

PHP Code:


			
new String:rank[64];

SB_GetChatRank(author, rank, sizeof(rank));  // Line 999

And here a char, why? I mean, why not just using a string too?

PHP Code:


			
public void Function_GetRank3(int rank, char[] string, int maxlength) 

{

    char sRank[64];

    Format(sRank, sizeof(sRank), "%s", Ranks[rank][tagRank]); // Line 949

    strcopy(string, maxlength, sRank);

}





public int Native_GetChatRank(Handle plugin, int numParams)

{

    int client = GetNativeCell(1);

    

    char rank[64], status[8];

    GetClientCookie(client, gH_sChatTag, status, sizeof(status));

    if (!StrEqual(status, "off", false))

    {

        Function_GetRank3(Function_GetRankNumber(client), rank, sizeof(rank)); //Line 999

        SetNativeString(2, rank, GetNativeCell(3), false);

    }

    else

    {

        SetNativeString(2, "", GetNativeCell(3), false);

    }

}

I'm not sure about that for real, maybe I say some stupid things

Elitcky · 11-12-2017 , 13:37 Re: How can i fix this Array index is out of bounds? :/

Quote:

Originally Posted by Walgrim

Not sure but, here you use a String.

PHP Code:


			
new String:rank[64];

SB_GetChatRank(author, rank, sizeof(rank));  // Line 999

And here a char, why? I mean, why not just using a string too?

PHP Code:


			
public void Function_GetRank3(int rank, char[] string, int maxlength) 

{

    char sRank[64];

    Format(sRank, sizeof(sRank), "%s", Ranks[rank][tagRank]); // Line 949

    strcopy(string, maxlength, sRank);

}





public int Native_GetChatRank(Handle plugin, int numParams)

{

    int client = GetNativeCell(1);

    

    char rank[64], status[8];

    GetClientCookie(client, gH_sChatTag, status, sizeof(status));

    if (!StrEqual(status, "off", false))

    {

        Function_GetRank3(Function_GetRankNumber(client), rank, sizeof(rank)); //Line 999

        SetNativeString(2, rank, GetNativeCell(3), false);

    }

    else

    {

        SetNativeString(2, "", GetNativeCell(3), false);

    }

}

I'm not sure about that for real, maybe I say some stupid things

if im not wrong, "char" is used for the new syntax of sourcemod... and "new String:lalalala" was used in the old syntax... custom chat colors has all the code in old syntax so it need to be "new String:" and skillbot has defined the newdecls required new syntax :p so i need to use "char"

Pd:

Fyren · 11-12-2017 , 21:09 Re: How can i fix this Array index is out of bounds? :/

"Array index out of bounds" pretty clearly tells you what's wrong. One or more of the indices to your Ranks array are wrong. You didn't provide us any info as to how it's defined.

Elitcky · 11-13-2017 , 01:15 Re: How can i fix this Array index is out of bounds? :/

Are you asking me for this?

PHP Code:


			
enum Rank
{
    rankPoints,
    String:chatRank[64],
    String:menuRank[64],
    String:tagRank[64]
}
const MAX_RANKS = 32;
Rank Ranks[MAX_RANKS][Rank];
int maxRank = -1;

8guawong · *Last edited by 8guawong; 11-13-2017 at 12:23.*

you need to show us SB_GetChatRank function
and Function_GetRankNumber

Elitcky · 11-13-2017 , 12:45 Re: How can i fix this Array index is out of bounds? :/

SB_GetChatRank function

PHP Code:


			
public int Native_GetChatRank(Handle plugin, int numParams)
{
    int client = GetNativeCell(1);

    char rank[64], status[8];
    GetClientCookie(client, gH_sChatTag, status, sizeof(status));
    if(!StrEqual(status, "off", false))
    {
        Function_GetRank3(Function_GetRankNumber(client), rank, sizeof(rank));
        SetNativeString(2, rank, GetNativeCell(3), false);
    }
    else
    {
        SetNativeString(2, "", GetNativeCell(3), false);
    }
}

Function_GetRankNumber

PHP Code:


			
stock int Function_GetRankNumber(int client)
{
    int points = Function_ReturnPoints(client);
    if(points <= Ranks[0][rankPoints]) return 0;
    if(points >= Ranks[maxRank-1][rankPoints]) return maxRank-1;
    for(int i = maxRank-2; i > 0; i--) {
        if(points >= Ranks[i][rankPoints]) return i;
    }
    return -1;
}

hope this will help :/

8guawong · *Last edited by 8guawong; 11-13-2017 at 12:54.*

Your Function_GetRankNumber is probably the problem