[Natsheh]

What is the best way. To set spawn protection without bugging

[Bugsy]

Return ham_supercede on ham_takedamage pre.

[jimaway]

set_user_godmode from fun module should also work pretty well

with the ham_takedamage method players will still be vulnerable to aimpunch when shot at, this shouldn't be a thing with set_user_godmode

[Natsheh]

heres my method. but i guess sometimes it bugges

PHP Code:

public fw_ham_respawn_post(id)
{
         if(!is_user_alive(id)) return;
         
         spawn_protection(id)
}

public spawn_protection(id)
{
    new Float:fPTime = get_pcvar_float(g_pcvr_protection_time)
    
    if(!fPTime)
        return;
    
    g_fProtection_time[id] = fPTime + get_gametime()
    set_user_godmode(id, 1)
    
    remove_task(id+TASK_PROTECTION)
    set_task(1.0, "protection_off", id+TASK_PROTECTION, _, _, "b")
    
    new iColor[3], sColor[12]
    get_pcvar_string(g_pcvr_protection_color, sColor, charsmax(sColor))
    format_rgb(sColor, iColor)
    set_user_rendering(id, kRenderFxGlowShell, iColor[0], iColor[1], iColor[2], kRenderNormal, 16)
}

public protection_off(taskid)
{
    new id = taskid - TASK_PROTECTION
    
    if(!is_user_connected(id))
    {
        remove_task(taskid)
        return;
    }
    if(!is_user_alive(id))
    {
        set_user_rendering(id)
        remove_task(taskid)
        return;
    }
    if(get_gametime() < g_fProtection_time[id])
    {
        set_hudmessage(75, 75, 75, -1.0, 0.30, 1, 1.0, 1.0,0.3, 0.3, 4)
        show_hudmessage(id, "Protection : %d", floatround((g_fProtection_time[id]-get_gametime())))
        
        return;
    }
    
    set_user_godmode(id, 0)
    set_user_rendering(id)
    
    cprint(id, "^4%s ^3You have no longer a ^4proctection!", MODE_TAG)
    remove_task(taskid)
} 


[^SmileY]

Or you can use fakemeta

set_pev(id,pev_takedamage,id,DAMAGE_NO);

and

set_pev(id,pev_takedamage,id,DAMAGE_AIM);

[PartialCloning]

Originally Posted by Natsheh heres my method. but i guess sometimes it bugges

What part is bugged?

Originally Posted by ^SmileY Or you can use fakemeta set_pev(id,pev_takedamage,id,DAMAGE_NO); and set_pev(id,pev_takedamage,id,DAMAGE_AIM);

That's the same as using set_user_godmode.

[Natsheh]

sometimes the bot/player his protection wont be removed...

[PartialCloning]

You'll have to go into more details if you want help. The code looks fine.

Is the hud message displayed when the bug occurs? Any error logs? If you're using this in a deathmatch server, are you sure "fw_ham_respawn_post" is called when you respawn players?

[Natsheh]

nvm solved using post think to check if player still has the protection and also by making a bitsum to check if user has a godmode. , IDK if its the best method.

heres the code...

PHP Code:

public fw_player_respawn(id)
{
    if(!is_user_alive(id))
        return HAM_IGNORED;
    
    sp_on(id)
    return HAM_HANDLED;
}

public sp_on(id)
{
    new Float:fPTime = get_pcvar_float(g_pcvr_protection_time)
    
    if(!fPTime)
        return;
    
    if(check_flag(g_protection,id))
    {
        remove_task(id+TASK_PROTECTION)
        set_task(1.0, "protection_off", id+TASK_PROTECTION, _, _, "b")
        return;
    }
    
    set_flag(g_protection, id)
    g_fProtection_time[id] = fPTime + get_gametime()
    set_user_godmode(id, 1)
    
    new iColor[3], sColor[12]
    get_pcvar_string(g_pcvr_protection_color, sColor, charsmax(sColor))
    format_rgb(sColor, iColor)
    set_user_rendering(id, kRenderFxGlowShell, iColor[0], iColor[1], iColor[2], kRenderNormal, 16)
    
    set_task(0.1, "protection_off", id+TASK_PROTECTION, _, _, "b")
}


public protection_off(taskid)
{
    new id = taskid - TASK_PROTECTION
    
    if(!is_user_connected(id))
    {
        unset_flag(g_protection,id)
        remove_task(taskid)
        return;
    }
    if(!is_user_alive(id))
    {
        unset_flag(g_protection,id)
        set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderNormal, 16)
        remove_task(taskid)
        return;
    }
    if(get_gametime() < g_fProtection_time[id])
    {
        set_hudmessage(75, 75, 75, -1.0, 0.30, 1, 1.0, 1.0,0.3, 0.3, 4)
        show_hudmessage(id, "Protection : %d", floatround((g_fProtection_time[id]-get_gametime())))
        
        return;
    }
    
    unset_flag(g_protection,id)
    set_user_godmode(id, 0)
    set_user_rendering(id, kRenderFxNone, 0, 0, 0, kRenderNormal, 16)
    
    cprint(id, "^4%s ^3You have no longer a ^4proctection!", MODE_TAG)
    remove_task(taskid)
}

public client_PostThink(id)
{
    if(!is_user_alive(id))
        return;
    
    // in case of bug...
    if(get_user_godmode(id) && check_flag(g_protection,id) && !task_exists(id+TASK_PROTECTION))
    {
        protection_off(id+TASK_PROTECTION)
    }
} 


[jimaway]

that's a horrible way to fix this. what is TASK_PROTECTION? do you use any other tasks? how do you hook public fw_player_respawn(id)? do you respawn players with a plugin?

posting the full code will most likely get you a proper fix for your problem