[rek075]

Why not just add the disconnect function and team change function to the existing connect notification plugin nuwit posted? Looking at the code, it looks almost exactly the same... the first 22 lines anyway.

[dirka_dirka]

Originally Posted by Blu3star Now it spams all the bots connect/disconnect during play, when they die, and when they are spawned again. Including the infected.

yarp, need to check for bots so we dont see all that.. at least for the infected. it really sucks having the survivors know what they have to deal with.

[Blu3star]

just put
if(IsFakeClient(client))
return Plugin_Continue;
before announcing.

[kiwi87]

Originally Posted by Blu3star just put if(IsFakeClient(client)) return Plugin_Continue; before announcing.

I tried,

case 1:
{
if(IsFakeClient(playerClient))
return Plugin_Continue;
PrintToChatAll("%N", playerClient)
}

warning 209: Function "Jointeam" should return a value.


Hm...testing

[dirka_dirka]

for the team changing area kiwi, it isnt client, its playerClient

and it would be better to just put the whole switch inside:
if (!IsFakeClient(playerClient)) { SWITCH }
else { return Plugin_Continue; }

you could use what blu3star posted in the other 2 sections (onclientconnect and disconnect).

[Skyy]

I've written a new batch of code... Uploading now.

[Skyy]

I've rewritten the code and removed bot notifications. Let me know your feelings.

[psychonic]

Skyy, you need to add a check in the team change callback to make sure the client index is valid (IsClientInGame) else there is a chance for runtime errors.

Also, comments like these don't really belong in a plugin... this isn't the AMXX forum.

PHP Code:

//Buttsex and monkeys
//...Ignore that.
...
// I am such a fucking idiot.
// /Wrist 


[kiwi87]

L 05/04/2010 - 05:25:42: [SM] Native "IsFakeClient" reported: Client index 0 is invalid
L 05/04/2010 - 05:25:42: [SM] Displaying call stack trace for plugin "playerinfo.smx":
L 05/04/2010 - 05:25:42: [SM] [0] Line 50, /home/groups/alliedmodders/forums/files/6/9/2/0/5/59842.attach::JoinTeam()


Any fix on this? Its spamming my dedi svr's console

[dirka_dirka]

OnClientConnected is still commented out while OnClientDisconnect is what should be commented out. The primary reason to be using this plugin is wasted.

Its also rather spammy when people connect and join their team (they actually join 2 teams - spectator first).

I replaced OnClientConnected, OnClientDisconnect and JoinTeam with the following:

PHP Code:

public OnClientConnected(client)
{    
    if (IsFakeClient(client)) return;
    
    Joining[client] = false;
    
    CSkipNextClient(client);
    CPrintToChatAll("%sPlayer: {green}%N{default} has connected to the server.", TAG_INFO, client);
}

public OnClientDisconnect(client)
{
    if (IsFakeClient(client)) return;
    
    Joining[client] = false;
    
/*     Don't need the disconnect - L4D2 already reports that.. Leaving this here for when Valve breaks yet another function.
    CSkipNextClient(client);
    CPrintToChatAll("%sPlayer: {green}%N{default} has disconnected from the server.", TAG_INFO, client);
*/
}

public JoinTeam(Handle:event, String:event_name[], bool:dontBroadcast)
{
    new playerClient = GetClientOfUserId(GetEventInt(event, "userid"));
    new clientTeam = GetEventInt(event, "team");
    
    if (!playerClient) return;
    if (IsFakeClient(playerClient)) return;
    
    new Handle:pack;
    
    if (Joining[playerClient])        // If the player has just changed teams recently..
    {
        KillTimer(JoiningTimer[playerClient]);
        JoiningTimer[playerClient] = CreateDataTimer(1.0, AnnounceJoining, pack);
        WritePackCell(pack, playerClient);
        WritePackCell(pack, clientTeam);
    }
    else                             // This is the first team join the player has done..
    {
        Joining[playerClient] = true;
        JoiningTimer[playerClient] = CreateDataTimer(1.0, AnnounceJoining, pack);
        WritePackCell(pack, playerClient);
        WritePackCell(pack, clientTeam);
    }
} 


I also added this:

PHP Code:

#include <colors>
new bool:Joining[MAXPLAYERS+1];                    // No need to spam  join specator, join team when someone connects..
new Handle:JoiningTimer[MAXPLAYERS+1];            // Used to disable  joining specator team when someone connects.
#define TAG_INFO    "{lightgreen}[Join]{default} "

public Action:AnnounceJoining(Handle:timer, Handle:pack)
{
    ResetPack(pack);
    new playerClient = ReadPackCell(pack);
    new clientTeam = ReadPackCell(pack);
    
    if (!Joining[playerClient]) return;
    Joining[playerClient] = false;
    
    CSkipNextClient(playerClient);  // No need to tell this person they  are joining a team.. they already know.
    switch (clientTeam)
    {
        case TEAM_SPECTATORS:
        {
            CPrintToChatAll("%sPlayer: {green}%N{default} has joined the  Spectators.", TAG_INFO, playerClient);
        }
        case TEAM_SURVIVORS:
        {
            CPrintToChatAll("%sPlayer: {green}%N{default} has joined the  Survivors.", TAG_INFO, playerClient);
        }
        case TEAM_INFECTED:
        {
            Joining[playerClient] = false;
            
            CPrintToChatAll("%sPlayer: {green}%N{default} has joined the  Infected.", TAG_INFO, playerClient);
        }
    }
} 


It uses Colors.inc.. if you dont want to use that, replace the CPrintToChat's with PrintToChat's and remove the CSkipNextClient's. Also change the {lightgreen}, etcs to \x03's or just remove them if you dont want any color.

Anyway, it will wait 1 second after someone changes teams to report it. If they change again during that time, the first report wont show up. Cuts down on the connecting spam quite a bit (~33%). You also dont see your own messages (the CSkipNextClient lines), you already know when you change teams.


the error messages kiwi is getting, i believe results in the lack of this line:

if (!playerClient) return;