[ezio_auditore]

SO here is a new plugin,
I know there is an another plugin for a grenade launcher but this one is different

here a user can buy a launcher by saying /gren and launch a grenade by using +USE key

When a player dies and he is having a launcher, the launcher is removed

**Guidelines are made for a grenade launcher**

CVARS:--

Spoiler

amx_gren_on | turns on/off the plugin
amx_gren_cost | Sets the cost of grenade launcher
amx_gren_damage | Amount of damage caused by a grenade
amx_gren_time | Time after which it becomes usable
amx_gren_radius | Radius in which a player takes damage
amx_gren_strip | Whether strip a user after he dies
amx_gren_lammo | Launcher Ammo
amx_gren_ammo_cost | Cost for one launcher

Updates coming soon...

Spoiler

PHP Code:

/*
    Changelog :--
        ====================================================================================
        v1.02 : Added new feature :: Grenade Laucher Ammo
        ====================================================================================
        v1.01 : Added Radius Damage Feature
            Grenade launcher can stay after death (Adjustible on CVars)
            Added mp_friendlyfire support
        ====================================================================================
        v1.00 : Initail Release
        ====================================================================================
*/ 


New version's code is OPTIMIZED

[DruGzOG]

Extra item for what?

#include <amxmodx> #include <amxmisc> #include <fakemeta> #include <fun> #include <hamsandwich> #include <cstrike> #include <engine>

Hmm. Why are you using both engine and fakemeta? Why not pick one?

[hornet]

Did you test this? Did you even attempt to compile this?
This will cause several errors and doesn't look like it's going to work as intended.

Originally Posted by DruGzOG Extra item for what? Hmm. Why are you using both engine and fakemeta? Why not pick one?

A user may include any combination of modules he likes, usually assuming that each of the 2 will provide a better method for one scenario than the other eg. Engine and Fakemeta.

[ezio_auditore]

Originally Posted by hornet Did you test this? Did you even attempt to compile this? This will cause several errors and doesn't look like it's going to work as intended. A user may include any combination of modules he likes, usually assuming that each of the 2 will provide a better method for one scenario than the other eg. Engine and Fakemeta.

I dont understand what are you implying,
It works just awesome + I updated it

[claudiuhks]

PHP Code:

        for (new i = 1 ; i < get_maxplayers() ; i++){ 


What?

Fakemeta contains everything or almost everything that CStrike, Fun and Engine contain.
Fakemeta_UTIL file would be a good header file to use.
Why stock function type in SMA file?
Why AMXMisc header file?
Make sure client is connected when ClientCommand is executed.

Change

PHP Code:

public makeready(id){
    client_print(id, print_center, "Grenade Launcher Ready!")
    emit_sound(id, CHAN_AUTO, snd[1], VOL_NORM, ATTN_NORM, 0, PITCH_NORM)
} 


to

PHP Code:

public makeready(id){  if (!is_user_connected(id)) return;
    client_print(id, print_center, "Grenade Launcher Ready!")
    emit_sound(id, CHAN_AUTO, snd[1], VOL_NORM, ATTN_NORM, 0, PITCH_NORM)
} 


PHP Code:

    new owner = pev(ent, pev_owner) 


Is rocket's (or grenade's) owner always in-game?

[ezio_auditore]

thanks claudiuhks, I'll do it asap

[hornet]

Originally Posted by ezio_auditore I dont understand what are you implying, It works just awesome + I updated it

Originally Posted by ezio_auditore I dont understand what are you implying, It works just awesome + I updated it

Implying that by looking at the code it would not compile ( until you updated it ) and will not be effective.

-The grenade only does damage if it hits a player.
-Your using CmdStart to hook a simple button press when there are better methods available.
-You have several unnecessary checks when calling damage() function.
-Your stock cvartotime is useless, that's what get_pcvar_float() is for.

You have been told several times to stop posting ( random ) plugins yet you still continue before you have even learnt anything more.

Originally Posted by claudiuhks Fakemeta contains everything or almost everything that CStrike, Fun and Engine contain. Fakemeta_UTIL file would be a good header file to use.

Just because you can do those things with it doesn't mean that you should. As I said, nearly ( if not ) every module has a native that is better to use, rather than a method provided by some other module.
Fakemeta_Util is a good example of what not to do. ( Good work done by Ven but really only good use for learning purposes ).

[claudiuhks]

Originally Posted by hornet Fakemeta_Util is a good example of what not to do. ( Good work done by Ven but really only good use for learning purposes ).

Why not? Its Fun replacements are almost untouched as I've seen. Of course, it uses more CPU frequency per call, but let's say that grenades launcher doesn't eat so much.

[ezio_auditore]

I used cmdstart instead of

PHP Code:

register_clcmd("use", "plPressedE") 


and i think i don't have any other way to display launcher guidelines....

[hornet]

Originally Posted by claudiuhks Why not? Its Fun replacements are almost untouched as I've seen.

Some of them are okay, and some of them are just macros. But take fm_give_item() for example, look how many more natives are used to achieve that. It's 13 natives, vs 1 ( give_item() ). The more tasks you allow the module to handle, the more efficient the plugin will be.

Originally Posted by ezio_auditore I used cmdstart instead of PHP Code: register_clcmd("use", "plPressedE")  and i think i don't have any other way to display launcher guidelines....

You mean +use? A rather reliable method is FM_EmitSound.