[glittershii]

I have a game that gives players -15 frags on teamkill.
I don't want this so I give players 16 frags to counter the penalty. They end up earning 1 frag.

I then perform actions based on the updated/fixed score. Here's the relevant bit of code:

PHP Code:

public void OnPluginStart() 
{ 
    HookEventEx("entity_killed", Event_EntityKilled);  
} 

public void Event_EntityKilled(Handle:event, const String:name[], bool:Broadcast) 
{
    int i_Attacker = GetEventInt(event, "entindex_attacker"); 
    SetEntProp(i_Attacker, Prop_Data, "m_iFrags", GetClientFrags(i_Attacker) + 16);
    PrintToChatAll("[debug] %i", GetClientFrags(i_Attacker));

    //perform further calculations based on the final fixed score (changelevel if m_iFrags is over 20, etc)
} 


Here's the same code but hooked to player_death instead:

PHP Code:

public void OnPluginStart() 
{ 
    HookEventEx("player_death", Event_PlayerDeath);
} 

public void Event_PlayerDeath(Handle:event, const String:name[], bool:Broadcast) 
{
    new i_Attacker = GetClientOfUserId(GetEventInt(event, "attacker"));
    SetEntProp(i_Attacker, Prop_Data, "m_iFrags", GetClientFrags(i_Attacker) + 16);
    PrintToChatAll("[debug] %i", GetClientFrags(i_Attacker));
    
    //perform further calculations based on the final fixed score (changelevel if m_iFrags is over 20, etc)
} 


Assuming the player has a starting score of 0 frags and he teamkills someone:

The score shows 1 positive frag.
Plugin hooked to entity_killed prints 1.
Plugin hooked to player_death prints 16.

..why? Why is the latter not printing 1?

[Bacardi]

What freaking game ? SourceMod support many game mods!!

[glittershii]

Originally Posted by Bacardi What freaking game ? SourceMod support many game mods!!

I thought it was irrelevant to the question since those are generic Source events. Game is No More Room in Hell.

[Mitchell]

Originally Posted by glittershii I thought it was irrelevant to the question since those are generic Source events. Game is No More Room in Hell.

It's never irrelevant, some of the events are generic yes, but some games, like NMRiH are not made by Valve.
I was thinking this was for l4d or cs:s

[Bacardi]

Originally Posted by glittershii I thought it was irrelevant to the question since those are generic Source events. Game is No More Room in Hell.

Thank you very much!

You are not only one.
Most new forum users also start ask/request/"need help asap"-topics but never they say (first)... what game.

Like what you mention before, "I have a game that gives players -15 frags on teamkill."
I don't remember any other game what does this. Or is it gameplay by SourceMod plugin (vip, zombie, etc. etc.)?
There is so many... possibilities.

But thanks for info, let's see if someone help in this when have time.

*edit
Aaa.. FREE game

[Bacardi]

You could follow events...

con_timestamp 1
con_logfile events.txt
sm_cvar net_showevents 2


I don't have opportunity test teamkill, but in suicide action, player_death event come first, entity_killed as second.

Server event "player_death", Tick 45318:
- "userid" = "5"
- "attacker" = "0"
- "weapon" = "env_explosion"
player_death
Server event "entity_killed", Tick 45318:
- "entindex_killed" = "1"
- "entindex_attacker" = "423"
- "entindex_inflictor" = "423"
- "damagebits" = "64"
entity_killed

I didn't quite understand your examples, but quick thinking...
Frag penalty comes after player_death.

What I tested, I lost 1 frag after player_death event.


*edit
Try this.
Assume, players are in same team,
when "attacker" userid return client index, it create small timer and pass m_iFrags later on attacker.

PHP Code:

public void OnPluginStart()
{
    HookEventEx("player_death", player_death);
    //HookEventEx("entity_killed", entity_killed);
}

public void player_death(Handle event, char[] name, bool Broadcast)
{
    int player = GetClientOfUserId(GetEventInt(event, "attacker"));

    if(player != 0)
    {
        //PrintToServer("player_death %i", GetClientFrags(player));
        
        DataPack pack;
        CreateDataTimer(0.0, delay, pack, TIMER_FLAG_NO_MAPCHANGE);
        pack.WriteCell(GetClientUserId(player));
        pack.WriteCell(GetEntProp(player, Prop_Data, "m_iFrags"));
        pack.Reset();
    }
}

public Action delay(Handle timer, DataPack pack)
{
    int player = GetClientOfUserId(pack.ReadCell());

    if(player != 0)
    {
        int frags = pack.ReadCell();
        //PrintToServer("delay %i %i", player, frags);
        SetEntProp(player, Prop_Data, "m_iFrags", frags);
    }
}

public void entity_killed(Handle event, char[] name, bool Broadcast)
{
    int player = GetEventInt(event, "entindex_attacker");
    //PrintToServer("entity_killed %i", GetClientFrags(player));
} 


[glittershii]

Hey, thanks for taking your time to test that out.

Player 'survivor1' died at the hands of 'survivor2'.
player_death 0
entity_killed -15
delay 1 0

This is the server output when running your code /w the commented out parts included. Frags stay at 0

Now, back to the original code, this is what I don't understand:

PHP Code:

//hooked to entity_killed
//m_iFrags is 0
public void Event_EntityKilled(Handle:event, const String:name[], bool:Broadcast) //m_iFrags is -15
{
    int i_Attacker = GetEventInt(event, "entindex_attacker"); 
    SetEntProp(i_Attacker, Prop_Data, "m_iFrags", GetClientFrags(i_Attacker) + 16); //m_iFrags is 1
    PrintToChatAll("[debug, entitykilled.sp] %i", GetClientFrags(i_Attacker)); //m_iFrags is 1. Good!
} 


PHP Code:

//hooked to player_death
//m_iFrags is 0
public void Event_PlayerDeath(Handle:event, const String:name[], bool:Broadcast) //m_iFrags is -15
{
    new i_Attacker = GetClientOfUserId(GetEventInt(event, "attacker"));
    SetEntProp(i_Attacker, Prop_Data, "m_iFrags", GetClientFrags(i_Attacker) + 16); //m_iFrags should be 1
    PrintToChatAll("[debug, playerdeath.sp] %i", GetClientFrags(i_Attacker)); //m_iFrags is 16. Hm, what!? 


I mean I guess I can leave the script hooked to entity_death, or use player_death and add a delay between the second and third line, but still...
Why does this happen?

[Dr!fter]

This really isn't this hard, player_death event happens before the frags is changed so it's 0. Entity killed is after the score stuff is handled so it's -15.

[glittershii]

Originally Posted by Dr!fter This really isn't this hard, player_death event happens before the frags is changed so it's 0. Entity killed is after the score stuff is handled so it's -15.

Right I see. Okay I'll tweak my code based on that. Thanks for the explanation.