[kadet.89]

So, if I make vphooks for two CCSPlayer instances, the hook will fires for each of them twice (4 times in total)?

[donrevan]

I updated my snippet. Two different CCSPlayer instances share the same vtable so vphooking both results in the hook callback being executed twice.

[kadet.89]

PHP Code:

SH_ADD_MANUALVPHOOK(SetEntityModelHook, pEntity, SH_MEMBER(&g_interface, &Sample::SetEntityModel), false); 


I've just tried to use this hook and it only fires for the hooked instance. But SH_ADD_VPHOOK works just fine for every instance

[KyleS]

Originally Posted by kadet.89 PHP Code: SH_ADD_MANUALVPHOOK(SetEntityModelHook, pEntity, SH_MEMBER(&g_interface, &Sample::SetEntityModel), false);  I've just tried to use this hook and it only fires for the hooked instance. But SH_ADD_VPHOOK works just fine for every instance

https://mxr.alliedmods.net/sourcemod...ension.cpp#714 Works for me, hum. Do you have any code?

[kadet.89]

PHP Code:

SH_DECL_MANUALHOOK1_void(SetEntityModelHook, 0, 0, 0, const char *);
.....

bool Sample::SDK_OnLoad(char *error, size_t maxlength, bool late)
{
....
    if(!g_pGameConf->GetOffset("SetEntityModel", &offset) || !offset) {
        g_pSM->LogError(myself, "SetEntityModel offset is broken");
        return false;
    }
    SH_MANUALHOOK_RECONFIGURE(SetEntityModelHook, offset, 0, 0);
}
void Sample::OnClientPutInServer(int client)
{
    CBaseEntity *pEntity = gamehelpers->ReferenceToEntity(client);
    setmodelhooks[client] = SH_ADD_MANUALVPHOOK(SetEntityModelHook, pEntity, SH_MEMBER(&g_interface, &Sample::SetEntityModel), false);
}
... 


I have to hook it for every player

[KyleS]

Originally Posted by kadet.89 PHP Code: SH_DECL_MANUALHOOK1_void(SetEntityModelHook, 0, 0, 0, const char *); ..... bool Sample::SDK_OnLoad(char *error, size_t maxlength, bool late) { ....     if(!g_pGameConf->GetOffset("SetEntityModel", &offset) || !offset) {         g_pSM->LogError(myself, "SetEntityModel offset is broken");         return false;     }     SH_MANUALHOOK_RECONFIGURE(SetEntityModelHook, offset, 0, 0); } void Sample::OnClientPutInServer(int client) {     CBaseEntity *pEntity = gamehelpers->ReferenceToEntity(client);     setmodelhooks[client] = SH_ADD_MANUALVPHOOK(SetEntityModelHook, pEntity, SH_MEMBER(&g_interface, &Sample::SetEntityModel), false); } ...  I have to hook it for every player

Ensure you're compiling against core. core-legacy could have issues...

[kadet.89]

Yes, I compile my extension against core

mmsource\core\sourcehook\sourcehook.h

PHP Code:

#define SH_ADD_MANUALVPHOOK(hookname, ifaceptr, handler, post) \
    __SourceHook_FHMAdd##hookname(reinterpret_cast<void*>(ifaceptr), SourceHook::ISourceHook::Hook_VP, post, handler) 


[micapat]

Hi,

< Small question in the same topic, to avoid to create another thread... >

@donrevan:
You showed a small example for Windows at #4.
For Linux, retrieving the memory address of "_ZTV9CCSPlayer" is enough to access the virtual table of a player?

Something like:

PHP Code:

void  *pVtable  = NULL;
void **ppVtable = NULL;;

pGameConfig->GetMemSig("CCSPlayerVTable", &pVTable); // <= _ZTV9CCSPlayer
ppVtable = (void **) pVtable; // Ugly cast (reinterpret?)

// Here we can access to the virtual table with the offsets..
ppVtable[OffsetSpawn]...
ppVtable[OffsetTakeDamage]... 


Is it correct?

[asherkin]

No, the vtable symbol does not point to the start of the function list.
If the class has no virtual bases and is the primary vtable, it's 8 bytes after where the symbol points.
Unless you have a very good reason not to, you should get it from an instance.

[micapat]

OK. It was just to know another method to find the vtable :>.