[Liverwiz]

So i'm trying to catch an event (along with many others) of a player committing suicide. (he grenade, fall, kill in console, etc) and i can't get it to work.

Searching led me nowhere.
My code:

PHP Code:

 //init
register_event("DeathMsg", "Event_Death", "a")

public Event_Death() 
{
    new attackerID = read_data(1)
    new victimID = read_data(2)
    new headshot = read_data(3)
    new weapon[32]; read_data(4, weapon, charsmax(weapon) )
        
    if(attackerID == 0 || victimID == attackerID)
        // stuff and things for Suicide
    else if(cs_get_user_team(victimID) == cs_get_user_team(attackerID))
        // stuff and things for Team Attack
    else
                // stuff and things for normal death

    if(headshot)
        // stuff and things for headshot
} 


any ideas, friends?
I saw code laying around somewhere that it would throw 0 as attacker on suicide. but this method proves ineffective.

[Kreation]

if( attacker == victim ) {
     // suicide?
}

Pretty sure that's how you would do that.

EDIT: That works for kill in console(spoiler).

A fall isn't considered suicide because they die from the ground(I think it's considered world spawn, but I'm not sure)

For a grenade you'd probably need to check the owner of the grenade and compare it with who died.

Spoiler

[Liverwiz]

Originally Posted by Kreation if( attacker == victim ) {      // suicide? } Pretty sure that's how you would do that. Although, it appears you've tried that.

that doesn't return a fall death anyway.

[rak]

your plugin work for me

[Liverwiz]

Originally Posted by rak your plugin work for me

if it works for you it could be the workings....but its strange that it wouldn't send a negative number.

giveFrags(victimID, -1, "PLAYER_SUICIDE")

Spoiler

EDIT: even so...this doesn't print when i either fall to my death, or type kill on console.

client_print(victimID, print_chat, "You ded!")

testing with a global print now....
EDIT: global print doesn't happen either....
My code:

PHP Code:

// init
register_event("DeathMsg", "Event_Death", "a")

public Event_Death() 
{
    new attackerID = read_data(1)
    new victimID = read_data(2)
    new headshot = read_data(3)
    new weapon[32]; read_data(4, weapon, charsmax(weapon) )
    
    g_bknuckles[victimID] = ( get_pcvar_num(cost_pcvar) == -1 )    // set dead client's BK status (true if knuks are perma)
    
    if( !g_bknuckles[attackerID] || !equali(weapon, "knife") || 
      !is_user_connected(attackerID) || !is_user_connected(victimID) )
        return
        
    if(attackerID == 0 || victimID == attackerID)
    {
        client_print(0, print_chat, "You ded!")
        giveFrags(victimID, -1, "USER_SUICIDE")    // take 1 frag if suicide
    }
    else if(cs_get_user_team(victimID) == cs_get_user_team(attackerID))
        giveFrags(attackerID, -2, "USER_TK")    // take 2 frags if TK
    else if(gi_playerFrags[victimID] > gi_playerFrags[attackerID]+50)
        giveFrags(attackerID, 2, "BONUS_FRAGS")    // give 2 frags if victim has +50 frags
    else
        giveFrags(attackerID, 1, "KILL_STANDARD")    // 1 frag for kill
        
    if(headshot)
        giveFrags(attackerID, 1, "KILL_HS")
} 


*facepalm* i'm a fucking idiot

-problem solved-

[ConnorMcLeod]

http://www.amxmodx.org/funcwiki.php?go=func&id=381

This is same as fakemeta FM_ClientKill

Call it : user_kill(id) or dllfunc(DLLFunc_ClientKill, id)

[hleV]

#include <amxmodx>

public plugin_init()
    register_event("DeathMsg", "OnDeathMsg", "a");

public OnDeathMsg()
{
    new killer = read_data(1);
    new victim = read_data(2);

    if (killer && killer != victim)
        return;

    // Player (victim) suicided
}

[ConnorMcLeod]

Originally Posted by hleV #include <amxmodx> public plugin_init()     register_event("DeathMsg", "OnDeathMsg", "a"); public OnDeathMsg() {     new killer = read_data(1);     new victim = read_data(2);     if (killer && killer != victim)         return;     // Player (victim) suicided }

This is wrong, fall damage death gonna pass this check, should only check killer == victim, and if weapon is not a grenade, so client_kill is best method imo.

[Liverwiz]

Originally Posted by ConnorMcLeod http://www.amxmodx.org/funcwiki.php?go=func&id=381 This is same as fakemeta FM_ClientKill Call it : user_kill(id) or dllfunc(DLLFunc_ClientKill, id)

No offense, but i do not like this method. when the user types kill it sends a deathMSG of the killer being the victim (killer == victim) which is just as easy to check in DeathMsg() as anything else. This way just adds one more function, one more forward/hook, and 10 more lines of code. Just unneccesary. IMHO

Originally Posted by ConnorMcLeod This is wrong, fall damage death gonna pass this check, should only check killer == victim, and if weapon is not a grenade, so client_kill is best method imo.

only thing that needs to be fixed is

if( !! killer .....

As to make sure the killer is not 0
Fall damage will then be accepted; and it DOES work with typing kill in console (tested)

Though i don't think he read my code, meaning if i was an idiot...this would just confuse me.

[hleV]

Originally Posted by ConnorMcLeod This is wrong, fall damage death gonna pass this check, should only check killer == victim, and if weapon is not a grenade, so client_kill is best method imo.

But he wants to include deaths from falling. I don't see any flaw in my code.