Raised This Month: $168 Target: $400
 42% 

Open Source Half-Life Engine


Post New Thread Reply   
 
Thread Tools Display Modes
Solokiller
Senior Member
Join Date: Sep 2015
Old 07-10-2017 , 19:00   Re: Open Source Half-Life Engine
Reply With Quote #71

I sent your report to Alfred.
Solokiller is offline
[email protected]
Veteran Member
Join Date: Jan 2010
Location: Russia, Ivanovo
Old 07-10-2017 , 19:30   Re: Open Source Half-Life Engine
Reply With Quote #72

The bug with %s0 is located in CLocalizedStringTable::ConstructString. It checks that X in "%sX" is less or equal than the numFormatParameters, but doesn't check that X > 0.
When there is no "%sX" (but just "%s" or something else) in message then the client uses snwprintf. But snwprintf doesn't support the argument count check like ConstructString, so swnprintf can get the garbage from the stack and crash the client. So there should be used custom snwprintf implementation with argument count checking (they can copy code from CLocalizedStringTable::ConstructString and change the part of code with positional %s).
__________________

Last edited by [email protected]; 07-10-2017 at 20:06.
PRoSToTeM@ is offline
Send a message via ICQ to PRoSToTeM@ Send a message via Skype™ to PRoSToTeM@
azim
Junior Member
Join Date: Nov 2013
Old 07-12-2017 , 05:36   Re: Open Source Half-Life Engine
Reply With Quote #73

chat broken after update:chat bug s1:s2
azim is offline
SpawnerF
Member
Join Date: Apr 2017
Location: Morocco
Old 07-12-2017 , 16:01   Re: Open Source Half-Life Engine
Reply With Quote #74

Quote:
Originally Posted by azim View Post
chat broken after update:chat bug s1:s2
this should be okey until they fix it :

Code:
/* First, save the file !   -   Sublime AMXX Editor v1.9 */ #include <amxmodx> #pragma semicolon 1 new Trie:_hashList; new const    _getResult[][][] = {       { "#Cstrike_Chat_CT",         "^x01(Counter-Terrorist)^x01"},       { "#Cstrike_Chat_CT_Dead",    "^x01*DEAD* (Counter-Terrorist)^x01"},       { "#Cstrike_Chat_All",        "^x03"},       { "#Cstrike_Chat_Spec",       "^x01(Spectator)^x01"},       { "#Cstrike_Chat_T",          "^x01(Terrorist)^x01"},       { "#Cstrike_Chat_T_Dead",     "^x01*DEAD* (Terrorist)^x01"},       { "#Cstrike_Chat_AllDead",    "^x01*DEAD*^x01"},       { "#Cstrike_Chat_AllSpec",    "^x01*SPEC*^x01"}    } ; public plugin_end( )       TrieDestroy( _hashList ); public plugin_precache()   register_message(get_user_msgid("SayText"),"sayText_LastBuild_Hook"); public plugin_init(){        register_plugin("Some shit", "1.0", "Spawner & SkillartzHD");        _hashList = TrieCreate();    for(new i; i < sizeof _getResult; i++)       TrieSetString(  _hashList, _getResult[i][0], _getResult[i][1] );     } public sayText_LastBuild_Hook(  ){        // Isn't is user connected (->ingame) already checked?    new _getMessage[ 192 ];    read_args(_getMessage, charsmax(_getMessage));        new _getType[ 24 ], _userName[ 32 ], _output[ 34 ];        get_msg_arg_string(2, _getType, charsmax(_getType));    get_user_name( get_msg_arg_int(1), _userName, charsmax(_userName) );    TrieGetString( _hashList, _getType, _output, charsmax(_output) );        replace(_getMessage, charsmax(_getMessage), "^"", "");    format(_getMessage, charsmax(_getMessage), "%s ^x03%s : ^x01%s", _output,  _userName, _getMessage);        !equali(_getType,"#Cstrike_Name_Change") ? set_msg_arg_string( 2, _getMessage ) : 1;  //#'" Somehow there is a unknown bug changing name which displace name :" xx, so this line code will fix it.     }
__________________
XX was created just for giving evidence and not meant to damage public servers.
&We do not test on public servers.
Thank's.

Last edited by SpawnerF; 07-12-2017 at 18:40.
SpawnerF is offline
BHQRicy
Junior Member
Join Date: Jun 2017
Old 07-16-2017 , 12:05   Re: Open Source Half-Life Engine
Reply With Quote #75

Anyone test SpawnerF´s fix ?
BHQRicy is offline
georgik57
Veteran Member
Join Date: Oct 2008
Location: 🎧Music World
Old 07-17-2017 , 10:27   Re: Open Source Half-Life Engine
Reply With Quote #76

Another update has been released with no changelog. They probably fixed it.
__________________
Zombie Plague Nightmare Mod + all sub-plugins
Appreciate my help or want to support me release awesome plugins?
PayPal
Donate Steam games or items

georgik57 is offline
Send a message via MSN to georgik57 Send a message via Yahoo to georgik57 Send a message via Skype™ to georgik57
Solokiller
Senior Member
Join Date: Sep 2015
Old 07-17-2017 , 10:47   Re: Open Source Half-Life Engine
Reply With Quote #77

The only changes i see were to correct the removal of the games from some of the packs. It broke a bunch of stuff. Steam hasn't downloaded anything either.
Solokiller is offline
Gabe Iggy
Veteran Member
Join Date: Mar 2011
Location: Chile
Old 07-17-2017 , 12:28   Re: Open Source Half-Life Engine
Reply With Quote #78

What do you mean with "removal of games"?
__________________

Current Handle Name: G.I. / Luces en Babel / Gabe Iggy (Steam)
Public Plugins:
Static.cfg Restoration | Sven Co-op Player vs Player | Hide Donator Icons
Discord: http://discord.motv.moe/
Gabe Iggy is offline
Solokiller
Senior Member
Join Date: Sep 2015
Old 07-17-2017 , 12:39   Re: Open Source Half-Life Engine
Reply With Quote #79

Somebody at Valve accidentally removed a couple games from packages and caused games to disappear from people's games list. Mods were also affected. They undid the changes, you can check it on SteamDB.
Solokiller is offline
krysteksulek
Member
Join Date: Aug 2013
Old 07-19-2017 , 12:16   Re: Open Source Half-Life Engine
Reply With Quote #80

Unfortunately Spawner's version sometimes causes server crash with message:
Code:
Refusing to send user message SayText of 194 bytes to client, user message size limit is 192 bytes
Random crashes started exacly when i installed this plugin. Any fixes?
krysteksulek is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 09:04.


Powered by vBulletin®
Copyright ©2000 - 2017, vBulletin Solutions, Inc.
Theme made by Freecode