[condolent]

Hello,

How can I add a item to the menu for each player online?
I tried this:

PHP Code:

for(new i = 1; i <= MaxClients; i++) {
    char name[MAX_NAME_LENGTH];
    GetClientName(i, name, sizeof(name));
    
    if(IsClientInGame(i)) {
        // Add to menu
        userListMenu.AddItem(userCHOICE, name);
    }
} 


but that doesn't work and makes the menu not show up..

[hmmmmm]

Gonna need to see more code than that, show the entire menu displaying code, the stuff you posted seems fine

EDIT: yea nvm I'm big dumb

[Deathknife]

Only get client's name after checking that he's in game. You are trying to get a name of non existing player and causes an error, which is why your menu doesn't show up.

[Fyren]

Deathknife is right and you should be able to see the error in your server console every time you try to run that code. However, you should use either AddTargetsToMenu or AddTargetsToMenu2 instead anyway if you're only displaying names.

[condolent]

Originally Posted by Fyren Deathknife is right and you should be able to see the error in your server console every time you try to run that code. However, you should use either AddTargetsToMenu or AddTargetsToMenu2 instead anyway if you're only displaying names.

How would I go about using AddTargetsToMenu?

This is what I came up with:

PHP Code:

public Action sm_checkrespawn(int client, int args) {
    
    Menu userListMenu = new Menu(userListHandler, MENU_ACTIONS_ALL);
    userListMenu.SetTitle("Check respawns left");
    for(new i = 1; i <= MaxClients; i++) {
        char name[MAX_NAME_LENGTH];
        
        if(IsClientInGame(i)) {
            GetClientName(i, name, sizeof(name));
            //userListMenu.AddItem(userCHOICE, name);
            userListMenu.AddTargetsToMenu(userListHandler, i, true, false);
        }
    }
    userListMenu.Display(client, 20);
    
    return Plugin_Handled;
} 


But that didn't really seem to work. It's telling me "Cannot find method or property Menu.AddTargetsToMenu"

[Deathknife]

Originally Posted by condolent How would I go about using AddTargetsToMenu? This is what I came up with: PHP Code: public Action sm_checkrespawn(int client, int args) {          Menu userListMenu = new Menu(userListHandler, MENU_ACTIONS_ALL);     userListMenu.SetTitle("Check respawns left");     for(new i = 1; i <= MaxClients; i++) {         char name[MAX_NAME_LENGTH];                  if(IsClientInGame(i)) {             GetClientName(i, name, sizeof(name));             //userListMenu.AddItem(userCHOICE, name);             userListMenu.AddTargetsToMenu(userListHandler, i, true, false);         }     }     userListMenu.Display(client, 20);          return Plugin_Handled; }  But that didn't really seem to work. It's telling me "Cannot find method or property Menu.AddTargetsToMenu"

AddTargetsToMenu isn't a Menu function. It does not belong to any method map. To use it you would do:

PHP Code:

AddTargetsToMenu(userListMenu, i, true, false); 


Take a look at: https://sm.alliedmods.net/new-api/ad...dTargetsToMenu

Also, if you are using AddTargetsToMenu you do not loop through players. It will add every player (respecting immunity) to the menu already.

[condolent]

Okay so this is what it looks like in the end:

PHP Code:

public Action sm_checkrespawn(int client, int args) {
    
    Menu usrMenu = new Menu(userMenuHandler, MENU_ACTIONS_ALL);
    usrMenu.SetTitle("Check respawns");
    
    AddTargetsToMenu(usrMenu, 0, true, false);
    
    usrMenu.Display(client, 20);
    
    return Plugin_Handled;
    
} 


So I don't need to get every player with the loop and with 0 in the AddTargetsToMenu, I should be getting every single player while ignoring immunity. Not tested but in theory this should work just fine!

How would I get which user was selected in MenuAction_Select? Specifically need the selected user's userID to perform a value-check in an array.

[hmmmmm]

https://sm.alliedmods.net/new-api/ad...dTargetsToMenu

"Each item contains the userid as a string for its info"

So you can just do GetMenuItem and should give you the user id

[condolent]

Originally Posted by hmmmmm https://sm.alliedmods.net/new-api/ad...dTargetsToMenu "Each item contains the userid as a string for its info" So you can just do GetMenuItem and should give you the user id

Isn't GetMenuItem a boolean?

[fiction]

Originally Posted by condolent Isn't GetMenuItem a boolean?

The 2nd argument will contain the client's userid and the 5th will contain the name/display string.

PHP Code:

bool GetItem(int position, char[] infoBuf, int infoBufLen, int &style, char[] dispBuf, int dispBufLen)

[...]

char sInfo[64];
if(menu.GetItem(param2, sInfo, sizeof(sInfo)))
{
    GetClientOfUserId(StringToInt(sInfo));
}