Raised This Month: $32 Target: $400
 8% 

[TF2] Enhanced Item Notifications


Post New Thread Reply   
 
Thread Tools Display Modes
ddhoward
Veteran Member
Join Date: May 2012
Location: California
Old 11-04-2014 , 01:45   Re: [TF2] Enhanced Item Notifications
Reply With Quote #11

Gah, I assumed that the plugin was able to distinguish between crates of differing series, as the guy in my screencap happened to be traded 2 munition crates of one series, 2 of another, 1 of another, and 1 of another. I guess he was just spamming J or something, and the numbers just happened to match what he was traded as if they were being grouped by series. http://i.imgur.com/5eGQgnt.png
__________________

Last edited by ddhoward; 11-04-2014 at 01:53.
ddhoward is offline
ddhoward
Veteran Member
Join Date: May 2012
Location: California
Old 11-13-2014 , 18:28   Re: [TF2] Enhanced Item Notifications
Reply With Quote #12

Without this plugin:
http://i.imgur.com/mLoumaS.png

With this plugin:
http://i.imgur.com/yHJZZ5D.png

Any chance of a fix?
__________________
ddhoward is offline
404UserNotFound
BANNED
Join Date: Dec 2011
Old 11-13-2014 , 19:11   Re: [TF2] Enhanced Item Notifications
Reply With Quote #13

Dr. McKay, I love your plugins. Every time I see something new from you, it's amazing. Keep it up!
404UserNotFound is offline
pyroprotectme
Member
Join Date: Nov 2012
Location: USA
Old 11-14-2014 , 08:02   Re: [TF2] Enhanced Item Notifications
Reply With Quote #14

Nice idea. Thank you.
pyroprotectme is offline
Fearts
ferts of daeth
Join Date: Oct 2008
Old 11-16-2014 , 18:29   Re: [TF2] Enhanced Item Notifications
Reply With Quote #15

Instead of replacing all the chat messages would it be better to only replace the ones that could possibly stack?

Traded
Found
Received a gift
__________________
Fearts is offline
Dr. McKay
Sir Dr. SourceMod Plugin Approver Esq. Ltd. M.D. PhD
Join Date: Aug 2011
Location: Atlantis
Old 11-16-2014 , 23:50   Re: [TF2] Enhanced Item Notifications
Reply With Quote #16

Quote:
Originally Posted by Fearts View Post
Instead of replacing all the chat messages would it be better to only replace the ones that could possibly stack?

Traded
Found
Received a gift
Not sure what that would accomplish.
__________________
Dr. McKay is offline
Fearts
ferts of daeth
Join Date: Oct 2008
Old 11-17-2014 , 17:58   Re: [TF2] Enhanced Item Notifications
Reply With Quote #17

Quote:
Originally Posted by Dr. McKay View Post
Not sure what that would accomplish.
I might be wrong but I'm pretty sure your method doesn't display as much info as it could via the games.

For example unboxing kill streak kits. Last night I saw someone unboxing on my server with this on and it would only show: <Player> has unboxed: Kit instead of: <Player> has unboxed: Killstreak Shotgun Kit. And I just tested this myself with the plugin on/off and got a very strange result.

I unboxed 3 crate #83s. One with the plugin off and two with it on.

With it off I got: http://gyazo.com/e98ac80d023535c190d685b70723f05b

And with it on I unboxed 2 kill streak kits (shotgun and scatter gun) and it displayed no unbox message at all.
__________________

Last edited by Fearts; 11-17-2014 at 17:59.
Fearts is offline
404UserNotFound
BANNED
Join Date: Dec 2011
Old 11-17-2014 , 18:39   Re: [TF2] Enhanced Item Notifications
Reply With Quote #18

I noticed that too. Some messages appear to be missing such as earning/crafting.
404UserNotFound is offline
Fearts
ferts of daeth
Join Date: Oct 2008
Old 11-21-2014 , 00:00   Re: [TF2] Enhanced Item Notifications
Reply With Quote #19

Would be nice if you don't want to remove stuff completely just adding a cvar for each case so we can turn on/off the ones we want. Something like this:

sm_enhanced_items_cases "0,1,2,3,4" //Case numbers here will print new enhanced messages for that case type.

sm_valve_message_cases "5,6,7,8,9" //Case numbers here will use Valve's default messages.

Code:
        
        case 0: strcopy(token, maxlen, "Item_Found");
        case 1: strcopy(token, maxlen, "Item_Crafted");
        case 2: strcopy(token, maxlen, "Item_Traded");
        case 3: strcopy(token, maxlen, "Item_Purchased"); // This event isn't triggered anymore
        case 4: strcopy(token, maxlen, "Item_FoundInCrate");
        case 5: strcopy(token, maxlen, "Item_Gifted");
        // 6 and 7 appear to be unused - they print nothing (unprinted acquisition method?)
        case 8: strcopy(token, maxlen, "Item_Earned");
        case 9: strcopy(token, maxlen, "Item_Refunded");
        case 10: strcopy(token, maxlen, "Item_GiftWrapped");
        // 11 through 14 appear to be unused - they print (null) on the client
        case 15: strcopy(token, maxlen, "Item_PeriodicScoreReward");
        case 16: strcopy(token, maxlen, "Item_MvMBadgeCompletionReward");
        case 17: strcopy(token, maxlen, "Item_MvMSquadSurplusReward");
        case 18: strcopy(token, maxlen, "Item_HolidayGift");
        // 19 is "received from the community market", but there's no translation token for it
        // If we wanted we could maybe use Item_Purchased but this also covers items that the player listed and has just removed the listing for
        case 20: strcopy(token, maxlen, "Item_RecipeOutput");
        default: strcopy(token, maxlen, "Item_Found"); // The game defaults to "found"
I don't think it would be that hard to do. Really my main issue at the moment is the unbox messages. Showing part of a item name or not showing a unbox message at all for some items is really unacceptable.
__________________

Last edited by Fearts; 11-21-2014 at 00:06.
Fearts is offline
Dr. McKay
Sir Dr. SourceMod Plugin Approver Esq. Ltd. M.D. PhD
Join Date: Aug 2011
Location: Atlantis
Old 11-21-2014 , 00:43   Re: [TF2] Enhanced Item Notifications
Reply With Quote #20

Did you get any errors when you unboxed your stuff?
__________________
Dr. McKay is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 01:05.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode