[V1VID]

Oh, it's probably some weird floating-point thing, then, or might be on Updater's end. Thanks for checking them out, and for the quick response.

[Leonardo]

L 06/23/2012 - 21:20:20: [SM] Native "GetEntProp" reported: Entity -1 (-1) is invalid
L 06/23/2012 - 21:20:20: [SM] Displaying call stack trace for plugin "tf_market_crit.smx":
L 06/23/2012 - 21:20:20: [SM]   [0]  Line 156, tf_market_crit.sp::GetItemIndex()
L 06/23/2012 - 21:20:20: [SM]   [1]  Line 129, tf_market_crit.sp::OnWeaponSwitch()

[Minoost]

Originally Posted by Leonardo L 06/23/2012 - 21:20:20: [SM] Native "GetEntProp" reported: Entity -1 (-1) is invalid L 06/23/2012 - 21:20:20: [SM] Displaying call stack trace for plugin "tf_market_crit.smx": L 06/23/2012 - 21:20:20: [SM] [0] Line 156, tf_market_crit.sp::GetItemIndex() L 06/23/2012 - 21:20:20: [SM] [1] Line 129, tf_market_crit.sp::OnWeaponSwitch()

This can be easily done by check valid entity

PHP Code:

public Action:OnWeaponSwitch(client, weapon)
{
    if (!IsClientInGame(client) || !IsPlayerAlive(client))
        return Plugin_Continue;
    
    if (!IsValidEdict(weapon))
        return Plugin_Continue;
    
    new iNextEquip = GetItemIndex(weapon); 


i'll fix it when next update (If you using Updater, Already updated to 1.2.1.1)

[FlaminSarge]

There's a slight issue with this. The crits that the Market Gardener deals are only dealt while the client remains in midair. If you swing while in midair, but only hit after you've landed (due to the slight delay between swinging and hitting), you do not crit.
However, with this plugin installed, because you're critboosted while you swing, it appears you do crit even after you've landed (regardless of whether the critboost is still there or not). This is a deviation from normal Market Gardener behavior.

[humbugtheman]

Originally Posted by FlaminSarge I believe the weapon switch hook does not fire when a player is forced to switch weapons due to running out of ammo, etc. Just a heads up.

I just tested this out, and it appears that it does fire when a player is forced to switch weapons due to running out of ammo.

[FlaminSarge]

Interesting. Might have changed, as when I had the VisibleWeapons plugin a long while ago, it didn't seem to fire when you automatically switched weapons.

Minoost: In order to prevent the bug I mentioned a few posts up where the MG crits where it shouldn't, why not use cond 46, the focus effect? It causes the weapon to have electricity around it, etc. In fact, you could even safely use TFCond_Buffed (though you'd have to account for actual Buff Banners then), as the minicrit damage only applies while the cond is active (whereas currently you'll crit as long as you swing before the crit disappears regardless of whether you cause damage after the crit disappears).

[Minoost]

Originally Posted by FlaminSarge Interesting. Might have changed, as when I had the VisibleWeapons plugin a long while ago, it didn't seem to fire when you automatically switched weapons. Minoost: In order to prevent the bug I mentioned a few posts up where the MG crits where it shouldn't, why not use cond 46, the focus effect? It causes the weapon to have electricity around it, etc. In fact, you could even safely use TFCond_Buffed (though you'd have to account for actual Buff Banners then), as the minicrit damage only applies while the cond is active (whereas currently you'll crit as long as you swing before the crit disappears regardless of whether you cause damage after the crit disappears).

hmm, why i didn't know that. i'm stupid.
anyway, i'll fix it next update.

[Lanc]

I have a little problem with this plugin. It constantly showing errors in sourcemod logs. I have the latest version of this plugin. Here is log

 09/01/2012 - 05:24:38: [SM] Displaying call stack trace for plugin "tf_market_crit.smx":
L 09/01/2012 - 05:24:38: [SM]   [0]  Line 156, C:\Users\ąĚłë\Desktop\ąĚłë\ŔÚ·á ą× ŔŰľ÷\ŔŰľ÷\ĆŔ Ć÷Ć®¸®˝ş 2 Ľ*ąö ŔŰľ÷ ą× ŔÚ·á\ÇĂ·Ż±×ŔÎ\addons\sourcemod\scripting\tf_market_crit.sp::GetItemIndex()
L 09/01/2012 - 05:24:38: [SM]   [1]  Line 129, C:\Users\ąĚłë\Desktop\ąĚłë\ŔÚ·á ą× ŔŰľ÷\ŔŰľ÷\ĆŔ Ć÷Ć®¸®˝ş 2 Ľ*ąö ŔŰľ÷ ą× ŔÚ·á\ÇĂ·Ż±×ŔÎ\addons\sourcemod\scripting\tf_market_crit.sp::OnWeaponSwitch()
L 09/01/2012 - 05:24:38: [SM] Native "GetEntProp" reported: Entity -1 (-1) is invalid
L 09/01/2012 - 05:24:38: [SM] Displaying call stack trace for plugin "tf_market_crit.smx":
L 09/01/2012 - 05:24:38: [SM]   [0]  Line 156, C:\Users\ąĚłë\Desktop\ąĚłë\ŔÚ·á ą× ŔŰľ÷\ŔŰľ÷\ĆŔ Ć÷Ć®¸®˝ş 2 Ľ*ąö ŔŰľ÷ ą× ŔÚ·á\ÇĂ·Ż±×ŔÎ\addons\sourcemod\scripting\tf_market_crit.sp::GetItemIndex()
L 09/01/2012 - 05:24:38: [SM]   [1]  Line 129, C:\Users\ąĚłë\Desktop\ąĚłë\ŔÚ·á ą× ŔŰľ÷\ŔŰľ÷\ĆŔ Ć÷Ć®¸®˝ş 2 Ľ*ąö ŔŰľ÷ ą× ŔÚ·á\ÇĂ·Ż±×ŔÎ\addons\sourcemod\scripting\tf_market_crit.sp::OnWeaponSwitch()
L 09/01/2012 - 05:36:49: [SM] Native "GetEntProp" reported: Entity -1 (-1) is invalid
L 09/01/2012 - 05:36:49: [SM] Displaying call stack trace for plugin "tf_market_crit.smx":
L 09/01/2012 - 05:36:49: [SM]   [0]  Line 156, C:\Users\ąĚłë\Desktop\ąĚłë\ŔÚ·á ą× ŔŰľ÷\ŔŰľ÷\ĆŔ Ć÷Ć®¸®˝ş 2 Ľ*ąö ŔŰľ÷ ą× ŔÚ·á\ÇĂ·Ż±×ŔÎ\addons\sourcemod\scripting\tf_market_crit.sp::GetItemIndex()
L 09/01/2012 - 05:36:49: [SM]   [1]  Line 129, C:\Users\ąĚłë\Desktop\ąĚłë\ŔÚ·á ą× ŔŰľ÷\ŔŰľ÷\ĆŔ Ć÷Ć®¸®˝ş 2 Ľ*ąö ŔŰľ÷ ą× ŔÚ·á\ÇĂ·Ż±×ŔÎ\addons\sourcemod\scripting\tf_market_crit.sp::OnWeaponSwitch()
L 09/01/2012 - 05:36:49: [SM] Native "GetEntProp" reported: Entity -1 (-1) is invalid
L 09/01/2012 - 05:36:49: [SM] Displaying call stack trace for plugin "tf_market_crit.smx":
L 09/01/2012 - 05:36:49: [SM]   [0]  Line 156, C:\Users\ąĚłë\Desktop\ąĚłë\ŔÚ·á ą× ŔŰľ÷\ŔŰľ÷\ĆŔ Ć÷Ć®¸®˝ş 2 Ľ*ąö ŔŰľ÷ ą× ŔÚ·á\ÇĂ·Ż±×ŔÎ\addons\sourcemod\scripting\tf_market_crit.sp::GetItemIndex()
L 09/01/2012 - 05:36:49: [SM]   [1]  Line 129, C:\Users\ąĚłë\Desktop\ąĚłë\ŔÚ·á ą× ŔŰľ÷\ŔŰľ÷\ĆŔ Ć÷Ć®¸®˝ş 2 Ľ*ąö ŔŰľ÷ ą× ŔÚ·á\ÇĂ·Ż±×ŔÎ\addons\sourcemod\scripting\tf_market_crit.sp::OnWeaponSwitch()

[FlaminSarge]

I did a few fixups (mainly the invalid entity thing) and made it use cond 46 instead of actual crits. This should add the crit sparks but not cause it to crit when the client's already landed. The weapon won't glow, however. Nothing to do about that.