[xerox8521]

each curly bracket belongs on its own line. It IMHO looks ugly when you write like

PHP Code:

if(cond) { 


as it decreases the readabililty because you cannot clearly say which { belongs to its closing counter part. For some Prop names i tend to use the prop names itself as variable like m_iAmmo or m_hActiveWeapon. Also for the example i would check the convar first before checking if it is an ingame client because why bother if it is a client from ingame or not if it is disabled anyway

[DarkDeviL]

Originally Posted by xerox8521 each curly bracket belongs on its own line. It IMHO looks ugly when you write like PHP Code: if(cond) {  as it decreases the readabililty because you cannot clearly say which { belongs to its closing counter part. For some Prop names i tend to use the prop names itself as variable like m_iAmmo or m_hActiveWeapon. Also for the example i would check the convar first before checking if it is an ingame client because why bother if it is a client from ingame or not if it is disabled anyway

It does indeed look ugly when you are wasting an entire line on a single opening bracket, which you can already tell from if/for/while that it is here the code is starting.

I tend to agree with #3 and #4.

Speaking of ugly things, I also find one-liner messages on forums being quite ugly.

If you are currently working on a project, even if it uses the opposite of what you feel for yourself, then follow that project's current coding style in order to keep the coding style of that project identical everywhere.

[KissLick]

Originally Posted by arne1288 If you are currently working on a project, even if it uses the opposite of what you feel for yourself, then follow that project's current coding style in order to keep the coding style of that project identical everywhere.

+2

[Drixevel]

I'm probably one of the only coders that uses lines for no reason while saving lines for no reason since I use brackets for every function, just looks cleaner to me.

public void somefunction()
{
	if (somecheck || someothercheck)
	{
		return value;
	}

	if (notsomecheck)
	{
		return value;
	}

	//do actual stuff
}

[Deathknife]

Originally Posted by xerox8521 each curly bracket belongs on its own line. It IMHO looks ugly when you write like PHP Code: if(cond) {  as it decreases the readabililty because you cannot clearly say which { belongs to its closing counter part. For some Prop names i tend to use the prop names itself as variable like m_iAmmo or m_hActiveWeapon. Also for the example i would check the convar first before checking if it is an ingame client because why bother if it is a client from ingame or not if it is disabled anyway

{ on each line looks weird. With indentation it's really easy to identify which { belongs to which }

[klippy]

I like putting { on new line, but not in JavaScript. Oh boy, do those lambdas look ugly with such coding style.

Anyway, arne1288 gave you the best answer - no coding style is the best, just be consistent.

[hleV]

For me personally

PHP Code:

condition
{
    statement
}

if (x)
{
    x = y;
} 


is more readable, however in languages that open blocks with words rather than brackets

PHP Code:

condition open
    statement
close

if x then
    x = y;
end 


it's better to keep the opening on the same line as condition because

PHP Code:

condition
open
    statement
close

if x 
then 
    x = y
end 


just seems out of place.

[xerox8521]

Originally Posted by redwerewolf I'm probably one of the only coders that uses lines for no reason while saving lines for no reason since I use brackets for every function, just looks cleaner to me. public void somefunction() { if (somecheck || someothercheck) { return value; } if (notsomecheck) { return value; } //do actual stuff }

looks neat and clearly visible without having to guess where A starts and B Ends

[ofir753]

As you see its a personal preference, anyway an experienced coder could read all of them but I personally prefer the 2nd option.

[DarkDeviL]

Originally Posted by xerox8521 looks neat and clearly visible without having to guess where A starts and B Ends

If you really need to "guess" around like that, then you should seriously not be touching any code at all.

(No matter if the code is written the one or other way!)